Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137801/?format=api
{ "id": 137801, "url": "http://patches.dpdk.org/api/patches/137801/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240302135328.531940-2-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240302135328.531940-2-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240302135328.531940-2-mattias.ronnblom@ericsson.com", "date": "2024-03-02T13:53:22", "name": "[RFC,1/7] eal: extend bit manipulation functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2fed8066774d16bc2fd5ca2289bc3153577adcdf", "submitter": { "id": 1077, "url": "http://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240302135328.531940-2-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31345, "url": "http://patches.dpdk.org/api/series/31345/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31345", "date": "2024-03-02T13:53:21", "name": "Improve EAL bit operations API", "version": 1, "mbox": "http://patches.dpdk.org/series/31345/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137801/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/137801/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B775043C3A;\n\tSat, 2 Mar 2024 15:02:23 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5C8B742D66;\n\tSat, 2 Mar 2024 15:02:18 +0100 (CET)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur04on2085.outbound.protection.outlook.com [40.107.8.85])\n by mails.dpdk.org (Postfix) with ESMTP id 4CC72400D5\n for <dev@dpdk.org>; Sat, 2 Mar 2024 15:02:16 +0100 (CET)", "from AM0PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:208:1::41)\n by DBAPR07MB6549.eurprd07.prod.outlook.com (2603:10a6:10:186::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.32; Sat, 2 Mar\n 2024 14:02:14 +0000", "from AM4PEPF00027A69.eurprd04.prod.outlook.com\n (2603:10a6:208:1:cafe::30) by AM0PR04CA0064.outlook.office365.com\n (2603:10a6:208:1::41) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.36 via Frontend\n Transport; Sat, 2 Mar 2024 14:02:14 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n AM4PEPF00027A69.mail.protection.outlook.com (10.167.16.87) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7362.11 via Frontend Transport; Sat, 2 Mar 2024 14:02:14 +0000", "from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.62) with Microsoft SMTP Server\n id 15.2.1258.12; Sat, 2 Mar 2024 15:02:13 +0100", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id\n AF30B1C006A; Sat, 2 Mar 2024 15:02:13 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=UHgc8D1bDOLHLOiDHICeivseQ1UFHIT7/8DqnrNFJkIi9ZXW7B8aUvyZgUlwDxZXe8YlTPppXcTUCDDl+9lPHIq3OtndmaIu0JG7y1wYUDt4hMmvQPtjO+uOFImlu04qghxEWUWrxnUiYR7T2E8KD4FbPaYuqMpLpYS+wH7vPhVYWKtHk1Q4d/MC9BRGldmQxbCbetWKaHKhIglT7Jg877o4lwy1JgAJqtZ58MRzuUB963DtwNpFWpWdcv46eXZjhku8RXs93h8tchHix1gbr0an3Mvw1jyE8BIO7v9I7Csu8rM4YTrpf+bkXPnUMtrtjcwGC65YuUBQzpBrWzV9pw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=SM8IGRjrTAoWi97L464kK8j1ZttmMeaybTdxjWzZlAQ=;\n b=BPCezhtZVwcFCT7ayxbSY1ckIe1B32dfxUOJGD9j1bLD7c160JuyiRFrTLdPnOoQBhD45qIsEmKK2AT9nnNJ2PkBwFlgG2AKZvHH4h3z11eFvzN/35MOIqoNVAo2mHrLIG2ZxbvEOxx1ORoMoOw8khQUsix4XM1lxFXsg+ro+hxgCf29pGjdyBk4I0FTfNz5ClDQhh2aM+XL6apzsQWC3eAQKPl/vVRg0x7gWSVoYdvrxWSk0sEgaqKNrsBzMWsbQ4kglhnzSSw+xuwrT/dlQy7G3Ai7YNwsFh/kSo6jhJj1tZ1QaUcmtysscxXLo/JsgFp3T9pS9D1zsTYvmIYWtw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=SM8IGRjrTAoWi97L464kK8j1ZttmMeaybTdxjWzZlAQ=;\n b=PxZMwGPEY/GjO/15mYZmpWmBukgIYLNOOXM+7hb4bmHWJfWuzYwHHEAHi/XapvWMO3ruIXhEkGAijH39ZoJZgs7nzzwkUhpVVtLFY8M6SoFNXE4G477fAIFFkqOwxg9wPDEtzXLp6AUrcKuI/6Cg8Wc73GuByvgech/45VGOofrha6XiNa64luEkqIeSQugZY40ObQAP+wpVLcDPzayhFIx0ivxBMxKgwNEtjZiJtYs2QFnupPWq5OTm0pct1su2un19BIoAXw+MqZe6t/wU4euZEdbvhIJBHS7OLJLiRuTbRaMn+D9KAI0byZrpgzxMPTwLeDL3b+7/IDuc2TrOWg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>, Heng Wang <heng.wang@ericsson.com>, =?utf-8?q?M?=\n\t=?utf-8?q?attias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Subject": "[RFC 1/7] eal: extend bit manipulation functions", "Date": "Sat, 2 Mar 2024 14:53:22 +0100", "Message-ID": "<20240302135328.531940-2-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240302135328.531940-1-mattias.ronnblom@ericsson.com>", "References": "<20240302135328.531940-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AM4PEPF00027A69:EE_|DBAPR07MB6549:EE_", "X-MS-Office365-Filtering-Correlation-Id": "615df190-2ece-4eb4-5c8f-08dc3ac15d05", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n n3VxHhbhHxwc2jqsg+JnRGOmEu+Lz5M5/o2R23Mk06I8CAhJiU/wajjoSwwMFXkYy1KzyT8dHtG0IIg2m7+R9jCkAl1WXrp7FO8VRBC5tPuVR8V1fvGVydmYv+LB/0dad4XkInK4FaWmcer6PDDW7K6JTjWjw7Kixh66NRn6ZERelisULROz3wzUl6/Lo0xm8WiRNl9yV+h4RsjyWGizBhR26spi8l6zaVbKmDCb/FvBp9IQaxjfWXTaJMZC5VnlNJDDiAs6G4F3zMLmJF7+v3Wn4pLCBP10W1nkfz+QQYcPcNBPIw6Upd6BuIzJMD2DtLCwsdoQKOnRAI7BIU+PynPasJ4jT5OLPWO+wV1T2hCVZ0CAHXI1TzldyrGBt/PiUfnnqOUfQCsKeuKPieTQ6dvjWIaOxtcm0vR9Bor+PrgK0lzoq0oqsWha/Wwy20hpNOTgOD30myuWWWWmRF/ZEHD0bNI2VwnxCQKDGmjYkXs3+Y98qRLZ4z4xs2hSoMGI4HjCRBRm9WAENraC1Qdb0wVLmQhjGONWbDsk5EM46MbMpgkklezPl4uLtd23obM/Hs5P5M3gRL7ULOGVrdf7WVM7teNe+y/n5N8J3cfwEG4iBTDM7O6Yla5O78TU/E1sHCvx9DTovasBvh/TwxNeEnQwKwomGlVpGUylUnvo1Va89GY1jM/F6wAL1olbvzs9bCJ97KlMQpDIKe8BILVTEF+IMP//ytR7lyjxbrE3AB8dOT7bsmoyoSMlbCMnYKmy", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(376005)(36860700004)(82310400014); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Mar 2024 14:02:14.2874 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 615df190-2ece-4eb4-5c8f-08dc3ac15d05", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n AM4PEPF00027A69.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DBAPR07MB6549", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add functionality to test, set, clear, and assign the value to\nindividual bits in 32-bit or 64-bit words.\n\nThese functions have no implications on memory ordering, atomicity and\ndoes not use volatile and thus does not prevent any compiler\noptimizations.\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n lib/eal/include/rte_bitops.h | 194 ++++++++++++++++++++++++++++++++++-\n 1 file changed, 192 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h\nindex 449565eeae..9a368724d5 100644\n--- a/lib/eal/include/rte_bitops.h\n+++ b/lib/eal/include/rte_bitops.h\n@@ -2,6 +2,7 @@\n * Copyright(c) 2020 Arm Limited\n * Copyright(c) 2010-2019 Intel Corporation\n * Copyright(c) 2023 Microsoft Corporation\n+ * Copyright(c) 2024 Ericsson AB\n */\n \n #ifndef _RTE_BITOPS_H_\n@@ -11,8 +12,9 @@\n * @file\n * Bit Operations\n *\n- * This file defines a family of APIs for bit operations\n- * without enforcing memory ordering.\n+ * This file provides functionality for low-level, single-word\n+ * arithmetic and bit-level operations, such as counting or\n+ * setting individual bits.\n */\n \n #include <stdint.h>\n@@ -105,6 +107,194 @@ extern \"C\" {\n #define RTE_FIELD_GET64(mask, reg) \\\n \t\t((typeof(mask))(((reg) & (mask)) >> rte_ctz64(mask)))\n \n+/**\n+ * Test if a particular bit in a 32-bit word is set.\n+ *\n+ * This function does not give any guarantees in regards to memory\n+ * ordering or atomicity.\n+ *\n+ * @param addr\n+ * A pointer to the 32-bit word to query.\n+ * @param nr\n+ * The index of the bit (0-31).\n+ * @return\n+ * Returns true if the bit is set, and false otherwise.\n+ */\n+static inline bool\n+rte_bit_test32(const uint32_t *addr, unsigned int nr);\n+\n+/**\n+ * Set bit in 32-bit word.\n+ *\n+ * Set bit specified by @c nr in the 32-bit word pointed to by\n+ * @c addr to '1'.\n+ *\n+ * This function does not give any guarantees in regards to memory\n+ * ordering or atomicity.\n+ *\n+ * @param addr\n+ * A pointer to the 32-bit word to modify.\n+ * @param nr\n+ * The index of the bit (0-31).\n+ */\n+static inline void\n+rte_bit_set32(uint32_t *addr, unsigned int nr);\n+\n+/**\n+ * Clear bit in 32-bit word.\n+ *\n+ * Set bit specified by @c nr in the 32-bit word pointed to by\n+ * @c addr to '0'.\n+ *\n+ * This function does not give any guarantees in regards to memory\n+ * ordering or atomicity.\n+ *\n+ * @param addr\n+ * A pointer to the 32-bit word to modify.\n+ * @param nr\n+ * The index of the bit (0-31).\n+ */\n+static inline void\n+rte_bit_clear32(uint32_t *addr, unsigned int nr);\n+\n+/**\n+ * Assign a value to bit in a 32-bit word.\n+ *\n+ * Set bit specified by @c nr in the 32-bit word pointed to by\n+ * @c addr to the value indicated by @c value.\n+ *\n+ * This function does not give any guarantees in regards to memory\n+ * ordering or atomicity.\n+ *\n+ * @param addr\n+ * A pointer to the 32-bit word to modify.\n+ * @param nr\n+ * The index of the bit (0-31).\n+ * @param value\n+ * The new value of the bit - true for '1', or false for '0'.\n+ */\n+static inline void\n+rte_bit_assign32(uint32_t *addr, unsigned int nr, bool value)\n+{\n+\tif (value)\n+\t\trte_bit_set32(addr, nr);\n+\telse\n+\t\trte_bit_clear32(addr, nr);\n+}\n+\n+/**\n+ * Test if a particular bit in a 64-bit word is set.\n+ *\n+ * This function does not give any guarantees in regards to memory\n+ * ordering or atomicity.\n+ *\n+ * @param addr\n+ * A pointer to the 64-bit word to query.\n+ * @param nr\n+ * The index of the bit (0-63).\n+ * @return\n+ * Returns true if the bit is set, and false otherwise.\n+ */\n+static inline bool\n+rte_bit_test64(const uint64_t *addr, unsigned int nr);\n+\n+/**\n+ * Set bit in 64-bit word.\n+ *\n+ * Set bit specified by @c nr in the 64-bit word pointed to by\n+ * @c addr to '1'.\n+ *\n+ * This function does not give any guarantees in regards to memory\n+ * ordering or atomicity.\n+ *\n+ * @param addr\n+ * A pointer to the 64-bit word to modify.\n+ * @param nr\n+ * The index of the bit (0-63).\n+ */\n+static inline void\n+rte_bit_set64(uint64_t *addr, unsigned int nr);\n+\n+/**\n+ * Clear bit in 64-bit word.\n+ *\n+ * Set bit specified by @c nr in the 64-bit word pointed to by\n+ * @c addr to '0'.\n+ *\n+ * This function does not give any guarantees in regards to memory\n+ * ordering or atomicity.\n+ *\n+ * @param addr\n+ * A pointer to the 64-bit word to modify.\n+ * @param nr\n+ * The index of the bit (0-63).\n+ */\n+static inline void\n+rte_bit_clear64(uint64_t *addr, unsigned int nr);\n+\n+/**\n+ * Assign a value to bit in a 64-bit word.\n+ *\n+ * Set bit specified by @c nr in the 64-bit word pointed to by\n+ * @c addr to the value indicated by @c value.\n+ *\n+ * This function does not give any guarantees in regards to memory\n+ * ordering or atomicity.\n+ *\n+ * @param addr\n+ * A pointer to the 64-bit word to modify.\n+ * @param nr\n+ * The index of the bit (0-63).\n+ * @param value\n+ * The new value of the bit - true for '1', or false for '0'.\n+ */\n+static inline void\n+rte_bit_assign64(uint64_t *addr, unsigned int nr, bool value)\n+{\n+\tif (value)\n+\t\trte_bit_set64(addr, nr);\n+\telse\n+\t\trte_bit_clear64(addr, nr);\n+}\n+\n+#define __RTE_GEN_BIT_TEST(name, size, qualifier)\t\t\t\\\n+\tstatic inline bool\t\t\t\t\t\t\\\n+\tname(const qualifier uint ## size ## _t *addr, unsigned int nr)\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tRTE_ASSERT(nr < size);\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tuint ## size ## _t mask = (uint ## size ## _t)1 << nr;\t\\\n+\t\treturn *addr & mask;\t\t\t\t\t\\\n+\t}\n+\n+#define __RTE_GEN_BIT_SET(name, size, qualifier)\t\t\t\\\n+\tstatic inline void\t\t\t\t\t\t\\\n+\tname(qualifier uint ## size ## _t *addr, unsigned int nr)\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tRTE_ASSERT(nr < size);\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tuint ## size ## _t mask = (uint ## size ## _t)1 << nr;\t\\\n+\t\t*addr |= mask;\t\t\t\t\t\t\\\n+\t}\t\t\t\t\t\t\t\t\\\n+\n+#define __RTE_GEN_BIT_CLEAR(name, size, qualifier)\t\t\t\\\n+\tstatic inline void\t\t\t\t\t\t\\\n+\tname(qualifier uint ## size ## _t *addr, unsigned int nr)\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\tRTE_ASSERT(nr < size);\t\t\t\t\t\\\n+\t\t\t\t\t\t\t\t\t\\\n+\t\tuint ## size ## _t mask = ~((uint ## size ## _t)1 << nr); \\\n+\t\t(*addr) &= mask;\t\t\t\t\t\\\n+\t}\t\t\t\t\t\t\t\t\\\n+\n+__RTE_GEN_BIT_TEST(rte_bit_test32, 32,)\n+__RTE_GEN_BIT_SET(rte_bit_set32, 32,)\n+__RTE_GEN_BIT_CLEAR(rte_bit_clear32, 32,)\n+\n+__RTE_GEN_BIT_TEST(rte_bit_test64, 64,)\n+__RTE_GEN_BIT_SET(rte_bit_set64, 64,)\n+__RTE_GEN_BIT_CLEAR(rte_bit_clear64, 64,)\n+\n /*------------------------ 32-bit relaxed operations ------------------------*/\n \n /**\n", "prefixes": [ "RFC", "1/7" ] }