Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 137768,
    "url": "http://patches.dpdk.org/api/patches/137768/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240301175842.159967-5-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240301175842.159967-5-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240301175842.159967-5-stephen@networkplumber.org",
    "date": "2024-03-01T17:57:09",
    "name": "[4/6] net/qede: replace use of rand()",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "24e8cdf605c1a1bf57ef8e3fa1efe5b5517c0e43",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240301175842.159967-5-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 31342,
            "url": "http://patches.dpdk.org/api/series/31342/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31342",
            "date": "2024-03-01T17:57:05",
            "name": "Coverity related fixes",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/31342/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/137768/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/137768/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2E0143BCF;\n\tFri,  1 Mar 2024 18:59:18 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 82B46433EF;\n\tFri,  1 Mar 2024 18:59:00 +0100 (CET)",
            "from mail-oi1-f171.google.com (mail-oi1-f171.google.com\n [209.85.167.171])\n by mails.dpdk.org (Postfix) with ESMTP id BA56C4336E\n for <dev@dpdk.org>; Fri,  1 Mar 2024 18:58:56 +0100 (CET)",
            "by mail-oi1-f171.google.com with SMTP id\n 5614622812f47-3c19bc08f96so1969369b6e.2\n for <dev@dpdk.org>; Fri, 01 Mar 2024 09:58:56 -0800 (PST)",
            "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n bw7-20020a056a02048700b005e438ea2a5asm2938828pgb.53.2024.03.01.09.58.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 Mar 2024 09:58:55 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709315936;\n x=1709920736; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lAKHHOeyOrADvZoZlagpBMrnt1cOInFGnnxvfeaQEQ8=;\n b=xJrLvunXporpcnLXV+NXYPbl+8AVaAlCpCIVo7WyYu6PSJNY0QJxcImNkM/DjNt22v\n EhDPxZ0mkgq4QF2M4N6GydXWWb3/V3cxVBlWtQ1ELulqg1FY56oaHIJ9Hoyvr3CFn3V5\n ksZDX0S3UpzzKUTRby6l9rjU1v8AxIJd8h0mdCGWgNhk1/mgLvj1TvFj5EWF+1PiLz81\n PekPABf6tcYc2WFrkPNzIRpY+1CZB3n8gKEy9/E//2IYr7bx85dUhhE4JLQHo4JHw3Kz\n CCvv8WB18I4oRV8jrGa2HizW3NRT4mID4Fav5lv0yuyhkMHcntnQgFesN1/NiYg6p6CB\n 68uA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709315936; x=1709920736;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=lAKHHOeyOrADvZoZlagpBMrnt1cOInFGnnxvfeaQEQ8=;\n b=gGqajXTi/zvvvCzovrtvRa2dQmCVyUKeFTqrPgXZZ5eutCxZXMktA2IMohhFVRMeCQ\n xRo4p+z/TjK50542oZwdIPrrV0du3gpXFyqrjs00LAVCRcUaNl4f92BT4yXpLez7/DiQ\n eh4b68sCXexLhpul/qgmnUW64FgcaRQ420enosb9RxiCMlYa389fwvQafuwuDerHkH8j\n 6rVS/wO5wf8t63ts0gFniZ8sF2haVrna/mTrduHUt0a/r5EybESZIW92TTy0QW5UR5g8\n OvASHNm2AUF/xIxX9irZ0Ra05rcedhCQH0RC32levxqvpH3Su4HAV6840AJBwJhsySMU\n R7dA==",
        "X-Gm-Message-State": "AOJu0Yy0qhhJEIIF73nh/CKEwamaSyb0XlOS6QVJ+sj+3zwuhSpgZ4ph\n EV+81HEbmHn5sE4TIEGf944hXX6EZ5bq90zgtR+3TbplIHtE2cKbB+WHnk/3b0PND9Qhclc04vN\n 8mm7wUg==",
        "X-Google-Smtp-Source": "\n AGHT+IHPn9KP0rQzAALHQPlMEkl3YkyF5NusNoK+qwDldg6pQN8dE9YmRibsSsLLZLPQpsUJ+aMArg==",
        "X-Received": "by 2002:a05:6808:1492:b0:3c1:7c55:3730 with SMTP id\n e18-20020a056808149200b003c17c553730mr2569537oiw.42.1709315936034;\n Fri, 01 Mar 2024 09:58:56 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Alok Prasad <palok@marvell.com>",
        "Subject": "[PATCH 4/6] net/qede: replace use of rand()",
        "Date": "Fri,  1 Mar 2024 09:57:09 -0800",
        "Message-ID": "<20240301175842.159967-5-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.43.0",
        "In-Reply-To": "<20240301175842.159967-1-stephen@networkplumber.org>",
        "References": "<20240301175842.159967-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The function of rand() is a weak random number generator.\nUse the DPDK rte_rand() instead.\n\nNote: this doesn't matter for real security, since most drivers\nuse a fixed RSS default key.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/qede/qede_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex 254548d40638..bee9fa4f60a1 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -7,6 +7,7 @@\n #include \"qede_ethdev.h\"\n #include <rte_string_fns.h>\n #include <rte_alarm.h>\n+#include <rte_random.h>\n #include <rte_kvargs.h>\n \n static const struct qed_eth_ops *qed_ops;\n@@ -1040,9 +1041,8 @@ static void qede_prandom_bytes(uint32_t *buff)\n {\n \tuint8_t i;\n \n-\tsrand((unsigned int)time(NULL));\n \tfor (i = 0; i < ECORE_RSS_KEY_SIZE; i++)\n-\t\tbuff[i] = rand();\n+\t\tbuff[i] = rte_rand();\n }\n \n int qede_config_rss(struct rte_eth_dev *eth_dev)\n",
    "prefixes": [
        "4/6"
    ]
}