Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 137766,
    "url": "http://patches.dpdk.org/api/patches/137766/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240301175842.159967-3-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240301175842.159967-3-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240301175842.159967-3-stephen@networkplumber.org",
    "date": "2024-03-01T17:57:07",
    "name": "[2/6] net/tap: log if netlink ext ack not possible",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "46b0bad70ae08e0f37d59d903d43d1b50fc03809",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240301175842.159967-3-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 31342,
            "url": "http://patches.dpdk.org/api/series/31342/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31342",
            "date": "2024-03-01T17:57:05",
            "name": "Coverity related fixes",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/31342/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/137766/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/137766/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03D5843BCF;\n\tFri,  1 Mar 2024 18:59:06 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AA647433B0;\n\tFri,  1 Mar 2024 18:58:57 +0100 (CET)",
            "from mail-pg1-f173.google.com (mail-pg1-f173.google.com\n [209.85.215.173])\n by mails.dpdk.org (Postfix) with ESMTP id 71CFA43356\n for <dev@dpdk.org>; Fri,  1 Mar 2024 18:58:55 +0100 (CET)",
            "by mail-pg1-f173.google.com with SMTP id\n 41be03b00d2f7-5cddfe0cb64so1744800a12.0\n for <dev@dpdk.org>; Fri, 01 Mar 2024 09:58:55 -0800 (PST)",
            "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n bw7-20020a056a02048700b005e438ea2a5asm2938828pgb.53.2024.03.01.09.58.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 Mar 2024 09:58:54 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709315934;\n x=1709920734; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lGQdDTVn0PvkRIF4u+Q6CDCVKPY8i2MnOJieV6tbf/Y=;\n b=VYHTYTCxWtfYw1AAFi6f0SsLHgc72qAqbs3t/wNd95o2RRazpcQvp/O/GzwkyUNb/L\n oqBS50A2p9E+YEzPnJxmy5AvR+9+oq4abBN75CogfuEU8Eb4Fw+uV0IYKbcby8OcSBnX\n aMWJHCeFAnNPihWnw02zAXAWT/WSnTdWp8JONGlCnbwQGx8YDFsQkEDoxs70wsB6jqga\n FTTZuC9h4cF3kfNmv8qBvu7Y11S2imFKoAwQa5wZ1FTMb60ByoYFRLS90jefv/PlsBtW\n vskckuuH5JV+MpLeqVSelMm/7Vja9TyHjM9vn6vQqecGt2+DVz11tpGCFx6JYp6IdpA3\n JCUA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709315934; x=1709920734;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=lGQdDTVn0PvkRIF4u+Q6CDCVKPY8i2MnOJieV6tbf/Y=;\n b=Bl9uclfmlfrPNtcwtn9LepeaVhGu3i6hS99Iw68mIQ69Xgih3q+e+rRm6KkCA+a1Be\n smFSc6ZmMxipfXuvJFrCc7l5wgH7vcJ8KnSUD07rS5m26q1gnnly8qOFSnxpCpUZxaOR\n tgHV/V+J7Fn/zfUx895BIuSBU9zCPFdjMHiD2t94zRiF1mogUXZ1D1avlK9Cw2ld5ZZ1\n WKnW5G3vNHrQTxmZPaTnG5/eYwOvQ9ZQFdCRoiYI3Dw1HlpowJnGKgQwzHPqwZkiUpwt\n iipRjsw+7//h1fwCubX1+hLYqFSNFtDAZ1X+ABp7/dPAmblh2YEdF7WWa8ck4XlUMLwF\n vg1Q==",
        "X-Gm-Message-State": "AOJu0YyrqELpnN8QC7sa3jinIB/86dI4QYYJt8hEqy7bi6TsX3aCZ3fo\n QpteFBdCCZ19i1RrJWupGIns53Iqh83sJjb3mHSualmxVBlXMR/Xc12Tf/NiKH0S666q0Y9Bl5v\n 7V2KKgg==",
        "X-Google-Smtp-Source": "\n AGHT+IFbvWZx9n1kOVk+Y8YiRHlmFyCmtA/cf3GnWOflaU51BKAu03doKltUnGV5edZUj0chlDQHxQ==",
        "X-Received": "by 2002:a05:6a20:7f99:b0:1a0:f3d0:15af with SMTP id\n d25-20020a056a207f9900b001a0f3d015afmr2182029pzj.34.1709315934607;\n Fri, 01 Mar 2024 09:58:54 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Keith Wiles <keith.wiles@intel.com>",
        "Subject": "[PATCH 2/6] net/tap: log if netlink ext ack not possible",
        "Date": "Fri,  1 Mar 2024 09:57:07 -0800",
        "Message-ID": "<20240301175842.159967-3-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.43.0",
        "In-Reply-To": "<20240301175842.159967-1-stephen@networkplumber.org>",
        "References": "<20240301175842.159967-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "If kernel doesn't support external ack, log that to aide\nin any problem diagnosis.\n\nCoverity issue: 362848\nFixes: 647909bcf34b (\"net/tap: use netlink extended ack support\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/tap_netlink.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/tap/tap_netlink.c b/drivers/net/tap/tap_netlink.c\nindex 75af3404b035..d9c260127d52 100644\n--- a/drivers/net/tap/tap_netlink.c\n+++ b/drivers/net/tap/tap_netlink.c\n@@ -72,7 +72,8 @@ tap_nl_init(uint32_t nl_groups)\n \n #ifdef NETLINK_EXT_ACK\n \t/* Ask for extended ACK response. on older kernel will ignore request. */\n-\tsetsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, &one, sizeof(one));\n+\tif (setsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, &one, sizeof(one)) < 0)\n+\t\tTAP_LOG(NOTICE, \"Unable to request netlink error information\");\n #endif\n \n \tif (bind(fd, (struct sockaddr *)&local, sizeof(local)) < 0) {\n",
    "prefixes": [
        "2/6"
    ]
}