Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 137719,
    "url": "http://patches.dpdk.org/api/patches/137719/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240301171707.95242-30-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240301171707.95242-30-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240301171707.95242-30-stephen@networkplumber.org",
    "date": "2024-03-01T17:15:25",
    "name": "[v2,29/71] net/ipn3ke: replace use of fixed size rte_memcpy",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "dd90dbd122d02f7afc6a9a329f5a39551e764f00",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240301171707.95242-30-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 31340,
            "url": "http://patches.dpdk.org/api/series/31340/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31340",
            "date": "2024-03-01T17:14:57",
            "name": "replace use of fixed size rte_mempcy",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/31340/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/137719/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/137719/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A510E43C12;\n\tFri,  1 Mar 2024 18:20:59 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9130943437;\n\tFri,  1 Mar 2024 18:17:57 +0100 (CET)",
            "from mail-pl1-f174.google.com (mail-pl1-f174.google.com\n [209.85.214.174])\n by mails.dpdk.org (Postfix) with ESMTP id 7AD43433A8\n for <dev@dpdk.org>; Fri,  1 Mar 2024 18:17:40 +0100 (CET)",
            "by mail-pl1-f174.google.com with SMTP id\n d9443c01a7336-1dca3951ad9so21947345ad.3\n for <dev@dpdk.org>; Fri, 01 Mar 2024 09:17:40 -0800 (PST)",
            "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n j14-20020a170902da8e00b001dc8d6a9d40sm3695764plx.144.2024.03.01.09.17.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 01 Mar 2024 09:17:39 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709313460;\n x=1709918260; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3UtlnItxEhj0GYMDyQyD+uneqNt6DkIIu+AK6QFO2Nk=;\n b=J6A/u8pH977TGPHm9Y7llkadbXKqBQuNrUG8R8Q4IQGJeTo38qm96f2o3U51EUCujz\n 6Qjx9wwdpXOCjfCpG5037ZeVmuYu8usb2xQa06IlRIY8VROCSqg++ANewUbqfEzjzEDE\n 8/PHPgWIGGm7v63dOj7INo903iKtDu03RMYkIv0DLkCu+inuhKFbgXpwpR/xvE/LFoMG\n Wp5Q9UkOl6/pY78jtxHGbSs2z8ZFTgIY3mlfcVkoskInb4K0wMPXvmo/wI48SJ/I4Csf\n CvU9/ySFp/CE87M33ih5zeTt/5PwlPybSImygqGzjFwKBpwIc9Gj4XopUVxYEtw2BrK+\n cbdA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709313460; x=1709918260;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=3UtlnItxEhj0GYMDyQyD+uneqNt6DkIIu+AK6QFO2Nk=;\n b=B3m1Q4Jf6ElE2CkAPcVUKnDfiO2FlWhQp8x6cKQ9RQ0GWu2w1Zp3JIbrhrTaPnl0iT\n oWsLx8iUmtorGQ53TkKJaZTPAxa4VmYwphzvQU3DbEAeDZzll+V6fdC9mqvaoMO3d9c2\n jtpwIoTeY1qCUH6Bi7jAPfzNLY7twFkzQY/PVhE9wcm6QJPqcz2+AMimGmk3Y34Q5q3N\n qkRCOuPxFJiSQrkHSMPDwWi921/7zXeoch78LAFTQkEPid5kXSxBwxAfjpu1u+XqLGp4\n HhnQ1rGuyivnv5JrEeC9RbGZqu5LtoXzd9uQLEQyYvMaLmLqj7OZZPVD5X19L2IrmccC\n 1w3Q==",
        "X-Gm-Message-State": "AOJu0Yyffge9+Q5sHamGJe4oiv6xRNIfMFu6u0gZeL9Abq1TLUadNf7q\n Tz2Jk9lV8KC5WUFgx6zW8WyjebmFFOfJay3UTXlRmoVGytqfvveu/pAkwnRX26VtAbfU2RNwGd+\n cn15rNA==",
        "X-Google-Smtp-Source": "\n AGHT+IEY3mI22BsF/JA5a+SJDXZC6VaKlqFf3F0bdG9DXb1H0MAqL+spbgbH5N8VIIbXhRMvNPIeIQ==",
        "X-Received": "by 2002:a17:902:f7ce:b0:1db:37b1:b1a3 with SMTP id\n h14-20020a170902f7ce00b001db37b1b1a3mr2080236plw.17.1709313459743;\n Fri, 01 Mar 2024 09:17:39 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Rosen Xu <rosen.xu@intel.com>",
        "Subject": "[PATCH v2 29/71] net/ipn3ke: replace use of fixed size rte_memcpy",
        "Date": "Fri,  1 Mar 2024 09:15:25 -0800",
        "Message-ID": "<20240301171707.95242-30-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.43.0",
        "In-Reply-To": "<20240301171707.95242-1-stephen@networkplumber.org>",
        "References": "<20240229225936.483472-1-stephen@networkplumber.org>\n <20240301171707.95242-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ipn3ke/ipn3ke_flow.c        | 32 ++++++++++++-------------\n drivers/net/ipn3ke/ipn3ke_representor.c | 16 ++++++-------\n drivers/net/ipn3ke/ipn3ke_tm.c          |  6 ++---\n 3 files changed, 26 insertions(+), 28 deletions(-)",
    "diff": "diff --git a/drivers/net/ipn3ke/ipn3ke_flow.c b/drivers/net/ipn3ke/ipn3ke_flow.c\nindex d20a29b9a2d6..eeb0ec55d9a6 100644\n--- a/drivers/net/ipn3ke/ipn3ke_flow.c\n+++ b/drivers/net/ipn3ke/ipn3ke_flow.c\n@@ -100,15 +100,14 @@ ipn3ke_pattern_vxlan(const struct rte_flow_item patterns[],\n \t\tcase RTE_FLOW_ITEM_TYPE_ETH:\n \t\t\teth = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[0],\n-\t\t\t\t\teth->hdr.src_addr.addr_bytes,\n-\t\t\t\t\tRTE_ETHER_ADDR_LEN);\n+\t\t\tmemcpy(&parser->key[0], eth->hdr.src_addr.addr_bytes,\n+\t\t\t       RTE_ETHER_ADDR_LEN);\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ITEM_TYPE_VXLAN:\n \t\t\tvxlan = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[6], vxlan->hdr.vni, 3);\n+\t\t\tmemcpy(&parser->key[6], vxlan->hdr.vni, 3);\n \t\t\tbreak;\n \n \t\tdefault:\n@@ -164,9 +163,8 @@ ipn3ke_pattern_mac(const struct rte_flow_item patterns[],\n \t\tcase RTE_FLOW_ITEM_TYPE_ETH:\n \t\t\teth = item->spec;\n \n-\t\t\trte_memcpy(parser->key,\n-\t\t\t\t\teth->hdr.src_addr.addr_bytes,\n-\t\t\t\t\tRTE_ETHER_ADDR_LEN);\n+\t\t\tmemcpy(parser->key, eth->hdr.src_addr.addr_bytes,\n+\t\t\t       RTE_ETHER_ADDR_LEN);\n \t\t\tbreak;\n \n \t\tdefault:\n@@ -369,13 +367,13 @@ ipn3ke_pattern_ip_tcp(const struct rte_flow_item patterns[],\n \t\tcase RTE_FLOW_ITEM_TYPE_IPV4:\n \t\t\tipv4 = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);\n+\t\t\tmemcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ITEM_TYPE_TCP:\n \t\t\ttcp = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[4], &tcp->hdr.src_port, 2);\n+\t\t\tmemcpy(&parser->key[4], &tcp->hdr.src_port, 2);\n \t\t\tbreak;\n \n \t\tdefault:\n@@ -434,13 +432,13 @@ ipn3ke_pattern_ip_udp(const struct rte_flow_item patterns[],\n \t\tcase RTE_FLOW_ITEM_TYPE_IPV4:\n \t\t\tipv4 = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);\n+\t\t\tmemcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ITEM_TYPE_UDP:\n \t\t\tudp = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[4], &udp->hdr.src_port, 2);\n+\t\t\tmemcpy(&parser->key[4], &udp->hdr.src_port, 2);\n \t\t\tbreak;\n \n \t\tdefault:\n@@ -502,19 +500,19 @@ ipn3ke_pattern_ip_nvgre(const struct rte_flow_item patterns[],\n \t\tcase RTE_FLOW_ITEM_TYPE_IPV4:\n \t\t\tipv4 = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);\n+\t\t\tmemcpy(&parser->key[0], &ipv4->hdr.src_addr, 4);\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ITEM_TYPE_UDP:\n \t\t\tudp = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[4], &udp->hdr.src_port, 2);\n+\t\t\tmemcpy(&parser->key[4], &udp->hdr.src_port, 2);\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ITEM_TYPE_NVGRE:\n \t\t\tnvgre = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[6], nvgre->tni, 3);\n+\t\t\tmemcpy(&parser->key[6], nvgre->tni, 3);\n \t\t\tbreak;\n \n \t\tdefault:\n@@ -576,19 +574,19 @@ ipn3ke_pattern_vxlan_ip_udp(const struct rte_flow_item patterns[],\n \t\tcase RTE_FLOW_ITEM_TYPE_VXLAN:\n \t\t\tvxlan = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[0], vxlan->hdr.vni, 3);\n+\t\t\tmemcpy(&parser->key[0], vxlan->hdr.vni, 3);\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ITEM_TYPE_IPV4:\n \t\t\tipv4 = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[3], &ipv4->hdr.src_addr, 4);\n+\t\t\tmemcpy(&parser->key[3], &ipv4->hdr.src_addr, 4);\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ITEM_TYPE_UDP:\n \t\t\tudp = item->spec;\n \n-\t\t\trte_memcpy(&parser->key[7], &udp->hdr.src_port, 2);\n+\t\t\tmemcpy(&parser->key[7], &udp->hdr.src_port, 2);\n \t\t\tbreak;\n \n \t\tdefault:\ndiff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c\nindex 8145f1bb2a0e..99527d18793a 100644\n--- a/drivers/net/ipn3ke/ipn3ke_representor.c\n+++ b/drivers/net/ipn3ke/ipn3ke_representor.c\n@@ -137,17 +137,17 @@ ipn3ke_rpst_dev_start(struct rte_eth_dev *dev)\n \n \tif (hw->retimer.mac_type == IFPGA_RAWDEV_RETIMER_MAC_TYPE_10GE_XFI) {\n \t\t/* Set mac address */\n-\t\trte_memcpy(((char *)(&val)),\n-\t\t\t(char *)&dev->data->mac_addrs->addr_bytes[0],\n-\t\t\tsizeof(uint32_t));\n+\t\tmemcpy(((char *)(&val)),\n+\t\t       (char *)&dev->data->mac_addrs->addr_bytes[0],\n+\t\t       sizeof(uint32_t));\n \t\t(*hw->f_mac_write)(hw,\n \t\t\t\tval,\n \t\t\t\tIPN3KE_MAC_PRIMARY_MAC_ADDR0,\n \t\t\t\trpst->port_id,\n \t\t\t\t0);\n-\t\trte_memcpy(((char *)(&val)),\n-\t\t\t(char *)&dev->data->mac_addrs->addr_bytes[4],\n-\t\t\tsizeof(uint16_t));\n+\t\tmemcpy(((char *)(&val)),\n+\t\t       (char *)&dev->data->mac_addrs->addr_bytes[4],\n+\t\t       sizeof(uint16_t));\n \t\t(*hw->f_mac_write)(hw,\n \t\t\t\tval,\n \t\t\t\tIPN3KE_MAC_PRIMARY_MAC_ADDR1,\n@@ -2753,13 +2753,13 @@ ipn3ke_rpst_mac_addr_set(struct rte_eth_dev *ethdev,\n \t\trte_ether_addr_copy(&mac_addr[0], &rpst->mac_addr);\n \n \t\t/* Set mac address */\n-\t\trte_memcpy(((char *)(&val)), &mac_addr[0], sizeof(uint32_t));\n+\t\tmemcpy(((char *)(&val)), &mac_addr[0], sizeof(uint32_t));\n \t\t(*hw->f_mac_write)(hw,\n \t\t\t\tval,\n \t\t\t\tIPN3KE_MAC_PRIMARY_MAC_ADDR0,\n \t\t\t\trpst->port_id,\n \t\t\t\t0);\n-\t\trte_memcpy(((char *)(&val)), &mac_addr[4], sizeof(uint16_t));\n+\t\tmemcpy(((char *)(&val)), &mac_addr[4], sizeof(uint16_t));\n \t\t(*hw->f_mac_write)(hw,\n \t\t\t\tval,\n \t\t\t\tIPN3KE_MAC_PRIMARY_MAC_ADDR0,\ndiff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c\nindex 0260227900ae..b7097083d2d6 100644\n--- a/drivers/net/ipn3ke/ipn3ke_tm.c\n+++ b/drivers/net/ipn3ke/ipn3ke_tm.c\n@@ -814,7 +814,7 @@ ipn3ke_tm_shaper_profile_add(struct rte_eth_dev *dev,\n \t\t\t\trte_strerror(EINVAL));\n \t} else {\n \t\tsp->valid = 1;\n-\t\trte_memcpy(&sp->params, profile, sizeof(sp->params));\n+\t\tmemcpy(&sp->params, profile, sizeof(sp->params));\n \t}\n \n \ttm->h.n_shaper_profiles++;\n@@ -960,7 +960,7 @@ ipn3ke_tm_tdrop_profile_add(struct rte_eth_dev *dev,\n \t\t\tIPN3KE_TDROP_TH2_MASK);\n \ttp->th1 = th1;\n \ttp->th2 = th2;\n-\trte_memcpy(&tp->params, profile, sizeof(tp->params));\n+\tmemcpy(&tp->params, profile, sizeof(tp->params));\n \n \t/* Add to list */\n \ttm->h.n_tdrop_profiles++;\n@@ -1308,7 +1308,7 @@ ipn3ke_tm_node_add(struct rte_eth_dev *dev,\n \t\tn->tdrop_profile = ipn3ke_hw_tm_tdrop_profile_search(hw,\n \t\t\tparams->leaf.wred.wred_profile_id);\n \n-\trte_memcpy(&n->params, params, sizeof(n->params));\n+\tmemcpy(&n->params, params, sizeof(n->params));\n \n \treturn 0;\n }\n",
    "prefixes": [
        "v2",
        "29/71"
    ]
}