Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137641/?format=api
{ "id": 137641, "url": "http://patches.dpdk.org/api/patches/137641/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240229225936.483472-68-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240229225936.483472-68-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240229225936.483472-68-stephen@networkplumber.org", "date": "2024-02-29T22:58:54", "name": "[67/71] app/test-pmd: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4c53180d751bbfc8e76a0fd160a0b47c94ccb3ac", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240229225936.483472-68-stephen@networkplumber.org/mbox/", "series": [ { "id": 31314, "url": "http://patches.dpdk.org/api/series/31314/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31314", "date": "2024-02-29T22:57:48", "name": "replace use of fixed size rte_memcpy", "version": 1, "mbox": "http://patches.dpdk.org/series/31314/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137641/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137641/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7328543BAE;\n\tFri, 1 Mar 2024 00:08:35 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2E40F43389;\n\tFri, 1 Mar 2024 00:02:26 +0100 (CET)", "from mail-pj1-f47.google.com (mail-pj1-f47.google.com\n [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 50FA343330\n for <dev@dpdk.org>; Fri, 1 Mar 2024 00:00:59 +0100 (CET)", "by mail-pj1-f47.google.com with SMTP id\n 98e67ed59e1d1-29a7951c6faso1117129a91.1\n for <dev@dpdk.org>; Thu, 29 Feb 2024 15:00:59 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Feb 2024 15:00:58 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247658;\n x=1709852458; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hBjpL2B+GH6WMvX1UmW3MDbk0gtjo8OUJmzZdg4n6Y8=;\n b=Pyjzi1rUKKt3UI8I0CpBeHxWkypzzkoS5aXKDus13e4o61mPNDLIdQHT1I5m0pMQRO\n qkxDPJM7rqBx8A7evO4NJgKax59XdRRjK1iDgwunbAxLQogYS/AJJJPX6CUW4Lr1454o\n LcFCsOfVZ3pD9IHhVlx0YGBE3ghUAZOONnIs5Bxo9iBssLUgoB5MYgm6z5AoFJE/WbwX\n dld0E2cbechvvFE6L8mFrOM+dClrCgVyHxid1rX88MXlJdy20ui8EBEbXjpMZCkGWc8i\n UfcFuJKQRuewAKUfeUfVTRfbHl3ctAc2ctLivFngxv87Cxcg4Ri3BSQtRIA1Qvksz2W/\n sCVg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709247658; x=1709852458;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=hBjpL2B+GH6WMvX1UmW3MDbk0gtjo8OUJmzZdg4n6Y8=;\n b=htACYRJtDWMGbYOFi1kiC0feWPdOi/r9R8UuRaaYvKWfzZYrNc8INMocd9VFxEpwEw\n oZXgqi3wDOV7+yocnafsToHRGgGexyCvE4EifL6aL27jRivlfYPOydPiBQE7BoQQu/ME\n 3M0oa59WESzanrxf5K7zTRg6/EQTnOpOC/PEsYKBSigZAjcyWfkf0VuQAPTo1Bz8//uv\n UIhv+AuKs+sb/BmcrtcrWHy2dfdvqfB/s8INSkI10+kzeNyHX59U9eRfqL2bZfO8g/LS\n o5J6XnbRRPMkgpBBTfHxYK1+2xbf9e5UxRXkp1cb9xNurkDxFYcTnIrfdfyLey6NwwIf\n HlsQ==", "X-Gm-Message-State": "AOJu0Yyj+s0bnuVtD+EoagGuxplPNdTCMsE/GZ4MWRMbYBOGp9V7wWVi\n GlID0I51stAuLgTZesEjLqfNQqKvA4EiKmsD02TQ/nACZpVzbjyD7V94giagj7/ELCZh/TpwJdB\n +3TQ=", "X-Google-Smtp-Source": "\n AGHT+IHsAA11DWXyh36yU4o8m/KGH9gXFN5GK+rTz4E7o6MDCJjKxQgYncwJqKtnNF9bM/skX5dFXg==", "X-Received": "by 2002:a17:90a:8046:b0:29a:7efc:4720 with SMTP id\n e6-20020a17090a804600b0029a7efc4720mr25405pjw.31.1709247658488;\n Thu, 29 Feb 2024 15:00:58 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>, Ori Kam <orika@nvidia.com>", "Subject": "[PATCH 67/71] app/test-pmd: replace use of fixed size rte_memcpy", "Date": "Thu, 29 Feb 2024 14:58:54 -0800", "Message-ID": "<20240229225936.483472-68-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240229225936.483472-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test-pmd/cmdline.c | 48 ++++++++++++++++++-------------------\n app/test-pmd/cmdline_flow.c | 24 +++++++++----------\n app/test-pmd/config.c | 8 +++----\n 3 files changed, 40 insertions(+), 40 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 566057caa523..898fb69a2f4d 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -9529,7 +9529,7 @@ static void cmd_set_vxlan_parsed(void *parsed_result,\n \t\tvxlan_encap_conf.select_ipv4 = 0;\n \telse\n \t\treturn;\n-\trte_memcpy(vxlan_encap_conf.vni, &id.vni[1], 3);\n+\tmemcpy(vxlan_encap_conf.vni, &id.vni[1], 3);\n \tvxlan_encap_conf.udp_src = rte_cpu_to_be_16(res->udp_src);\n \tvxlan_encap_conf.udp_dst = rte_cpu_to_be_16(res->udp_dst);\n \tvxlan_encap_conf.ip_tos = res->tos;\n@@ -9543,10 +9543,10 @@ static void cmd_set_vxlan_parsed(void *parsed_result,\n \t}\n \tif (vxlan_encap_conf.select_vlan)\n \t\tvxlan_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci);\n-\trte_memcpy(vxlan_encap_conf.eth_src, res->eth_src.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n-\trte_memcpy(vxlan_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(vxlan_encap_conf.eth_src, res->eth_src.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(vxlan_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n }\n \n static cmdline_parse_inst_t cmd_set_vxlan = {\n@@ -9724,7 +9724,7 @@ static void cmd_set_nvgre_parsed(void *parsed_result,\n \t\tnvgre_encap_conf.select_ipv4 = 0;\n \telse\n \t\treturn;\n-\trte_memcpy(nvgre_encap_conf.tni, &id.tni[1], 3);\n+\tmemcpy(nvgre_encap_conf.tni, &id.tni[1], 3);\n \tif (nvgre_encap_conf.select_ipv4) {\n \t\tIPV4_ADDR_TO_UINT(res->ip_src, nvgre_encap_conf.ipv4_src);\n \t\tIPV4_ADDR_TO_UINT(res->ip_dst, nvgre_encap_conf.ipv4_dst);\n@@ -9734,10 +9734,10 @@ static void cmd_set_nvgre_parsed(void *parsed_result,\n \t}\n \tif (nvgre_encap_conf.select_vlan)\n \t\tnvgre_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci);\n-\trte_memcpy(nvgre_encap_conf.eth_src, res->eth_src.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n-\trte_memcpy(nvgre_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(nvgre_encap_conf.eth_src, res->eth_src.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(nvgre_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n }\n \n static cmdline_parse_inst_t cmd_set_nvgre = {\n@@ -9851,10 +9851,10 @@ static void cmd_set_l2_encap_parsed(void *parsed_result,\n \t\treturn;\n \tif (l2_encap_conf.select_vlan)\n \t\tl2_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci);\n-\trte_memcpy(l2_encap_conf.eth_src, res->eth_src.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n-\trte_memcpy(l2_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(l2_encap_conf.eth_src, res->eth_src.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(l2_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n }\n \n static cmdline_parse_inst_t cmd_set_l2_encap = {\n@@ -10033,7 +10033,7 @@ static void cmd_set_mplsogre_encap_parsed(void *parsed_result,\n \t\tmplsogre_encap_conf.select_ipv4 = 0;\n \telse\n \t\treturn;\n-\trte_memcpy(mplsogre_encap_conf.label, &id.label, 3);\n+\tmemcpy(mplsogre_encap_conf.label, &id.label, 3);\n \tif (mplsogre_encap_conf.select_ipv4) {\n \t\tIPV4_ADDR_TO_UINT(res->ip_src, mplsogre_encap_conf.ipv4_src);\n \t\tIPV4_ADDR_TO_UINT(res->ip_dst, mplsogre_encap_conf.ipv4_dst);\n@@ -10043,10 +10043,10 @@ static void cmd_set_mplsogre_encap_parsed(void *parsed_result,\n \t}\n \tif (mplsogre_encap_conf.select_vlan)\n \t\tmplsogre_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci);\n-\trte_memcpy(mplsogre_encap_conf.eth_src, res->eth_src.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n-\trte_memcpy(mplsogre_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(mplsogre_encap_conf.eth_src, res->eth_src.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(mplsogre_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n }\n \n static cmdline_parse_inst_t cmd_set_mplsogre_encap = {\n@@ -10269,7 +10269,7 @@ static void cmd_set_mplsoudp_encap_parsed(void *parsed_result,\n \t\tmplsoudp_encap_conf.select_ipv4 = 0;\n \telse\n \t\treturn;\n-\trte_memcpy(mplsoudp_encap_conf.label, &id.label, 3);\n+\tmemcpy(mplsoudp_encap_conf.label, &id.label, 3);\n \tmplsoudp_encap_conf.udp_src = rte_cpu_to_be_16(res->udp_src);\n \tmplsoudp_encap_conf.udp_dst = rte_cpu_to_be_16(res->udp_dst);\n \tif (mplsoudp_encap_conf.select_ipv4) {\n@@ -10281,10 +10281,10 @@ static void cmd_set_mplsoudp_encap_parsed(void *parsed_result,\n \t}\n \tif (mplsoudp_encap_conf.select_vlan)\n \t\tmplsoudp_encap_conf.vlan_tci = rte_cpu_to_be_16(res->tci);\n-\trte_memcpy(mplsoudp_encap_conf.eth_src, res->eth_src.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n-\trte_memcpy(mplsoudp_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n-\t\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(mplsoudp_encap_conf.eth_src, res->eth_src.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n+\tmemcpy(mplsoudp_encap_conf.eth_dst, res->eth_dst.addr_bytes,\n+\t RTE_ETHER_ADDR_LEN);\n }\n \n static cmdline_parse_inst_t cmd_set_mplsoudp_encap = {\ndiff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex b4389e51506b..17b73d2407c4 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -13732,7 +13732,7 @@ cmd_set_raw_parsed_sample(const struct buffer *in)\n \t\t\tfprintf(stderr, \"Error - Not supported action\\n\");\n \t\t\treturn;\n \t\t}\n-\t\trte_memcpy(data, action, sizeof(struct rte_flow_action));\n+\t\tmemcpy(data, action, sizeof(struct rte_flow_action));\n \t\tdata++;\n \t}\n }\n@@ -13893,8 +13893,8 @@ cmd_set_raw_parsed(const struct buffer *in)\n \n \t\t\t\t/* We have to add GTP header extra word. */\n \t\t\t\t*total_size += sizeof(ext_word);\n-\t\t\t\trte_memcpy(data_tail - (*total_size),\n-\t\t\t\t\t &ext_word, sizeof(ext_word));\n+\t\t\t\tmemcpy(data_tail - (*total_size), &ext_word,\n+\t\t\t\t sizeof(ext_word));\n \t\t\t}\n \t\t\tsize = sizeof(struct rte_gtp_hdr);\n \t\t\tbreak;\n@@ -13939,21 +13939,21 @@ cmd_set_raw_parsed(const struct buffer *in)\n \t\t\t\tif (opt->checksum_rsvd.checksum) {\n \t\t\t\t\t*total_size +=\n \t\t\t\t\t\tsizeof(opt->checksum_rsvd);\n-\t\t\t\t\trte_memcpy(data_tail - (*total_size),\n-\t\t\t\t\t\t &opt->checksum_rsvd,\n-\t\t\t\t\t\t sizeof(opt->checksum_rsvd));\n+\t\t\t\t\tmemcpy(data_tail - (*total_size),\n+\t\t\t\t\t &opt->checksum_rsvd,\n+\t\t\t\t\t sizeof(opt->checksum_rsvd));\n \t\t\t\t}\n \t\t\t\tif (opt->key.key) {\n \t\t\t\t\t*total_size += sizeof(opt->key.key);\n-\t\t\t\t\trte_memcpy(data_tail - (*total_size),\n-\t\t\t\t\t\t &opt->key.key,\n-\t\t\t\t\t\t sizeof(opt->key.key));\n+\t\t\t\t\tmemcpy(data_tail - (*total_size),\n+\t\t\t\t\t &opt->key.key,\n+\t\t\t\t\t sizeof(opt->key.key));\n \t\t\t\t}\n \t\t\t\tif (opt->sequence.sequence) {\n \t\t\t\t\t*total_size += sizeof(opt->sequence.sequence);\n-\t\t\t\t\trte_memcpy(data_tail - (*total_size),\n-\t\t\t\t\t\t &opt->sequence.sequence,\n-\t\t\t\t\t\t sizeof(opt->sequence.sequence));\n+\t\t\t\t\tmemcpy(data_tail - (*total_size),\n+\t\t\t\t\t &opt->sequence.sequence,\n+\t\t\t\t\t sizeof(opt->sequence.sequence));\n \t\t\t\t}\n \t\t\t}\n \t\t\tproto = 0x2F;\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 08d7d0e2f87c..2b81f3ef3d2d 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -2639,8 +2639,8 @@ port_flow_template_table_create(portid_t port_id, uint32_t id,\n \t}\n \tpt->nb_pattern_templates = nb_pattern_templates;\n \tpt->nb_actions_templates = nb_actions_templates;\n-\trte_memcpy(&pt->flow_attr, &table_attr->flow_attr,\n-\t\t sizeof(struct rte_flow_attr));\n+\tmemcpy(&pt->flow_attr, &table_attr->flow_attr,\n+\t sizeof(struct rte_flow_attr));\n \tprintf(\"Template table #%u created\\n\", pt->id);\n \treturn 0;\n }\n@@ -3261,8 +3261,8 @@ port_queue_action_handle_update(portid_t port_id,\n \t\tupdate = action->conf;\n \t\tbreak;\n \tcase RTE_FLOW_ACTION_TYPE_METER_MARK:\n-\t\trte_memcpy(&mtr_update.meter_mark, action->conf,\n-\t\t\tsizeof(struct rte_flow_action_meter_mark));\n+\t\tmemcpy(&mtr_update.meter_mark, action->conf,\n+\t\t sizeof(struct rte_flow_action_meter_mark));\n \t\tif (mtr_update.meter_mark.profile)\n \t\t\tmtr_update.profile_valid = 1;\n \t\tif (mtr_update.meter_mark.policy)\n", "prefixes": [ "67/71" ] }