Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137633/?format=api
{ "id": 137633, "url": "http://patches.dpdk.org/api/patches/137633/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240229225936.483472-60-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240229225936.483472-60-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240229225936.483472-60-stephen@networkplumber.org", "date": "2024-02-29T22:58:46", "name": "[59/71] net/cxgbe: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "450df64c011b70571fbe3432ba0809f10d736d4f", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240229225936.483472-60-stephen@networkplumber.org/mbox/", "series": [ { "id": 31314, "url": "http://patches.dpdk.org/api/series/31314/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31314", "date": "2024-02-29T22:57:48", "name": "replace use of fixed size rte_memcpy", "version": 1, "mbox": "http://patches.dpdk.org/series/31314/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137633/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137633/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A82B443BAE;\n\tFri, 1 Mar 2024 00:07:35 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C11A14343E;\n\tFri, 1 Mar 2024 00:02:00 +0100 (CET)", "from mail-pj1-f44.google.com (mail-pj1-f44.google.com\n [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 320A443254\n for <dev@dpdk.org>; Fri, 1 Mar 2024 00:00:51 +0100 (CET)", "by mail-pj1-f44.google.com with SMTP id\n 98e67ed59e1d1-299dba8fd24so1099520a91.2\n for <dev@dpdk.org>; Thu, 29 Feb 2024 15:00:51 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.49\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Feb 2024 15:00:49 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247650;\n x=1709852450; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Yn99g5KkjD+cfYA9aLT9M1FloYyDLJ99IsLitOZ/W7c=;\n b=X1E/9M0XwYWw5xtz9PgwjtfRFAeAlmcgeB/VYeDkMtPR/jGAuyMLXJF14HlKRzNg/f\n qXc0gfT8LInae8jUbSkjXZoWTR/N//hj+zXwveJCKk3NMkANs+7x1H/uj9c7chnj1DDH\n 2Y3Ewbh+PXv5Y3Qb4mhFTAZGK4mUCcFNjT3kd8D+Tq6rDqaHh9LzWz1gHOcLWJJ1p8/m\n OQPX1SZfMRrCXzYvpdkjgEITWax+O+RbU4JViG8QDQkKv4LMn6rMXyqLpzshhs64rrbO\n TNs9476JZaAMBkWPhFB4hjG5s55IEsY56n4dUP0qvaOu8PZhz7h4bFem5VlATOW0Lr/I\n Ljww==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1709247650; x=1709852450;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Yn99g5KkjD+cfYA9aLT9M1FloYyDLJ99IsLitOZ/W7c=;\n b=UJw9xS909HB6oDH2tCZgnOnzGG4QXb4U2F7EZUz9ehSu4zIYW6OTqN4aXX7euf4tRB\n viZfSdj5i4FXhv/eW9V9gctc9VGsFYAJNoTT0aq1ECcJf/qnKcv/mcFa95yz/O7lPjVE\n //WgLYPnIV0K5XgD9h8+AwCXLnv+EScKs0Z7zVr7yh0R+g3vsC5joPFDPndMGCn0jFp3\n hAJ5kweVf8wn/KFnfQmk6ADO9Ed4aea6HFDv4f+1V2h8o8X5egENndDrR6qEPrUq8SQV\n jenIFtgy1Lo6wr2FTuMbWBOR84LG34zNptLjO30HnVOfSOzfXyottGdzGQmS8khlcRdj\n zecw==", "X-Gm-Message-State": "AOJu0YwBiOYfx6qXhom/W5WPwejwyI8GD4tbrvY3QINegzyWpYbcisDd\n Bi79xPnNczluPDeZ8ypegNdCKCoVeCY0aTKxFloEo/GFmYHJIdStX0Zq4QSdZLbY2l3IshEWkQO\n m", "X-Google-Smtp-Source": "\n AGHT+IFEtoIer21yr2h4D06qUfHaMDaeAmhRxfm5PuLfWRZ+Gsb1QuLK3H3b6/M16OkPdmRgTKlszA==", "X-Received": "by 2002:a17:90a:8c9:b0:299:3f2a:4309 with SMTP id\n 9-20020a17090a08c900b002993f2a4309mr39205pjn.18.1709247650340;\n Thu, 29 Feb 2024 15:00:50 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "Subject": "[PATCH 59/71] net/cxgbe: replace use of fixed size rte_memcpy", "Date": "Thu, 29 Feb 2024 14:58:46 -0800", "Message-ID": "<20240229225936.483472-60-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240229225936.483472-1-stephen@networkplumber.org>", "References": "<20240229225936.483472-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/cxgbe/clip_tbl.c | 2 +-\n drivers/net/cxgbe/cxgbe_filter.c | 8 ++++----\n drivers/net/cxgbe/l2t.c | 4 ++--\n drivers/net/cxgbe/smt.c | 20 +++++++++-----------\n 4 files changed, 16 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/clip_tbl.c b/drivers/net/cxgbe/clip_tbl.c\nindex b709e26f6aa9..d30fa6425f28 100644\n--- a/drivers/net/cxgbe/clip_tbl.c\n+++ b/drivers/net/cxgbe/clip_tbl.c\n@@ -115,7 +115,7 @@ static struct clip_entry *t4_clip_alloc(struct rte_eth_dev *dev,\n \tif (ce) {\n \t\tt4_os_lock(&ce->lock);\n \t\tif (__atomic_load_n(&ce->refcnt, __ATOMIC_RELAXED) == 0) {\n-\t\t\trte_memcpy(ce->addr, lip, sizeof(ce->addr));\n+\t\t\tmemcpy(ce->addr, lip, sizeof(ce->addr));\n \t\t\tif (v6) {\n \t\t\t\tce->type = FILTER_TYPE_IPV6;\n \t\t\t\t__atomic_store_n(&ce->refcnt, 1,\ndiff --git a/drivers/net/cxgbe/cxgbe_filter.c b/drivers/net/cxgbe/cxgbe_filter.c\nindex 5a7efe7a733e..3d1d087ec215 100644\n--- a/drivers/net/cxgbe/cxgbe_filter.c\n+++ b/drivers/net/cxgbe/cxgbe_filter.c\n@@ -851,10 +851,10 @@ static int set_filter_wr(struct rte_eth_dev *dev, unsigned int fidx)\n \tfwr->ivlanm = cpu_to_be16(f->fs.mask.ivlan);\n \tfwr->ovlan = cpu_to_be16(f->fs.val.ovlan);\n \tfwr->ovlanm = cpu_to_be16(f->fs.mask.ovlan);\n-\trte_memcpy(fwr->lip, f->fs.val.lip, sizeof(fwr->lip));\n-\trte_memcpy(fwr->lipm, f->fs.mask.lip, sizeof(fwr->lipm));\n-\trte_memcpy(fwr->fip, f->fs.val.fip, sizeof(fwr->fip));\n-\trte_memcpy(fwr->fipm, f->fs.mask.fip, sizeof(fwr->fipm));\n+\tmemcpy(fwr->lip, f->fs.val.lip, sizeof(fwr->lip));\n+\tmemcpy(fwr->lipm, f->fs.mask.lip, sizeof(fwr->lipm));\n+\tmemcpy(fwr->fip, f->fs.val.fip, sizeof(fwr->fip));\n+\tmemcpy(fwr->fipm, f->fs.mask.fip, sizeof(fwr->fipm));\n \tfwr->lp = cpu_to_be16(f->fs.val.lport);\n \tfwr->lpm = cpu_to_be16(f->fs.mask.lport);\n \tfwr->fp = cpu_to_be16(f->fs.val.fport);\ndiff --git a/drivers/net/cxgbe/l2t.c b/drivers/net/cxgbe/l2t.c\nindex 21f4019ae626..7721c7953ec0 100644\n--- a/drivers/net/cxgbe/l2t.c\n+++ b/drivers/net/cxgbe/l2t.c\n@@ -82,7 +82,7 @@ static int write_l2e(struct rte_eth_dev *dev, struct l2t_entry *e, int sync,\n \t\t\t\t V_L2T_W_NOREPLY(!sync));\n \treq->l2t_idx = cpu_to_be16(l2t_idx);\n \treq->vlan = cpu_to_be16(e->vlan);\n-\trte_memcpy(req->dst_mac, e->dmac, RTE_ETHER_ADDR_LEN);\n+\tmemcpy(req->dst_mac, e->dmac, RTE_ETHER_ADDR_LEN);\n \n \tif (loopback)\n \t\tmemset(req->dst_mac, 0, RTE_ETHER_ADDR_LEN);\n@@ -155,7 +155,7 @@ static struct l2t_entry *t4_l2t_alloc_switching(struct rte_eth_dev *dev,\n \t\t\te->state = L2T_STATE_SWITCHING;\n \t\t\te->vlan = vlan;\n \t\t\te->lport = port;\n-\t\t\trte_memcpy(e->dmac, eth_addr, RTE_ETHER_ADDR_LEN);\n+\t\t\tmemcpy(e->dmac, eth_addr, RTE_ETHER_ADDR_LEN);\n \t\t\t__atomic_store_n(&e->refcnt, 1, __ATOMIC_RELAXED);\n \t\t\tret = write_l2e(dev, e, 0, !L2T_LPBK, !L2T_ARPMISS);\n \t\t\tif (ret < 0)\ndiff --git a/drivers/net/cxgbe/smt.c b/drivers/net/cxgbe/smt.c\nindex 4e14a73753de..a74b2e0794e6 100644\n--- a/drivers/net/cxgbe/smt.c\n+++ b/drivers/net/cxgbe/smt.c\n@@ -55,26 +55,24 @@ static int write_smt_entry(struct rte_eth_dev *dev, struct smt_entry *e)\n \t\t */\n \t\tif (e->idx & 1) {\n \t\t\treq->pfvf1 = 0x0;\n-\t\t\trte_memcpy(req->src_mac1, e->src_mac,\n-\t\t\t\t RTE_ETHER_ADDR_LEN);\n+\t\t\tmemcpy(req->src_mac1, e->src_mac, RTE_ETHER_ADDR_LEN);\n \n \t\t\t/* fill pfvf0/src_mac0 with entry\n \t\t\t * at prev index from smt-tab.\n \t\t\t */\n \t\t\treq->pfvf0 = 0x0;\n-\t\t\trte_memcpy(req->src_mac0, s->smtab[e->idx - 1].src_mac,\n-\t\t\t\t RTE_ETHER_ADDR_LEN);\n+\t\t\tmemcpy(req->src_mac0, s->smtab[e->idx - 1].src_mac,\n+\t\t\t RTE_ETHER_ADDR_LEN);\n \t\t} else {\n \t\t\treq->pfvf0 = 0x0;\n-\t\t\trte_memcpy(req->src_mac0, e->src_mac,\n-\t\t\t\t RTE_ETHER_ADDR_LEN);\n+\t\t\tmemcpy(req->src_mac0, e->src_mac, RTE_ETHER_ADDR_LEN);\n \n \t\t\t/* fill pfvf1/src_mac1 with entry\n \t\t\t * at next index from smt-tab\n \t\t\t */\n \t\t\treq->pfvf1 = 0x0;\n-\t\t\trte_memcpy(req->src_mac1, s->smtab[e->idx + 1].src_mac,\n-\t\t\t\t RTE_ETHER_ADDR_LEN);\n+\t\t\tmemcpy(req->src_mac1, s->smtab[e->idx + 1].src_mac,\n+\t\t\t RTE_ETHER_ADDR_LEN);\n \t\t}\n \t\trow = (e->hw_idx >> 1);\n \t} else {\n@@ -87,8 +85,8 @@ static int write_smt_entry(struct rte_eth_dev *dev, struct smt_entry *e)\n \n \t\t/* fill pfvf0/src_mac0 from smt-tab */\n \t\tt6req->pfvf0 = 0x0;\n-\t\trte_memcpy(t6req->src_mac0, s->smtab[e->idx].src_mac,\n-\t\t\t RTE_ETHER_ADDR_LEN);\n+\t\tmemcpy(t6req->src_mac0, s->smtab[e->idx].src_mac,\n+\t\t RTE_ETHER_ADDR_LEN);\n \t\trow = e->hw_idx;\n \t\treq = (struct cpl_smt_write_req *)t6req;\n \t}\n@@ -158,7 +156,7 @@ static struct smt_entry *t4_smt_alloc_switching(struct rte_eth_dev *dev,\n \t\tt4_os_lock(&e->lock);\n \t\tif (__atomic_load_n(&e->refcnt, __ATOMIC_RELAXED) == 0) {\n \t\t\te->pfvf = pfvf;\n-\t\t\trte_memcpy(e->src_mac, smac, RTE_ETHER_ADDR_LEN);\n+\t\t\tmemcpy(e->src_mac, smac, RTE_ETHER_ADDR_LEN);\n \t\t\tret = write_smt_entry(dev, e);\n \t\t\tif (ret) {\n \t\t\t\te->pfvf = 0;\n", "prefixes": [ "59/71" ] }