Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137549/?format=api
{ "id": 137549, "url": "http://patches.dpdk.org/api/patches/137549/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1709242325-17218-2-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1709242325-17218-2-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1709242325-17218-2-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-29T21:31:44", "name": "[v5,01/22] log: add a per line log helper with parameterized prefix", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0e484e2dfc6120fc8c2c51542248f7857b80790d", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1709242325-17218-2-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31312, "url": "http://patches.dpdk.org/api/series/31312/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31312", "date": "2024-02-29T21:31:45", "name": "stop using variadic argument pack extension", "version": 5, "mbox": "http://patches.dpdk.org/series/31312/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137549/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/137549/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9F45643B7D;\n\tThu, 29 Feb 2024 22:32:21 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4B2C742FC3;\n\tThu, 29 Feb 2024 22:32:12 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id DBF0142DCB\n for <dev@dpdk.org>; Thu, 29 Feb 2024 22:32:07 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id E402920B74C1; Thu, 29 Feb 2024 13:32:06 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E402920B74C1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709242326;\n bh=vfWVHvZpGeZfHng6IESzSNipXhhIlQdENbbKHGiqK7I=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=rKTRB8DMcxOcwOMMdqpYcw9JTkK0gvDPfoBo+tnUM+FwirfKWjdxO+hU3ByerLsOV\n zo5F1T7/ueSw17d7heFeV8Vf97EHfG6qYEfX6j/tWkxa25qzIR9hR0g8UTFRN+0FhD\n EDUp7q6EuuVD2xlg0RcHKFRgQmJauILp9kA8QmNo=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Anatoly Burakov <anatoly.burakov@intel.com>,\n Ashish Gupta <ashish.gupta@marvell.com>, Chenbo Xia <chenbox@nvidia.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Hunt <david.hunt@intel.com>, Fan Zhang <fanzhang.oss@gmail.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Srikanth Yalavarthi <syalavarthi@marvell.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Sunil Kumar Kori <skori@marvell.com>, bruce.richardson@intel.com,\n mb@smartsharesystems.com, thomas@monjalon.net,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 01/22] log: add a per line log helper with parameterized\n prefix", "Date": "Thu, 29 Feb 2024 13:31:44 -0800", "Message-Id": "<1709242325-17218-2-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1709242325-17218-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>\n <1709242325-17218-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Providing a custom prefix when logging is common for components. Lift\nISO C99 compliant helper macros from mlx5_common.h and provide\nRTE_LOG_LINE_PREFIX macro that can expand similar to RTE_LOG_LINE with\na custom prefix and argument list.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/log/rte_log.h | 97 +++++++++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 97 insertions(+)", "diff": "diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h\nindex fbc0df7..8f10e31 100644\n--- a/lib/log/rte_log.h\n+++ b/lib/log/rte_log.h\n@@ -367,18 +367,115 @@ int rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)\n #define RTE_LOG_CHECK_NO_NEWLINE(...)\n #endif\n \n+/**\n+ * Generates a log message with a single trailing newline.\n+ *\n+ * The RTE_LOG_LINE() is a helper that expands logging of a message\n+ * with RTE_LOG() appending a single newline to the formatted message.\n+ *\n+ * @param l\n+ * Log level. A value between EMERG (1) and DEBUG (8). The short name\n+ * is expanded by the macro, so it cannot be an integer value.\n+ * @param t\n+ * The log type, for example, EAL. The short name is expanded by the\n+ * macro, so it cannot be an integer value.\n+ * @param ...\n+ * The fmt string, as in printf(3), followed by the variable arguments\n+ * required by the format.\n+ */\n #define RTE_LOG_LINE(l, t, ...) do { \\\n \tRTE_LOG_CHECK_NO_NEWLINE(RTE_FMT_HEAD(__VA_ARGS__ ,)); \\\n \tRTE_LOG(l, t, RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__ ,) \"\\n\", \\\n \t\tRTE_FMT_TAIL(__VA_ARGS__ ,))); \\\n } while (0)\n \n+/**\n+ * Generates a log message for data path with a single trailing newline.\n+ *\n+ * Similar to RTE_LOG_LINE(), except that it is removed at compilation\n+ * time if the RTE_LOG_DP_LEVEL configuration option is lower than the\n+ * log level argument.\n+ *\n+ * The RTE_LOG_LINE() is a helper that expands logging of a message\n+ * with RTE_LOG_DP() appending a single newline to the formatted\n+ * message.\n+ *\n+ * @param l\n+ * Log level. A value between EMERG (1) and DEBUG (8). The short name\n+ * is expanded by the macro, so it cannot be an integer value.\n+ * @param t\n+ * The log type, for example, EAL. The short name is expanded by the\n+ * macro, so it cannot be an integer value.\n+ * @param ...\n+ * The fmt string, as in printf(3), followed by the variable arguments\n+ * required by the format.\n+ */\n #define RTE_LOG_DP_LINE(l, t, ...) do { \\\n \tRTE_LOG_CHECK_NO_NEWLINE(RTE_FMT_HEAD(__VA_ARGS__ ,)); \\\n \tRTE_LOG_DP(l, t, RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__ ,) \"\\n\", \\\n \t\tRTE_FMT_TAIL(__VA_ARGS__ ,))); \\\n } while (0)\n \n+#define RTE_LOG_COMMA ,\n+\n+/*\n+ * Generates a log message with a supplied prefix and arguments with a\n+ * single trailing newline.\n+ *\n+ * The RTE_LOG_LINE_PREFIX() is a helper that expands logging of a\n+ * message with RTE_LOG() prepending the supplied prefix and arguments\n+ * appending a single newline to the formatted message.\n+ *\n+ * @param l\n+ * Log level. A value between EMERG (1) and DEBUG (8). The short name\n+ * is expanded by the macro, so it cannot be an integer value.\n+ * @param t\n+ * The log type, for example, EAL. The short name is expanded by the\n+ * macro, so it cannot be an integer value.\n+ * @param prefix\n+ * The prefix format string.\n+ * @param args\n+ * The arguments for the prefix format string. If args contains\n+ * multiple arguments use RTE_LOG_COMMA to defer expansion.\n+ * @param ...\n+ * The fmt string, as in printf(3), followed by the variable arguments\n+ * required by the format.\n+ */\n+#define RTE_LOG_LINE_PREFIX(l, t, prefix, args, ...) do { \\\n+\tRTE_LOG_CHECK_NO_NEWLINE(RTE_FMT_HEAD(prefix __VA_ARGS__ ,)); \\\n+\tRTE_LOG(l, t, RTE_FMT(prefix RTE_FMT_HEAD(__VA_ARGS__ ,) \"\\n\", \\\n+\t args RTE_LOG_COMMA RTE_FMT_TAIL(__VA_ARGS__ ,))); \\\n+} while (0)\n+\n+/*\n+ * Generates a log message for the data path with a supplied prefix and\n+ * arguments with a single trailing newline.\n+ *\n+ * The RTE_LOG_DP_LINE_PREFIX() is a helper that expands logging of a\n+ * message with RTE_LOG_DP() prepending the supplied prefix and\n+ * arguments appending a single newline to the formatted message.\n+ *\n+ * @param l\n+ * Log level. A value between EMERG (1) and DEBUG (8). The short name\n+ * is expanded by the macro, so it cannot be an integer value.\n+ * @param t\n+ * The log type, for example, EAL. The short name is expanded by the\n+ * macro, so it cannot be an integer value.\n+ * @param prefix\n+ * The prefix format string.\n+ * @param args\n+ * The arguments for the prefix format string. If args contains\n+ * multiple arguments use RTE_LOG_COMMA to defer expansion.\n+ * @param ...\n+ * The fmt string, as in printf(3), followed by the variable arguments\n+ * required by the format.\n+ */\n+#define RTE_LOG_DP_LINE_PREFIX(l, t, prefix, args, ...) do { \\\n+\tRTE_LOG_CHECK_NO_NEWLINE(RTE_FMT_HEAD(prefix __VA_ARGS__ ,)); \\\n+\tRTE_LOG_DP(l, t, RTE_FMT(prefix RTE_FMT_HEAD(__VA_ARGS__ ,) \"\\n\", \\\n+\t args RTE_LOG_COMMA RTE_FMT_TAIL(__VA_ARGS__ ,))); \\\n+} while (0)\n+\n #define RTE_LOG_REGISTER_IMPL(type, name, level)\t\t\t \\\n int type;\t\t\t\t\t\t\t\t \\\n RTE_INIT(__##type)\t\t\t\t\t\t\t \\\n", "prefixes": [ "v5", "01/22" ] }