Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137539/?format=api
{ "id": 137539, "url": "http://patches.dpdk.org/api/patches/137539/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1709236433-15428-15-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1709236433-15428-15-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1709236433-15428-15-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-29T19:53:45", "name": "[v4,14/22] vhost: stop using variadic argument pack extension", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "130f77da90cb8ce347332971f01de0ce4aa6bc8c", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1709236433-15428-15-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31311, "url": "http://patches.dpdk.org/api/series/31311/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31311", "date": "2024-02-29T19:53:33", "name": "stop using variadic argument pack extension", "version": 4, "mbox": "http://patches.dpdk.org/series/31311/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137539/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137539/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6CAA243BAB;\n\tThu, 29 Feb 2024 20:55:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CC013432AA;\n\tThu, 29 Feb 2024 20:54:37 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id E2A7342FCB\n for <dev@dpdk.org>; Thu, 29 Feb 2024 20:53:56 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id B3C4E20B74CE; Thu, 29 Feb 2024 11:53:55 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com B3C4E20B74CE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709236435;\n bh=XHqoi0GfY8Sd/jDuISHknQIji+KZDSdoJ9ZN3ZdrxXw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=gDnDtIUUatn7fdX9LMLoW6OE7g+F2lxdHLOlcNyxcblleMXLMWCRXcvT1J3Q9YVnP\n iJ8Sb5+YL/kDNrRUihz8518gVXqcHxdUl+0UCpCH7ZJybrPTAhoTimMxSsKsT4tXKM\n bEfz9eyDFSlqYh59wQXjJz+dzYLXR5a7PZI1C8p4=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Anatoly Burakov <anatoly.burakov@intel.com>,\n Ashish Gupta <ashish.gupta@marvell.com>, Chenbo Xia <chenbox@nvidia.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Hunt <david.hunt@intel.com>, Fan Zhang <fanzhang.oss@gmail.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Srikanth Yalavarthi <syalavarthi@marvell.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Sunil Kumar Kori <skori@marvell.com>, bruce.richardson@intel.com,\n mb@smartsharesystems.com, thomas@monjalon.net,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 14/22] vhost: stop using variadic argument pack extension", "Date": "Thu, 29 Feb 2024 11:53:45 -0800", "Message-Id": "<1709236433-15428-15-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1709236433-15428-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>\n <1709236433-15428-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions\nwhich allow a prefix and arguments to be inserted into the log line\nwithout the need to use the ## args variadic argument pack extension.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/vhost/vhost.h | 8 ++++----\n lib/vhost/vhost_crypto.c | 21 +++++++++++----------\n 2 files changed, 15 insertions(+), 14 deletions(-)", "diff": "diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h\nindex f163ff7..08e4ab9 100644\n--- a/lib/vhost/vhost.h\n+++ b/lib/vhost/vhost.h\n@@ -679,11 +679,11 @@ void __vhost_log_write_iova(struct virtio_net *dev, struct vhost_virtqueue *vq,\n extern int vhost_data_log_level;\n #define RTE_LOGTYPE_VHOST_DATA vhost_data_log_level\n \n-#define VHOST_CONFIG_LOG(prefix, level, fmt, args...)\t\t\\\n-\tRTE_LOG_LINE(level, VHOST_CONFIG, \"(%s) \" fmt, prefix, ##args)\n+#define VHOST_CONFIG_LOG(prefix, level, ...) \\\n+\tRTE_LOG_LINE_PREFIX(level, VHOST_CONFIG, \"(%s) \", prefix, __VA_ARGS__)\n \n-#define VHOST_DATA_LOG(prefix, level, fmt, args...)\t\t\\\n-\tRTE_LOG_DP_LINE(level, VHOST_DATA, \"(%s) \" fmt, prefix, ##args)\n+#define VHOST_DATA_LOG(prefix, level, ...) \\\n+\tRTE_LOG_DP_LINE_PREFIX(level, VHOST_DATA, \"(%s) \", prefix, __VA_ARGS__)\n \n #ifdef RTE_LIBRTE_VHOST_DEBUG\n #define VHOST_MAX_PRINT_BUFF 6072\ndiff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c\nindex 3704fbb..3409cdf 100644\n--- a/lib/vhost/vhost_crypto.c\n+++ b/lib/vhost/vhost_crypto.c\n@@ -20,19 +20,20 @@\n RTE_LOG_REGISTER_SUFFIX(vhost_crypto_logtype, crypto, INFO);\n #define RTE_LOGTYPE_VHOST_CRYPTO\tvhost_crypto_logtype\n \n-#define VC_LOG_ERR(fmt, args...)\t\t\t\t\\\n-\tRTE_LOG_LINE(ERR, VHOST_CRYPTO, \"%s() line %u: \" fmt,\t\\\n-\t\t__func__, __LINE__, ## args)\n-#define VC_LOG_INFO(fmt, args...)\t\t\t\t\\\n-\tRTE_LOG_LINE(INFO, VHOST_CRYPTO, \"%s() line %u: \" fmt,\t\\\n-\t\t__func__, __LINE__, ## args)\n+#define VC_LOG_ERR(...)\t\\\n+\tRTE_LOG_LINE_PREFIX(ERR, VHOST_CRYPTO, \"%s() line %u: \", \\\n+\t\t__func__ RTE_LOG_COMMA __LINE__, __VA_ARGS__)\n+\n+#define VC_LOG_INFO(...) \\\n+\tRTE_LOG_LINE_PREFIX(INFO, VHOST_CRYPTO, \"%s() line %u: \", \\\n+\t\t__func__ RTE_LOG_COMMA __LINE__, __VA_ARGS__)\n \n #ifdef RTE_LIBRTE_VHOST_DEBUG\n-#define VC_LOG_DBG(fmt, args...)\t\t\t\t\\\n-\tRTE_LOG_LINE(DEBUG, VHOST_CRYPTO, \"%s() line %u: \" fmt,\t\\\n-\t\t__func__, __LINE__, ## args)\n+#define VC_LOG_DBG(...)\t\\\n+\tRTE_LOG_LINE_PREFIX(DEBUG, VHOST_CRYPTO, \"%s() line %u: \", \\\n+\t\t__func__ RTE_LOG_COMMA __LINE__, __VA_ARGS__)\n #else\n-#define VC_LOG_DBG(fmt, args...)\n+#define VC_LOG_DBG(fmt, ...)\n #endif\n \n #define VIRTIO_CRYPTO_FEATURES ((1ULL << VIRTIO_F_NOTIFY_ON_EMPTY) |\t\\\n", "prefixes": [ "v4", "14/22" ] }