Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137497/?format=api
{ "id": 137497, "url": "http://patches.dpdk.org/api/patches/137497/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/3b9ac4436f577f5203931e9f3ab31e8548709ba2.1709210551.git.gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<3b9ac4436f577f5203931e9f3ab31e8548709ba2.1709210551.git.gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3b9ac4436f577f5203931e9f3ab31e8548709ba2.1709210551.git.gmuthukrishn@marvell.com", "date": "2024-02-29T13:48:07", "name": "[v11,1/4] app/dma-perf: add skip support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c90bcd2bed82d95c7206c2730ab761447f6d03e6", "submitter": { "id": 2301, "url": "http://patches.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/3b9ac4436f577f5203931e9f3ab31e8548709ba2.1709210551.git.gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 31298, "url": "http://patches.dpdk.org/api/series/31298/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31298", "date": "2024-02-29T13:48:06", "name": "PCI Dev and SG copy support", "version": 11, "mbox": "http://patches.dpdk.org/series/31298/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137497/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/137497/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6C94B43C3B;\n\tThu, 29 Feb 2024 14:48:25 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 56A5142D2A;\n\tThu, 29 Feb 2024 14:48:25 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 9CDF44025C\n for <dev@dpdk.org>; Thu, 29 Feb 2024 14:48:23 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 41TBkMw1021316; Thu, 29 Feb 2024 05:48:23 -0800", "from dc6wp-exch02.marvell.com ([4.21.29.225])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3wjfay2xd6-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 29 Feb 2024 05:48:22 -0800 (PST)", "from DC6WP-EXCH02.marvell.com (10.76.176.209) by\n DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Thu, 29 Feb 2024 05:48:22 -0800", "from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com\n (10.76.176.209) with Microsoft SMTP Server id 15.2.1258.12 via Frontend\n Transport; Thu, 29 Feb 2024 05:48:22 -0800", "from BG-LT91401.marvell.com (unknown [10.193.66.108])\n by maili.marvell.com (Postfix) with ESMTP id 496393F724F;\n Thu, 29 Feb 2024 05:48:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=YZQzgJBh+scUnA9oKcyEszUsnWBk5sDY4XsqzdFVZy0=; b=FzM\n B2Y2QVH3G7EU3yhKit2NT4khU/hk5AObCpmZWCD1gZnnEXamUK7Ihz+W3+NyKr8B\n KcdZKrtKsYLfTJo8rbOaSa6nTXPBiYmGYf6jckBHu1gzDoG5Z9qz3h+TPkVOvt5N\n Xl0C01ZoN2AURpMlq5qno8U7GWLcw4XQKwnqp8v6pjZ2uQzUVbWtAiY960zsmhlD\n KoLpkGS8WKVfn+wQtVTs0Lvf826wiDziNpJO6lSdavnNF1yii+O9hRohewW3GRqC\n pE64p3kyc36Tl8fHEFar5o+psznA0RiTniX9cqh7rkCgb85oOOkvqu/KqnRlTyVp\n ahPGNecpNmNqEumJhwg==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<anoobj@marvell.com>, Cheng Jiang <honest.jiang@foxmail.com>, Kevin Laatz\n <kevin.laatz@intel.com>, Bruce Richardson <bruce.richardson@intel.com>,\n \"Pavan Nikhilesh\" <pbhagavatula@marvell.com>, Amit Prakash Shukla\n <amitprakashs@marvell.com>, Chengwen Feng <fengchengwen@huawei.com>, Jerin\n <jerinj@marvell.com>, Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "Subject": "[v11 1/4] app/dma-perf: add skip support", "Date": "Thu, 29 Feb 2024 19:18:07 +0530", "Message-ID": "\n <3b9ac4436f577f5203931e9f3ab31e8548709ba2.1709210551.git.gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<cover.1709210551.git.gmuthukrishn@marvell.com>", "References": "<cover.1709210551.git.gmuthukrishn@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "CCOQzxq0JvxiAl8ZrEdOmUrPR_LwyM7-", "X-Proofpoint-GUID": "CCOQzxq0JvxiAl8ZrEdOmUrPR_LwyM7-", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-02-29_02,2024-02-29_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support to skip running a dma-perf test-case.\n\nSigned-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>\nAcked-by: Anoob Joseph <anoobj@marvell.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\nv11:\n - config file formatting\n\n app/test-dma-perf/config.ini | 2 ++\n app/test-dma-perf/main.c | 48 ++++++++++++++++++++++--------------\n app/test-dma-perf/main.h | 1 +\n 3 files changed, 32 insertions(+), 19 deletions(-)", "diff": "diff --git a/app/test-dma-perf/config.ini b/app/test-dma-perf/config.ini\nindex b550f4b23f..bb0b1aa11a 100644\n--- a/app/test-dma-perf/config.ini\n+++ b/app/test-dma-perf/config.ini\n@@ -30,6 +30,8 @@\n ; If you have already set the \"-l\" and \"-a\" parameters using EAL,\n ; make sure that the value of \"lcore\" falls within their range of values.\n \n+; \"skip\" To skip a test-case set skip to 1.\n+\n ; To specify a configuration file, use the \"--config\" flag followed by the path to the file.\n \n ; To specify a result file, use the \"--result\" flag followed by the path to the file.\ndiff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c\nindex 544784df50..e9e40e72e7 100644\n--- a/app/test-dma-perf/main.c\n+++ b/app/test-dma-perf/main.c\n@@ -86,6 +86,19 @@ output_header(uint32_t case_id, struct test_configure *case_cfg)\n \toutput_csv(true);\n }\n \n+static int\n+open_output_csv(const char *rst_path_ptr)\n+{\n+\tfd = fopen(rst_path_ptr, \"a\");\n+\tif (!fd) {\n+\t\tprintf(\"Open output CSV file error.\\n\");\n+\t\treturn 1;\n+\t}\n+\toutput_csv(true);\n+\tfclose(fd);\n+\treturn 0;\n+}\n+\n static void\n run_test_case(struct test_configure *case_cfg)\n {\n@@ -322,6 +335,7 @@ load_configs(const char *path)\n \tconst char *case_type;\n \tconst char *lcore_dma;\n \tconst char *mem_size_str, *buf_size_str, *ring_size_str, *kick_batch_str;\n+\tconst char *skip;\n \tint args_nr, nb_vp;\n \tbool is_dma;\n \n@@ -341,6 +355,13 @@ load_configs(const char *path)\n \tfor (i = 0; i < nb_sections; i++) {\n \t\tsnprintf(section_name, CFG_NAME_LEN, \"case%d\", i + 1);\n \t\ttest_case = &test_cases[i];\n+\n+\t\tskip = rte_cfgfile_get_entry(cfgfile, section_name, \"skip\");\n+\t\tif (skip && (atoi(skip) == 1)) {\n+\t\t\ttest_case->is_skip = true;\n+\t\t\tcontinue;\n+\t\t}\n+\n \t\tcase_type = rte_cfgfile_get_entry(cfgfile, section_name, \"type\");\n \t\tif (case_type == NULL) {\n \t\t\tprintf(\"Error: No case type in case %d, the test will be finished here.\\n\",\n@@ -525,31 +546,20 @@ main(int argc, char *argv[])\n \n \tprintf(\"Running cases...\\n\");\n \tfor (i = 0; i < case_nb; i++) {\n-\t\tif (!test_cases[i].is_valid) {\n-\t\t\tprintf(\"Invalid test case %d.\\n\\n\", i + 1);\n-\t\t\tsnprintf(output_str[0], MAX_OUTPUT_STR_LEN, \"Invalid case %d\\n\", i + 1);\n-\n-\t\t\tfd = fopen(rst_path_ptr, \"a\");\n-\t\t\tif (!fd) {\n-\t\t\t\tprintf(\"Open output CSV file error.\\n\");\n+\t\tif (test_cases[i].is_skip) {\n+\t\t\tprintf(\"Test case %d configured to be skipped.\\n\\n\", i + 1);\n+\t\t\tsnprintf(output_str[0], MAX_OUTPUT_STR_LEN, \"Skip the test-case %d\\n\",\n+\t\t\t\t i + 1);\n+\t\t\tif (open_output_csv(rst_path_ptr))\n \t\t\t\treturn 0;\n-\t\t\t}\n-\t\t\toutput_csv(true);\n-\t\t\tfclose(fd);\n \t\t\tcontinue;\n \t\t}\n \n-\t\tif (test_cases[i].test_type == TEST_TYPE_NONE) {\n-\t\t\tprintf(\"No valid test type in test case %d.\\n\\n\", i + 1);\n+\t\tif (!test_cases[i].is_valid) {\n+\t\t\tprintf(\"Invalid test case %d.\\n\\n\", i + 1);\n \t\t\tsnprintf(output_str[0], MAX_OUTPUT_STR_LEN, \"Invalid case %d\\n\", i + 1);\n-\n-\t\t\tfd = fopen(rst_path_ptr, \"a\");\n-\t\t\tif (!fd) {\n-\t\t\t\tprintf(\"Open output CSV file error.\\n\");\n+\t\t\tif (open_output_csv(rst_path_ptr))\n \t\t\t\treturn 0;\n-\t\t\t}\n-\t\t\toutput_csv(true);\n-\t\t\tfclose(fd);\n \t\t\tcontinue;\n \t\t}\n \ndiff --git a/app/test-dma-perf/main.h b/app/test-dma-perf/main.h\nindex 62085e6e8f..32670151af 100644\n--- a/app/test-dma-perf/main.h\n+++ b/app/test-dma-perf/main.h\n@@ -40,6 +40,7 @@ struct lcore_dma_map_t {\n \n struct test_configure {\n \tbool is_valid;\n+\tbool is_skip;\n \tuint8_t test_type;\n \tconst char *test_type_str;\n \tuint16_t src_numa_node;\n", "prefixes": [ "v11", "1/4" ] }