Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13749/?format=api
{ "id": 13749, "url": "http://patches.dpdk.org/api/patches/13749/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1465961172-28253-1-git-send-email-mukawa@igel.co.jp/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1465961172-28253-1-git-send-email-mukawa@igel.co.jp>", "list_archive_url": "https://inbox.dpdk.org/dev/1465961172-28253-1-git-send-email-mukawa@igel.co.jp", "date": "2016-06-15T03:26:12", "name": "[dpdk-dev] eal: Fix resource leak of pci_uio_map_secondary()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "577ac12ac6ae1bfa74e3ad015164480e5394bc07", "submitter": { "id": 64, "url": "http://patches.dpdk.org/api/people/64/?format=api", "name": "Tetsuya Mukawa", "email": "mukawa@igel.co.jp" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1465961172-28253-1-git-send-email-mukawa@igel.co.jp/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/13749/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/13749/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 72AB4ADBA;\n\tWed, 15 Jun 2016 05:26:46 +0200 (CEST)", "from mail-pa0-f51.google.com (mail-pa0-f51.google.com\n\t[209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 5BC59ADB7\n\tfor <dev@dpdk.org>; Wed, 15 Jun 2016 05:26:44 +0200 (CEST)", "by mail-pa0-f51.google.com with SMTP id b5so2880134pas.3\n\tfor <dev@dpdk.org>; Tue, 14 Jun 2016 20:26:44 -0700 (PDT)", "from localhost.localdomain (napt.igel.co.jp. [219.106.231.132])\n\tby smtp.gmail.com with ESMTPSA id\n\tvb6sm48593270pac.16.2016.06.14.20.26.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 14 Jun 2016 20:26:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=igel-co-jp.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=MnplZxOl1TYJ/+zlv+PWUFoj8j8wvSA+JFNzVNcR3SI=;\n\tb=YGZF8zYnDlHxdx4KGoT1lsIBcpk+vOZ1wvx8O//7FcKEbFH4AWq2H6/yHXxYJ6a0Nv\n\tLmzE+FxTIC/eX4NTKqmIePvLghH8BuyuZyQsv3G6yqglC5Yqxh0CdJi8jgWzfvdTQh1w\n\t5wckpwIeyn4LsByMunrwqAiBh0TCV5h9JrvX0/MI0PVUE1wkU/Ue8A2GLHkCqXOCv6eX\n\taFNq5FOxQFt4ptjEP1zFYVen6Si1z5uZmSFOBHRRDHdQvyPvXI4xRJXPRxni5v6B58Ha\n\thTfs96dN49s0UU8OpEfo5c2ixaBqaNzr9h89NUYZGj4v2Ee+BabwQr672N2lfalMUtRs\n\t9glA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=MnplZxOl1TYJ/+zlv+PWUFoj8j8wvSA+JFNzVNcR3SI=;\n\tb=LbvWt+BsSBAfWPX/bEUyGHAhmgOwr4Y1WY9DKEgiF86NnnUh2KnhX5Q+St4pi93Z7D\n\tqOplGccXPWoAY4OixJmqOD0FA3qjd6LDbrBTW2chcxW+s0LTqxKQ3qynIBFkhZc0Lj1W\n\tTjBo7GNfEZPyvEtm+4glscz/GVrO1OKsB+ZB2QkNE2X2B1B4ow53he1QblFlHmeIbi+q\n\tnTmZVQNDQqVQm3HjpMKc5d7iiEdhvdx5WJ2o8+2m2wAzpZkGzxBAlij+6AQ2DdFhMnAQ\n\tS348YfgGBZd7GMJxHwxIpJfZwEnz3lMJArYRA15A5x4g/EydCl6nQe3fPVq1JC7NVtWS\n\tbagg==", "X-Gm-Message-State": "ALyK8tINrDArPAcKl+sffQ2XODTqakq9YvcoZDwuQ/gORoVgzw2hlIoABgrMo5jlIakjDQ==", "X-Received": "by 10.67.22.129 with SMTP id hs1mr1229874pad.105.1465961203569; \n\tTue, 14 Jun 2016 20:26:43 -0700 (PDT)", "From": "Tetsuya Mukawa <mukawa@igel.co.jp>", "To": "dev@dpdk.org", "Cc": "david.marchand@6wind.com, john.mcnamara@intel.com,\n\tmichalx.k.jastrzebski@intel.com, Tetsuya Mukawa <mukawa@igel.co.jp>", "Date": "Wed, 15 Jun 2016 12:26:12 +0900", "Message-Id": "<1465961172-28253-1-git-send-email-mukawa@igel.co.jp>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] eal: Fix resource leak of pci_uio_map_secondary()", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If pci_map_resource() succeeds but mapped address is different from an\naddress primary process mapped, this should be error.\nThen the address secondary process mapped should be freed.\n\nSigned-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>\n---\n lib/librte_eal/common/eal_common_pci_uio.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_pci_uio.c b/lib/librte_eal/common/eal_common_pci_uio.c\nindex f062e81..e718643 100644\n--- a/lib/librte_eal/common/eal_common_pci_uio.c\n+++ b/lib/librte_eal/common/eal_common_pci_uio.c\n@@ -85,6 +85,9 @@ pci_uio_map_secondary(struct rte_pci_device *dev)\n \t\t\t\t\t\"Cannot mmap device resource file %s to address: %p\\n\",\n \t\t\t\t\tuio_res->maps[i].path,\n \t\t\t\t\tuio_res->maps[i].addr);\n+\t\t\t\tif (mapaddr != MAP_FAILED)\n+\t\t\t\t\tpci_unmap_resource(mapaddr,\n+\t\t\t\t\t\t(size_t)uio_res->maps[i].size);\n \t\t\t\treturn -1;\n \t\t\t}\n \t\t}\n", "prefixes": [ "dpdk-dev" ] }