Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137419/?format=api
{ "id": 137419, "url": "http://patches.dpdk.org/api/patches/137419/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240228100928.524277-7-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240228100928.524277-7-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240228100928.524277-7-mattias.ronnblom@ericsson.com", "date": "2024-02-28T10:09:28", "name": "[RFC,v5,6/6] eal: keep per-lcore power intrinsics state in lcore variable", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2a9fe8518598d19a869fe396268c3f3b74a849c6", "submitter": { "id": 1077, "url": "http://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240228100928.524277-7-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31270, "url": "http://patches.dpdk.org/api/series/31270/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31270", "date": "2024-02-28T10:09:22", "name": "Lcore variables", "version": 5, "mbox": "http://patches.dpdk.org/series/31270/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137419/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/137419/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B87043C1F;\n\tWed, 28 Feb 2024 11:17:59 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 84BA942D7B;\n\tWed, 28 Feb 2024 11:17:39 +0100 (CET)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur04on2085.outbound.protection.outlook.com [40.107.8.85])\n by mails.dpdk.org (Postfix) with ESMTP id 59B6340DDB\n for <dev@dpdk.org>; Wed, 28 Feb 2024 11:17:25 +0100 (CET)", "from DB6PR0301CA0084.eurprd03.prod.outlook.com (2603:10a6:6:30::31)\n by AS8PR07MB7301.eurprd07.prod.outlook.com (2603:10a6:20b:23b::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Wed, 28 Feb\n 2024 10:17:23 +0000", "from DU6PEPF0000B61F.eurprd02.prod.outlook.com\n (2603:10a6:6:30:cafe::10) by DB6PR0301CA0084.outlook.office365.com\n (2603:10a6:6:30::31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.27 via Frontend\n Transport; Wed, 28 Feb 2024 10:17:23 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n DU6PEPF0000B61F.mail.protection.outlook.com (10.167.8.134) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7292.25 via Frontend Transport; Wed, 28 Feb 2024 10:17:23 +0000", "from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.68) with Microsoft SMTP Server\n id 15.2.1258.12; Wed, 28 Feb 2024 11:17:23 +0100", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id\n 1A220380061; Wed, 28 Feb 2024 11:17:23 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=i/Zw9oycLmYtpe/VHYtep8+wB03v+U1OEwBqTsNs8/Sqneln8JeaZBvS7Ejo9VxhsGFgdiD3h5MUZaJNEesL3n43APcr4HVPE1x0fagloga4oV+85xWjjBjxrvkWiRQLgH9Ho+Nucajrmd8rBA+Q0ZkNtMW7ao3880Ej6M7pFmCiDz278wyr/+epZOsALpyuLsXDJJFF9nhXzP5qTYj/CGUjyy0oanGufApcMYYh5wQF0YnQ8GdcKTEq7SHmEp9u2B2V+rJZ2T2TZYPZbunoka/jgSDfJldG6+XTqNR0ehi5nvIpz1kRNgXE1RcP1+UXJJ3VhTZ1arjoKmcjPPJGKw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=S/nn+/osSbRePXDyt2OXgfcTtQ3j8AB1+LstbQNCjHY=;\n b=aIVLcgEIdfgsznnyrdZeMATPw4y22jlLrvAjK+5V2khjKJI/f+my77Iiu7c/NsBwn2rJP6QJWxA+6Y5aQNfzghAeMyodTfADqbaPlAKz9wmkr5y2raGFvjd96A569LVQARhx9WgpxOIU2I6vZWzfKptD635J8rcnsKwgGBPh0fdci5oj9aYD8fwRlna56/cUoaYuqHXN6RziSpZBBqiqUBBIcG7NDL5x2PYNZNZmauOuay4eIj56LFltFx/riLx0mexAGuLmnYMvTNy6f20ypeXoAHy3LTi/Q+GYmfX/BnqpaIOhLwaV5yR8MTYHhVcF0DN3wcf5mOuMtw/jpS97rQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=S/nn+/osSbRePXDyt2OXgfcTtQ3j8AB1+LstbQNCjHY=;\n b=QSnj+u13FULOpRtKZ11GPGrc4bqVw+Rl9A1g9rz5yavxBS2DAAZZhudRDamMP8U6UXpklBYLd66kxYLCcWI9hXhZhY4Xqpdhi2u5W6ocJJ2p2kXYK/uerYlGu6oQS/yJAqJk0IGKopW7n/zC9TMi8B8d7shIf3c4/HA0yLlqgeBB9XAciyL78sNEXi4znsPPuXzQRHGBMjIKTgWDbUDZrFsbZlv0XDPs6cVxnem+wiXuJjEXbSKxci0lX+1iBfJLW0o7zg1IiSQfzP0tDkzbXi2ZK5u0Z52GG6QWtl8NSi2cbTNuZAnVVml8V4ZP31ziPqg+diyeh/7BmWXAdlUP8Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Mattias_R=C3=B6nn?=\n\t=?utf-8?q?blom?= <mattias.ronnblom@ericsson.com>", "Subject": "[RFC v5 6/6] eal: keep per-lcore power intrinsics state in lcore\n variable", "Date": "Wed, 28 Feb 2024 11:09:28 +0100", "Message-ID": "<20240228100928.524277-7-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240228100928.524277-1-mattias.ronnblom@ericsson.com>", "References": "<20240225150330.517225-2-mattias.ronnblom@ericsson.com>\n <20240228100928.524277-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DU6PEPF0000B61F:EE_|AS8PR07MB7301:EE_", "X-MS-Office365-Filtering-Correlation-Id": "daca5272-a3f4-4607-5d16-08dc384674ca", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n GxklDXeZYGawrSnDY7TKUToc0PefaNiqUi5fSJ/7NeFbpWtsQTUyAF2QR7a2Jz31UH0De22iYgi5UnnNBl4tyNYSUOq28ua/1s231PXQ+KCvZzDfUdS+e2C2s9dT26KTyga/BwkinvPqYvXCVs4KmrB/oy1z5lI28MgzpTQnBsB0ShrNzZPkVDVKjpxacyqpjpHW/8vY0hxT5n6m8tvapIBl1eij9A9F5B9zGcnz6vO5O4NAidgZ2FL1Uyy+KE+GFndEKACXNO486T55dMqu75ASPlQd6+JuXwz0oyslbs+WQPxiB9+wDndpauKsFL2+SSz7VSPnRIkECb7lEPqiw/gnI7BV6wzOJf6lILiOItGUsNjQ1G2Kr+E4FYVinInclHNTxcCYXegPzChZ5cHHmtqZx2Tyajl61HhGrmhvw3KbzbQw1YkvXQYDwpx6Ct9Y3ek3b5JHPq2dZ8f5ycQnqI/Jfzwk8UWxZnARTA+uARKVHkFNTcYx/9n8o1smXPFkT/odN6gLqfIVufjdI9MjCePISpVbRhaz4yevQr8Kto2lPr5Fw0NjCmYTGXU+d79lia3cgcae0HtfhNm5sJvd9t05jMgz67DJkaCKKEYI0qfAh9AV+rBGtOfzfa9oyM7OeptWVUxinetoheRAh6IlUrxiuMKeejuy8Cgv0c4B6ptJnGNKHJ1xDLE+Q6kN/c/7z0A1HTko5Olw54FqglMzOrDh6XJcEBFpkqQOl78hTVrjdhJM1AjQiG0ci92ME47b", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(82310400014)(36860700004); DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Feb 2024 10:17:23.7115 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n daca5272-a3f4-4607-5d16-08dc384674ca", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DU6PEPF0000B61F.eurprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AS8PR07MB7301", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Keep per-lcore power intrinsics state in a lcore variable to reduce\ncache working set size and avoid any CPU next-line-prefetching causing\nfalse sharing.\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/eal/x86/rte_power_intrinsics.c | 17 +++++++++++------\n 1 file changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/eal/x86/rte_power_intrinsics.c b/lib/eal/x86/rte_power_intrinsics.c\nindex 532a2e646b..23d1761f0a 100644\n--- a/lib/eal/x86/rte_power_intrinsics.c\n+++ b/lib/eal/x86/rte_power_intrinsics.c\n@@ -4,6 +4,7 @@\n \n #include <rte_common.h>\n #include <rte_lcore.h>\n+#include <rte_lcore_var.h>\n #include <rte_rtm.h>\n #include <rte_spinlock.h>\n \n@@ -12,10 +13,14 @@\n /*\n * Per-lcore structure holding current status of C0.2 sleeps.\n */\n-static struct power_wait_status {\n+struct power_wait_status {\n \trte_spinlock_t lock;\n \tvolatile void *monitor_addr; /**< NULL if not currently sleeping */\n-} __rte_cache_aligned wait_status[RTE_MAX_LCORE];\n+};\n+\n+RTE_LCORE_VAR_HANDLE(struct power_wait_status, wait_status);\n+\n+RTE_LCORE_VAR_INIT(wait_status);\n \n /*\n * This function uses UMONITOR/UMWAIT instructions and will enter C0.2 state.\n@@ -170,7 +175,7 @@ rte_power_monitor(const struct rte_power_monitor_cond *pmc,\n \tif (pmc->fn == NULL)\n \t\treturn -EINVAL;\n \n-\ts = &wait_status[lcore_id];\n+\ts = RTE_LCORE_VAR_LCORE_VALUE(lcore_id, wait_status);\n \n \t/* update sleep address */\n \trte_spinlock_lock(&s->lock);\n@@ -262,7 +267,7 @@ rte_power_monitor_wakeup(const unsigned int lcore_id)\n \tif (lcore_id >= RTE_MAX_LCORE)\n \t\treturn -EINVAL;\n \n-\ts = &wait_status[lcore_id];\n+\ts = RTE_LCORE_VAR_LCORE_VALUE(lcore_id, wait_status);\n \n \t/*\n \t * There is a race condition between sleep, wakeup and locking, but we\n@@ -301,8 +306,8 @@ int\n rte_power_monitor_multi(const struct rte_power_monitor_cond pmc[],\n \t\tconst uint32_t num, const uint64_t tsc_timestamp)\n {\n-\tconst unsigned int lcore_id = rte_lcore_id();\n-\tstruct power_wait_status *s = &wait_status[lcore_id];\n+\tstruct power_wait_status *s = RTE_LCORE_VAR_VALUE(wait_status);\n+\n \tuint32_t i, rc;\n \n \t/* check if supported */\n", "prefixes": [ "RFC", "v5", "6/6" ] }