Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137316/?format=api
{ "id": 137316, "url": "http://patches.dpdk.org/api/patches/137316/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1709012499-12813-18-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1709012499-12813-18-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1709012499-12813-18-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-27T05:41:33", "name": "[v6,17/23] net/thunderx: use mbuf descriptor accessors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8877651cc7807c6aaf1d90b78666b07d397954b5", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1709012499-12813-18-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31232, "url": "http://patches.dpdk.org/api/series/31232/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31232", "date": "2024-02-27T05:41:17", "name": "stop and remove RTE_MARKER typedefs", "version": 6, "mbox": "http://patches.dpdk.org/series/31232/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137316/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137316/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 99E2143C03;\n\tTue, 27 Feb 2024 06:44:20 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 626ED42F0C;\n\tTue, 27 Feb 2024 06:42:40 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 4D9CE42E4E\n for <dev@dpdk.org>; Tue, 27 Feb 2024 06:41:43 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id A889020B74D1; Mon, 26 Feb 2024 21:41:41 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com A889020B74D1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1709012501;\n bh=43J41FUN8U97ef9HAWZHV2AQLsuA5wCPXesxdNMpgMw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=MzcKe6Y+nlKB6DGivU47xnSAnhoVx8XY7i3tUPdxBXiTKF7bb19gIWNMuWQArnnEd\n Tm59SPRtr+JOTu0M79ALvEao26Vq3S3TRsQwEbJzb3pb/5jgJBXbwOkb3oznqsmZlz\n I8ajPzLPuviEVDv9jE5xopx4Smx+7PnNGRbDf2UM=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v6 17/23] net/thunderx: use mbuf descriptor accessors", "Date": "Mon, 26 Feb 2024 21:41:33 -0800", "Message-Id": "<1709012499-12813-18-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use\nnew rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors\nthat provide a compatible type pointer without using the marker fields.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/thunderx/nicvf_ethdev.c | 4 +---\n drivers/net/thunderx/nicvf_rxtx.h | 4 ++--\n 2 files changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c\nindex 609d95d..722751c 100644\n--- a/drivers/net/thunderx/nicvf_ethdev.c\n+++ b/drivers/net/thunderx/nicvf_ethdev.c\n@@ -1306,7 +1306,6 @@ enum nicvf_link_speed {\n static inline void\n nicvf_rxq_mbuf_setup(struct nicvf_rxq *rxq)\n {\n-\tuintptr_t p;\n \tstruct rte_mbuf mb_def;\n \tstruct nicvf *nic = rxq->nic;\n \n@@ -1328,8 +1327,7 @@ enum nicvf_link_speed {\n \n \t/* Prevent compiler reordering: rearm_data covers previous fields */\n \trte_compiler_barrier();\n-\tp = (uintptr_t)&mb_def.rearm_data;\n-\trxq->mbuf_initializer.value = *(uint64_t *)p;\n+\trxq->mbuf_initializer.value = *rte_mbuf_rearm_data(&mb_def);\n }\n \n static int\ndiff --git a/drivers/net/thunderx/nicvf_rxtx.h b/drivers/net/thunderx/nicvf_rxtx.h\nindex 4b83e33..7c07cde 100644\n--- a/drivers/net/thunderx/nicvf_rxtx.h\n+++ b/drivers/net/thunderx/nicvf_rxtx.h\n@@ -66,7 +66,7 @@ static inline uint16_t __attribute__((const))\n #else\n \tinit.value += apad;\n #endif\n-\t*(uint64_t *)(&pkt->rearm_data) = init.value;\n+\t*rte_mbuf_rearm_data(pkt) = init.value;\n }\n \n static inline void\n@@ -80,7 +80,7 @@ static inline uint16_t __attribute__((const))\n \tinit.value += apad;\n #endif\n \tinit.fields.nb_segs = nb_segs;\n-\t*(uint64_t *)(&pkt->rearm_data) = init.value;\n+\t*rte_mbuf_rearm_data(pkt) = init.value;\n }\n \n uint32_t nicvf_dev_rx_queue_count(void *rx_queue);\n", "prefixes": [ "v6", "17/23" ] }