Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137294/?format=api
{ "id": 137294, "url": "http://patches.dpdk.org/api/patches/137294/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240226205143.66702-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240226205143.66702-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240226205143.66702-3-stephen@networkplumber.org", "date": "2024-02-26T20:49:49", "name": "[2/2] app/pdump: handle SIGTERM and SIGHUP", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b92b022844729322f6fb5cb2191b8118bfb8d190", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240226205143.66702-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 31231, "url": "http://patches.dpdk.org/api/series/31231/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31231", "date": "2024-02-26T20:49:47", "name": "dumpcap,pdump handle cleanup signals", "version": 1, "mbox": "http://patches.dpdk.org/series/31231/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137294/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137294/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA56643BF6;\n\tMon, 26 Feb 2024 21:52:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7478242E76;\n\tMon, 26 Feb 2024 21:51:57 +0100 (CET)", "from mail-pl1-f173.google.com (mail-pl1-f173.google.com\n [209.85.214.173])\n by mails.dpdk.org (Postfix) with ESMTP id 4B3E142E21\n for <dev@dpdk.org>; Mon, 26 Feb 2024 21:51:55 +0100 (CET)", "by mail-pl1-f173.google.com with SMTP id\n d9443c01a7336-1dc99a75be6so12549515ad.3\n for <dev@dpdk.org>; Mon, 26 Feb 2024 12:51:55 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n 5-20020a170902ee4500b001db3efca159sm109615plo.132.2024.02.26.12.51.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 26 Feb 2024 12:51:54 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1708980714;\n x=1709585514; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ONDJULtuKfy2cHyiXCr/Q6vfY1X6kDA4bHcvcA37dr4=;\n b=dIEHT7iTRuPjwaJrflUTXd4DUie/qGV2qwN5TOPwfka2c32fEAKPm2uHyCkP3wPa9k\n jVvZ9I8GRg8Sd3q9rixB3GCeaSpNhfzR2VZwhPrsuAcd9px03uQyKqyY8sLEyqI68vw3\n 2u18RnLgTAm+sBa9BFuLbQc4BP+ElpVYDRfqSX4vJ1ERf3WI6V8tuTNgLdUKZl2lKw9k\n qsAYX7aspIiCj68AgER1/eYSgPpiVLF3wP/pCnPRWMW+Iv0uHiwBLEqHucANlptEvNII\n k88frkaTQvMg3jmbeXSZuh2R/RY6nXdXjHNF30IVRAt0Myhnp8TcCmunASSH9WIPRvYK\n c4rQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1708980714; x=1709585514;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=ONDJULtuKfy2cHyiXCr/Q6vfY1X6kDA4bHcvcA37dr4=;\n b=ccKOKuQJcTXej03OpkkX3slXxnQZG0CNmLd5NnOFi/6eimX124cf40yD9MVzkPxbpg\n +qHMcdFVbkx2D8zFfVqzC7sDSQUVYcJRDcqqj5GJOAg9IGb7apHxs4VXorPHTXHm70MV\n J7+wC3JcVI5dQ/C6e7QGwCIdXdDIS6LjXGi+0EcvR2fx8xlnH4qj73JZ4epUoaCaBMD+\n fA1U4wtB7MSibLr1e17QTtTT8ME6UDccy6J8ZWwx4OcbAS6JoAIRM4hZScPI/AU6u0MJ\n LUzvsV5+l1G2AIqbUXQeKaPsbDVd/snU6nv331KFHLZM7U2uk6nqN2i1HJsX6qEVfom9\n 3NnQ==", "X-Gm-Message-State": "AOJu0YxEO61X0XuCIQTULmm1vO5udsGCJfaHxuaeDatklGOKSBMHbC78\n 05UhmH1hql3bEqtoxGvAhkchL3K4IL4svSpc/SSM2zkDVLIyIHbzJpc1IolVARnRuBOicQn23VQ\n I", "X-Google-Smtp-Source": "\n AGHT+IEv1UGnXpWA3MNX0r7hQZ/S+A8fXRUpNRHI9ccX2RsvpbVxgr7gH8lU9MPpA8vpdaY+IXB56A==", "X-Received": "by 2002:a17:902:a383:b0:1d9:8f6e:86e8 with SMTP id\n x3-20020a170902a38300b001d98f6e86e8mr7337685pla.69.1708980714445;\n Mon, 26 Feb 2024 12:51:54 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH 2/2] app/pdump: handle SIGTERM and SIGHUP", "Date": "Mon, 26 Feb 2024 12:49:49 -0800", "Message-ID": "<20240226205143.66702-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240226205143.66702-1-stephen@networkplumber.org>", "References": "<20240226205143.66702-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Like dumpcap, the pdump process should cleanup if process\nterminates due to being killed or hangup.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/pdump/main.c | 21 +++++++++++++++------\n 1 file changed, 15 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/pdump/main.c b/app/pdump/main.c\nindex a9205e130bb1..3592f8a865ad 100644\n--- a/app/pdump/main.c\n+++ b/app/pdump/main.c\n@@ -571,11 +571,9 @@ disable_primary_monitor(void)\n }\n \n static void\n-signal_handler(int sig_num)\n+signal_handler(int sig_num __rte_unused)\n {\n-\tif (sig_num == SIGINT) {\n-\t\tquit_signal = 1;\n-\t}\n+\tquit_signal = 1;\n }\n \n static inline int\n@@ -975,6 +973,11 @@ enable_primary_monitor(void)\n int\n main(int argc, char **argv)\n {\n+\tstruct sigaction action = {\n+\t\t.sa_flags = SA_RESTART,\n+\t\t.sa_handler = signal_handler,\n+\t};\n+\tstruct sigaction origaction;\n \tint diag;\n \tint ret;\n \tint i;\n@@ -983,8 +986,14 @@ main(int argc, char **argv)\n \tchar mp_flag[] = \"--proc-type=secondary\";\n \tchar *argp[argc + 2];\n \n-\t/* catch ctrl-c so we can print on exit */\n-\tsignal(SIGINT, signal_handler);\n+\t/* catch ctrl-c so we can cleanup on exit */\n+\tsigemptyset(&action.sa_mask);\n+\tsigaction(SIGTERM, &action, NULL);\n+\tsigaction(SIGINT, &action, NULL);\n+\tsigaction(SIGPIPE, &action, NULL);\n+\tsigaction(SIGHUP, NULL, &origaction);\n+\tif (origaction.sa_handler == SIG_DFL)\n+\t\tsigaction(SIGHUP, &action, NULL);\n \n \targp[0] = argv[0];\n \targp[1] = n_flag;\n", "prefixes": [ "2/2" ] }