Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 137274,
    "url": "http://patches.dpdk.org/api/patches/137274/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-35-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1708971946-18231-35-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1708971946-18231-35-git-send-email-roretzla@linux.microsoft.com",
    "date": "2024-02-26T18:25:41",
    "name": "[v6,34/39] cryptodev: use C11 alignas",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7c9c89e93b3d1f12de61135743d05b778d97c9e9",
    "submitter": {
        "id": 2077,
        "url": "http://patches.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-35-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 31229,
            "url": "http://patches.dpdk.org/api/series/31229/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31229",
            "date": "2024-02-26T18:25:09",
            "name": "use C11 alignas",
            "version": 6,
            "mbox": "http://patches.dpdk.org/series/31229/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/137274/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/137274/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 412D343BF3;\n\tMon, 26 Feb 2024 19:30:06 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 48E7042F41;\n\tMon, 26 Feb 2024 19:26:46 +0100 (CET)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 93EB742E35\n for <dev@dpdk.org>; Mon, 26 Feb 2024 19:25:51 +0100 (CET)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id 4B02820B74E2; Mon, 26 Feb 2024 10:25:49 -0800 (PST)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 4B02820B74E2",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708971950;\n bh=EsE7U+BRtldLbNPCh/nwa5DQpAyaS0PCT6DPLwjx2RA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=TnQCQelNCE4wEGEFwsx3RwIifyDAieqv+BitxwVa5y4ZxB+HBh//H6maaS8HNu6f9\n eXVqQp7IliUdZHCFaR8F6VxfoEH5V0H/bgvKtOpWFexSgXyr1mp7qM2KNW/Ud6zcSK\n 78I/sUgJPlc3nPtSQaRIqHEC9IMC/9MwjkKq9z0Q=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH v6 34/39] cryptodev: use C11 alignas",
        "Date": "Mon, 26 Feb 2024 10:25:41 -0800",
        "Message-Id": "<1708971946-18231-35-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n  be between {struct,union} and tag.\n\n  The placement between {struct,union} and the tag allows the desired\n  alignment to be imparted on the type regardless of the toolchain being\n  used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/cryptodev/cryptodev_pmd.h      | 8 ++++----\n lib/cryptodev/rte_cryptodev_core.h | 4 ++--\n 2 files changed, 6 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h\nindex 0732b35..6229ad4 100644\n--- a/lib/cryptodev/cryptodev_pmd.h\n+++ b/lib/cryptodev/cryptodev_pmd.h\n@@ -61,7 +61,7 @@ struct rte_cryptodev_pmd_init_params {\n  * This structure is safe to place in shared memory to be common among\n  * different processes in a multi-process configuration.\n  */\n-struct rte_cryptodev_data {\n+struct __rte_cache_aligned rte_cryptodev_data {\n \t/** Device ID for this instance */\n \tuint8_t dev_id;\n \t/** Socket ID where memory is allocated */\n@@ -82,10 +82,10 @@ struct rte_cryptodev_data {\n \n \t/** PMD-specific private data */\n \tvoid *dev_private;\n-} __rte_cache_aligned;\n+};\n \n /** @internal The data structure associated with each crypto device. */\n-struct rte_cryptodev {\n+struct __rte_cache_aligned rte_cryptodev {\n \t/** Pointer to PMD dequeue function. */\n \tdequeue_pkt_burst_t dequeue_burst;\n \t/** Pointer to PMD enqueue function. */\n@@ -117,7 +117,7 @@ struct rte_cryptodev {\n \tstruct rte_cryptodev_cb_rcu *enq_cbs;\n \t/** User application callback for post dequeue processing */\n \tstruct rte_cryptodev_cb_rcu *deq_cbs;\n-} __rte_cache_aligned;\n+};\n \n /** Global structure used for maintaining state of allocated crypto devices */\n struct rte_cryptodev_global {\ndiff --git a/lib/cryptodev/rte_cryptodev_core.h b/lib/cryptodev/rte_cryptodev_core.h\nindex 5de89d0..8d7e58d 100644\n--- a/lib/cryptodev/rte_cryptodev_core.h\n+++ b/lib/cryptodev/rte_cryptodev_core.h\n@@ -40,7 +40,7 @@ struct rte_cryptodev_qpdata {\n \tstruct rte_cryptodev_cb_rcu *deq_cb;\n };\n \n-struct rte_crypto_fp_ops {\n+struct __rte_cache_aligned rte_crypto_fp_ops {\n \t/** PMD enqueue burst function. */\n \tenqueue_pkt_burst_t enqueue_burst;\n \t/** PMD dequeue burst function. */\n@@ -49,7 +49,7 @@ struct rte_crypto_fp_ops {\n \tstruct rte_cryptodev_qpdata qp;\n \t/** Reserved for future ops. */\n \tuintptr_t reserved[3];\n-} __rte_cache_aligned;\n+};\n \n extern struct rte_crypto_fp_ops rte_crypto_fp_ops[RTE_CRYPTO_MAX_DEVS];\n \n",
    "prefixes": [
        "v6",
        "34/39"
    ]
}