Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137268/?format=api
{ "id": 137268, "url": "http://patches.dpdk.org/api/patches/137268/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-29-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708971946-18231-29-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708971946-18231-29-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-26T18:25:35", "name": "[v6,28/39] member: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "057f31a3573428712284b773d39840999c5f661a", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-29-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31229, "url": "http://patches.dpdk.org/api/series/31229/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31229", "date": "2024-02-26T18:25:09", "name": "use C11 alignas", "version": 6, "mbox": "http://patches.dpdk.org/series/31229/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137268/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137268/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9CAB843BF3;\n\tMon, 26 Feb 2024 19:29:34 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E479542F11;\n\tMon, 26 Feb 2024 19:26:39 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 4006542E6C\n for <dev@dpdk.org>; Mon, 26 Feb 2024 19:25:51 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id E6C1A20B74DC; Mon, 26 Feb 2024 10:25:49 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E6C1A20B74DC", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708971949;\n bh=jHv5VkLrIdhmYloPOTQRERRhs99NsyL7txAwIgiwUq8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=jl2kcYs47Kt8oNhWpv7311cSFlfy1pkMMPITb5/m1MTd8q7Ow2gsy224RVd+KWbzS\n 7C39FKKx1NVYKBVOuVzvZL8rKPF6pwxg3MScQBP1Nlzyg9d2TAuOq1OAROyzDq2UgI\n xqf4lOSrgyz8Fgxrk+jZML3BCh1yitpta6nTi4jg=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v6 28/39] member: use C11 alignas", "Date": "Mon, 26 Feb 2024 10:25:35 -0800", "Message-Id": "<1708971946-18231-29-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/member/rte_member.h | 8 ++++----\n lib/member/rte_member_ht.h | 4 ++--\n lib/member/rte_member_sketch.c | 4 ++--\n 3 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/member/rte_member.h b/lib/member/rte_member.h\nindex 3278bbb..aec192e 100644\n--- a/lib/member/rte_member.h\n+++ b/lib/member/rte_member.h\n@@ -139,7 +139,7 @@ typedef void (*sketch_delete_fn_t)(const struct rte_member_setsum *ss,\n \t\t\t\t const void *key);\n \n /** @internal setsummary structure. */\n-struct rte_member_setsum {\n+struct __rte_cache_aligned rte_member_setsum {\n \tenum rte_member_setsum_type type; /* Type of the set summary. */\n \tuint32_t key_len;\t\t/* Length of key. */\n \tuint32_t prim_hash_seed;\t/* Primary hash function seed. */\n@@ -185,14 +185,14 @@ struct rte_member_setsum {\n #ifdef RTE_ARCH_X86\n \tbool use_avx512;\n #endif\n-} __rte_cache_aligned;\n+};\n \n /**\n * Parameters used when create the set summary table. Currently user can\n * specify two types of setsummary: HT based and vBF. For HT based, user can\n * specify cache or non-cache mode. Here is a table to describe some differences\n */\n-struct rte_member_parameters {\n+struct __rte_cache_aligned rte_member_parameters {\n \tconst char *name;\t\t\t/**< Name of the hash. */\n \n \t/**\n@@ -326,7 +326,7 @@ struct rte_member_parameters {\n \tuint32_t extra_flag;\n \n \tint socket_id;\t\t\t/**< NUMA Socket ID for memory. */\n-} __rte_cache_aligned;\n+};\n \n /**\n * Find an existing set-summary and return a pointer to it.\ndiff --git a/lib/member/rte_member_ht.h b/lib/member/rte_member_ht.h\nindex 9e24ccd..c9673e3 100644\n--- a/lib/member/rte_member_ht.h\n+++ b/lib/member/rte_member_ht.h\n@@ -15,10 +15,10 @@\n typedef uint16_t member_sig_t;\t\t\t/* signature size is 16 bit */\n \n /* The bucket struct for ht setsum */\n-struct member_ht_bucket {\n+struct __rte_cache_aligned member_ht_bucket {\n \tmember_sig_t sigs[RTE_MEMBER_BUCKET_ENTRIES];\t/* 2-byte signature */\n \tmember_set_t sets[RTE_MEMBER_BUCKET_ENTRIES];\t/* 2-byte set */\n-} __rte_cache_aligned;\n+};\n \n int\n rte_member_create_ht(struct rte_member_setsum *ss,\ndiff --git a/lib/member/rte_member_sketch.c b/lib/member/rte_member_sketch.c\nindex e006e83..15af678 100644\n--- a/lib/member/rte_member_sketch.c\n+++ b/lib/member/rte_member_sketch.c\n@@ -23,7 +23,7 @@\n #include \"rte_member_sketch_avx512.h\"\n #endif /* CC_AVX512_SUPPORT */\n \n-struct sketch_runtime {\n+struct __rte_cache_aligned sketch_runtime {\n \tuint64_t pkt_cnt;\n \tuint32_t until_next;\n \tint converged;\n@@ -31,7 +31,7 @@ struct sketch_runtime {\n \tstruct node *report_array;\n \tvoid *key_slots;\n \tstruct rte_ring *free_key_slots;\n-} __rte_cache_aligned;\n+};\n \n /*\n * Geometric sampling to calculate how many packets needs to be\n", "prefixes": [ "v6", "28/39" ] }