Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137260/?format=api
http://patches.dpdk.org/api/patches/137260/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-30-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708971946-18231-30-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708971946-18231-30-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-26T18:25:36", "name": "[v6,29/39] lpm: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c8f73737605e37114187704a3b85fb2b454e221b", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-30-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31229, "url": "http://patches.dpdk.org/api/series/31229/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31229", "date": "2024-02-26T18:25:09", "name": "use C11 alignas", "version": 6, "mbox": "http://patches.dpdk.org/series/31229/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137260/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137260/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8C48443B7E;\n\tMon, 26 Feb 2024 19:28:41 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E2DEA42EEB;\n\tMon, 26 Feb 2024 19:26:30 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 0318E42E28\n for <dev@dpdk.org>; Mon, 26 Feb 2024 19:25:51 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 010A820B74DD; Mon, 26 Feb 2024 10:25:49 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 010A820B74DD", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708971950;\n bh=vwOsZ6LuePygY3eSg5nNeZMaaqrqDyIqhamwBfyqqUo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=pYNHnLns6SyhwKhNJ5UU5sDBXEfSTYP0hxbkjszaatPWp4JkVRNGIL3bVFPJKWdI8\n a9me7atQ6utt5Mfu7zd+/5YlGSe+aqonx+y9mFBspEb4uYeaeiWnAeYv2QX4AA3lI2\n UIzP7He0Z2mlCeOJF37IE23hFrNoCICr4wV0hN2Y=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v6 29/39] lpm: use C11 alignas", "Date": "Mon, 26 Feb 2024 10:25:36 -0800", "Message-Id": "<1708971946-18231-30-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/lpm/rte_lpm.h | 5 +++--\n lib/lpm/rte_lpm6.c | 8 ++++----\n 2 files changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/lpm/rte_lpm.h b/lib/lpm/rte_lpm.h\nindex f57977b..f311fd9 100644\n--- a/lib/lpm/rte_lpm.h\n+++ b/lib/lpm/rte_lpm.h\n@@ -11,6 +11,7 @@\n * RTE Longest Prefix Match (LPM)\n */\n \n+#include <stdalign.h>\n #include <errno.h>\n #include <stdint.h>\n \n@@ -118,8 +119,8 @@ struct rte_lpm_config {\n /** @internal LPM structure. */\n struct rte_lpm {\n \t/* LPM Tables. */\n-\tstruct rte_lpm_tbl_entry tbl24[RTE_LPM_TBL24_NUM_ENTRIES]\n-\t\t\t__rte_cache_aligned; /**< LPM tbl24 table. */\n+\talignas(RTE_CACHE_LINE_SIZE) struct rte_lpm_tbl_entry tbl24[RTE_LPM_TBL24_NUM_ENTRIES];\n+\t\t\t/**< LPM tbl24 table. */\n \tstruct rte_lpm_tbl_entry *tbl8; /**< LPM tbl8 table. */\n };\n \ndiff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c\nindex 271bc48..ed5970c 100644\n--- a/lib/lpm/rte_lpm6.c\n+++ b/lib/lpm/rte_lpm6.c\n@@ -98,16 +98,16 @@ struct rte_lpm6 {\n \n \t/* LPM Tables. */\n \tstruct rte_hash *rules_tbl; /**< LPM rules. */\n-\tstruct rte_lpm6_tbl_entry tbl24[RTE_LPM6_TBL24_NUM_ENTRIES]\n-\t\t\t__rte_cache_aligned; /**< LPM tbl24 table. */\n+\talignas(RTE_CACHE_LINE_SIZE) struct rte_lpm6_tbl_entry tbl24[RTE_LPM6_TBL24_NUM_ENTRIES];\n+\t\t\t/**< LPM tbl24 table. */\n \n \tuint32_t *tbl8_pool; /**< pool of indexes of free tbl8s */\n \tuint32_t tbl8_pool_pos; /**< current position in the tbl8 pool */\n \n \tstruct rte_lpm_tbl8_hdr *tbl8_hdrs; /* array of tbl8 headers */\n \n-\tstruct rte_lpm6_tbl_entry tbl8[0]\n-\t\t\t__rte_cache_aligned; /**< LPM tbl8 table. */\n+\talignas(RTE_CACHE_LINE_SIZE) struct rte_lpm6_tbl_entry tbl8[0];\n+\t\t\t/**< LPM tbl8 table. */\n };\n \n /*\n", "prefixes": [ "v6", "29/39" ] }{ "id": 137260, "url": "