Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137256/?format=api
{ "id": 137256, "url": "http://patches.dpdk.org/api/patches/137256/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-22-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708971946-18231-22-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708971946-18231-22-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-26T18:25:28", "name": "[v6,21/39] power: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "69786bd379a5c174ca279eff44462a48b710554c", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-22-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31229, "url": "http://patches.dpdk.org/api/series/31229/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31229", "date": "2024-02-26T18:25:09", "name": "use C11 alignas", "version": 6, "mbox": "http://patches.dpdk.org/series/31229/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137256/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137256/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 059FD43B7E;\n\tMon, 26 Feb 2024 19:28:15 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2B7EE42ED8;\n\tMon, 26 Feb 2024 19:26:26 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 984F142E57\n for <dev@dpdk.org>; Mon, 26 Feb 2024 19:25:50 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 7EA1820B74D5; Mon, 26 Feb 2024 10:25:48 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 7EA1820B74D5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708971949;\n bh=bQFHXqeoycDtocIPhUh5S8gHrS91WUGnxJOVh9jMKro=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=FgImXjneO1E6s/0t1oypsruaz/x7kZNJPk0/zElX+WH58PG7oSQEZ6DckLEenl0Xd\n Y8y347qSmQnEzRX5QseI+bO26bxhk/g+dz054j19vhj+dRsYkk3HW3Z51NmgYx0uOS\n 4KzfYoKpH+R5xWfi4fLCKjAVn5HVb38CcOaCFivU=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v6 21/39] power: use C11 alignas", "Date": "Mon, 26 Feb 2024 10:25:28 -0800", "Message-Id": "<1708971946-18231-22-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/power/power_acpi_cpufreq.c | 4 ++--\n lib/power/power_amd_pstate_cpufreq.c | 4 ++--\n lib/power/power_cppc_cpufreq.c | 4 ++--\n lib/power/power_intel_uncore.c | 4 ++--\n lib/power/power_pstate_cpufreq.c | 4 ++--\n lib/power/rte_power_pmd_mgmt.c | 4 ++--\n 6 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c\nindex f8d978d..81996e1 100644\n--- a/lib/power/power_acpi_cpufreq.c\n+++ b/lib/power/power_acpi_cpufreq.c\n@@ -41,7 +41,7 @@ enum power_state {\n /**\n * Power info per lcore.\n */\n-struct acpi_power_info {\n+struct __rte_cache_aligned acpi_power_info {\n \tunsigned int lcore_id; /**< Logical core id */\n \tuint32_t freqs[RTE_MAX_LCORE_FREQS]; /**< Frequency array */\n \tuint32_t nb_freqs; /**< number of available freqs */\n@@ -51,7 +51,7 @@ struct acpi_power_info {\n \tRTE_ATOMIC(uint32_t) state; /**< Power in use state */\n \tuint16_t turbo_available; /**< Turbo Boost available */\n \tuint16_t turbo_enable; /**< Turbo Boost enable/disable */\n-} __rte_cache_aligned;\n+};\n \n static struct acpi_power_info lcore_power_info[RTE_MAX_LCORE];\n \ndiff --git a/lib/power/power_amd_pstate_cpufreq.c b/lib/power/power_amd_pstate_cpufreq.c\nindex 028f844..090a0d9 100644\n--- a/lib/power/power_amd_pstate_cpufreq.c\n+++ b/lib/power/power_amd_pstate_cpufreq.c\n@@ -45,7 +45,7 @@ enum power_state {\n /**\n * Power info per lcore.\n */\n-struct amd_pstate_power_info {\n+struct __rte_cache_aligned amd_pstate_power_info {\n \tuint32_t lcore_id; /**< Logical core id */\n \tRTE_ATOMIC(uint32_t) state; /**< Power in use state */\n \tFILE *f; /**< FD of scaling_setspeed */\n@@ -58,7 +58,7 @@ struct amd_pstate_power_info {\n \tuint16_t turbo_enable; /**< Turbo Boost enable/disable */\n \tuint32_t nb_freqs; /**< number of available freqs */\n \tuint32_t freqs[RTE_MAX_LCORE_FREQS]; /**< Frequency array */\n-} __rte_cache_aligned;\n+};\n \n static struct amd_pstate_power_info lcore_power_info[RTE_MAX_LCORE];\n \ndiff --git a/lib/power/power_cppc_cpufreq.c b/lib/power/power_cppc_cpufreq.c\nindex 3ddf39b..32aaacb 100644\n--- a/lib/power/power_cppc_cpufreq.c\n+++ b/lib/power/power_cppc_cpufreq.c\n@@ -49,7 +49,7 @@ enum power_state {\n /**\n * Power info per lcore.\n */\n-struct cppc_power_info {\n+struct __rte_cache_aligned cppc_power_info {\n \tunsigned int lcore_id; /**< Logical core id */\n \tRTE_ATOMIC(uint32_t) state; /**< Power in use state */\n \tFILE *f; /**< FD of scaling_setspeed */\n@@ -61,7 +61,7 @@ struct cppc_power_info {\n \tuint16_t turbo_enable; /**< Turbo Boost enable/disable */\n \tuint32_t nb_freqs; /**< number of available freqs */\n \tuint32_t freqs[RTE_MAX_LCORE_FREQS]; /**< Frequency array */\n-} __rte_cache_aligned;\n+};\n \n static struct cppc_power_info lcore_power_info[RTE_MAX_LCORE];\n \ndiff --git a/lib/power/power_intel_uncore.c b/lib/power/power_intel_uncore.c\nindex 3ce8fcc..9c152e4 100644\n--- a/lib/power/power_intel_uncore.c\n+++ b/lib/power/power_intel_uncore.c\n@@ -29,7 +29,7 @@\n \t\t\"/sys/devices/system/cpu/intel_uncore_frequency/package_%02u_die_%02u/initial_min_freq_khz\"\n \n \n-struct uncore_power_info {\n+struct __rte_cache_aligned uncore_power_info {\n \tunsigned int die; /* Core die id */\n \tunsigned int pkg; /* Package id */\n \tuint32_t freqs[MAX_UNCORE_FREQS]; /* Frequency array */\n@@ -41,7 +41,7 @@ struct uncore_power_info {\n \tuint32_t org_max_freq; /* Original max freq of uncore */\n \tuint32_t init_max_freq; /* System max uncore freq */\n \tuint32_t init_min_freq; /* System min uncore freq */\n-} __rte_cache_aligned;\n+};\n \n static struct uncore_power_info uncore_info[RTE_MAX_NUMA_NODES][MAX_NUMA_DIE];\n \ndiff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c\nindex 73138dc..2343121 100644\n--- a/lib/power/power_pstate_cpufreq.c\n+++ b/lib/power/power_pstate_cpufreq.c\n@@ -49,7 +49,7 @@ enum power_state {\n \tPOWER_UNKNOWN\n };\n \n-struct pstate_power_info {\n+struct __rte_cache_aligned pstate_power_info {\n \tunsigned int lcore_id; /**< Logical core id */\n \tuint32_t freqs[RTE_MAX_LCORE_FREQS]; /**< Frequency array */\n \tuint32_t nb_freqs; /**< number of available freqs */\n@@ -64,7 +64,7 @@ struct pstate_power_info {\n \tuint16_t turbo_available; /**< Turbo Boost available */\n \tuint16_t turbo_enable; /**< Turbo Boost enable/disable */\n \tuint16_t priority_core; /**< High Performance core */\n-} __rte_cache_aligned;\n+};\n \n \n static struct pstate_power_info lcore_power_info[RTE_MAX_LCORE];\ndiff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c\nindex 591fc69..b1c18a5 100644\n--- a/lib/power/rte_power_pmd_mgmt.c\n+++ b/lib/power/rte_power_pmd_mgmt.c\n@@ -55,7 +55,7 @@ struct queue_list_entry {\n \tconst struct rte_eth_rxtx_callback *cb;\n };\n \n-struct pmd_core_cfg {\n+struct __rte_cache_aligned pmd_core_cfg {\n \tTAILQ_HEAD(queue_list_head, queue_list_entry) head;\n \t/**< List of queues associated with this lcore */\n \tsize_t n_queues;\n@@ -68,7 +68,7 @@ struct pmd_core_cfg {\n \t/**< Number of queues ready to enter power optimized state */\n \tuint64_t sleep_target;\n \t/**< Prevent a queue from triggering sleep multiple times */\n-} __rte_cache_aligned;\n+};\n static struct pmd_core_cfg lcore_cfgs[RTE_MAX_LCORE];\n \n static inline bool\n", "prefixes": [ "v6", "21/39" ] }