Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137243/?format=api
{ "id": 137243, "url": "http://patches.dpdk.org/api/patches/137243/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-7-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708971946-18231-7-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708971946-18231-7-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-26T18:25:13", "name": "[v6,06/39] pipeline: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "14fd85a951fbacdee964c7475d3273afc018888d", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708971946-18231-7-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31229, "url": "http://patches.dpdk.org/api/series/31229/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31229", "date": "2024-02-26T18:25:09", "name": "use C11 alignas", "version": 6, "mbox": "http://patches.dpdk.org/series/31229/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137243/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137243/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8861243B7E;\n\tMon, 26 Feb 2024 19:26:33 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5197B42E78;\n\tMon, 26 Feb 2024 19:25:59 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id F3191402B2\n for <dev@dpdk.org>; Mon, 26 Feb 2024 19:25:49 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 95BFB20B74C6; Mon, 26 Feb 2024 10:25:48 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 95BFB20B74C6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708971948;\n bh=f0Q/hLAC+zrXMG5Z07J5qlcTNKOp2E7+x4RlNxsyl9Q=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=VSRwVKdA+1sRXRqP3dh/w7hf1aZEIS8aYhazBw+kclVdVhz+ItfBgY1bRve9fdFuC\n k74EBHLQugWp4XcGalGdElAL4yhjFUgli1C9U24PMIhcIMchePC1HZZUColF/PJcmb\n ZQTXwoyZ7gMZ09FSmQX99gGlhuM6kh79MFtV3qg8=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v6 06/39] pipeline: use C11 alignas", "Date": "Mon, 26 Feb 2024 10:25:13 -0800", "Message-Id": "<1708971946-18231-7-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1708971946-18231-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/pipeline/rte_pipeline.c | 4 ++--\n lib/pipeline/rte_port_in_action.c | 3 ++-\n lib/pipeline/rte_swx_ipsec.c | 4 +++-\n lib/pipeline/rte_table_action.c | 24 ++++++++++++------------\n 4 files changed, 19 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/pipeline/rte_pipeline.c b/lib/pipeline/rte_pipeline.c\nindex 945bb02..a09a89f 100644\n--- a/lib/pipeline/rte_pipeline.c\n+++ b/lib/pipeline/rte_pipeline.c\n@@ -104,7 +104,7 @@ struct rte_table {\n \n #define RTE_PIPELINE_MAX_NAME_SZ 124\n \n-struct rte_pipeline {\n+struct __rte_cache_aligned rte_pipeline {\n \t/* Input parameters */\n \tchar name[RTE_PIPELINE_MAX_NAME_SZ];\n \tint socket_id;\n@@ -132,7 +132,7 @@ struct rte_pipeline {\n \tuint64_t pkts_mask;\n \tuint64_t n_pkts_ah_drop;\n \tuint64_t pkts_drop_mask;\n-} __rte_cache_aligned;\n+};\n \n static inline uint32_t\n rte_mask_get_next(uint64_t mask, uint32_t pos)\ndiff --git a/lib/pipeline/rte_port_in_action.c b/lib/pipeline/rte_port_in_action.c\nindex 5818973..bbacaff 100644\n--- a/lib/pipeline/rte_port_in_action.c\n+++ b/lib/pipeline/rte_port_in_action.c\n@@ -2,6 +2,7 @@\n * Copyright(c) 2010-2018 Intel Corporation\n */\n \n+#include <stdalign.h>\n #include <stdlib.h>\n #include <string.h>\n \n@@ -282,7 +283,7 @@ struct rte_port_in_action_profile *\n struct rte_port_in_action {\n \tstruct ap_config cfg;\n \tstruct ap_data data;\n-\tuint8_t memory[0] __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) uint8_t memory[0];\n };\n \n static __rte_always_inline void *\ndiff --git a/lib/pipeline/rte_swx_ipsec.c b/lib/pipeline/rte_swx_ipsec.c\nindex 28576c2..76b853f 100644\n--- a/lib/pipeline/rte_swx_ipsec.c\n+++ b/lib/pipeline/rte_swx_ipsec.c\n@@ -1,6 +1,8 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n * Copyright(c) 2022 Intel Corporation\n */\n+\n+#include <stdalign.h>\n #include <stdlib.h>\n #include <stdio.h>\n #include <errno.h>\n@@ -154,7 +156,7 @@ struct rte_swx_ipsec {\n \t/*\n \t * Table memory.\n \t */\n-\tuint8_t memory[] __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) uint8_t memory[];\n };\n \n static inline struct ipsec_sa *\ndiff --git a/lib/pipeline/rte_table_action.c b/lib/pipeline/rte_table_action.c\nindex dfdbc66..87c3e0e 100644\n--- a/lib/pipeline/rte_table_action.c\n+++ b/lib/pipeline/rte_table_action.c\n@@ -465,11 +465,11 @@ struct encap_qinq_data {\n \t((((uint64_t)(s)) & 0x1LLU) << 8) | \\\n \t(((uint64_t)(ttl)) & 0xFFLLU)))\n \n-struct encap_mpls_data {\n+struct __rte_aligned(2) encap_mpls_data {\n \tstruct rte_ether_hdr ether;\n \tuint32_t mpls[RTE_TABLE_ACTION_MPLS_LABELS_MAX];\n \tuint32_t mpls_count;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n #define PPP_PROTOCOL_IP 0x0021\n \n@@ -487,42 +487,42 @@ struct encap_pppoe_data {\n \n #define IP_PROTO_UDP 17\n \n-struct encap_vxlan_ipv4_data {\n+struct __rte_aligned(2) encap_vxlan_ipv4_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_ipv4_hdr ipv4;\n \tstruct rte_udp_hdr udp;\n \tstruct rte_vxlan_hdr vxlan;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n-struct encap_vxlan_ipv4_vlan_data {\n+struct __rte_aligned(2) encap_vxlan_ipv4_vlan_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_vlan_hdr vlan;\n \tstruct rte_ipv4_hdr ipv4;\n \tstruct rte_udp_hdr udp;\n \tstruct rte_vxlan_hdr vxlan;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n-struct encap_vxlan_ipv6_data {\n+struct __rte_aligned(2) encap_vxlan_ipv6_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_ipv6_hdr ipv6;\n \tstruct rte_udp_hdr udp;\n \tstruct rte_vxlan_hdr vxlan;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n-struct encap_vxlan_ipv6_vlan_data {\n+struct __rte_aligned(2) encap_vxlan_ipv6_vlan_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_vlan_hdr vlan;\n \tstruct rte_ipv6_hdr ipv6;\n \tstruct rte_udp_hdr udp;\n \tstruct rte_vxlan_hdr vxlan;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n-struct encap_qinq_pppoe_data {\n+struct __rte_aligned(2) encap_qinq_pppoe_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_vlan_hdr svlan;\n \tstruct rte_vlan_hdr cvlan;\n \tstruct pppoe_ppp_hdr pppoe_ppp;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n static size_t\n encap_data_size(struct rte_table_action_encap_config *encap)\n", "prefixes": [ "v6", "06/39" ] }