Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137209/?format=api
{ "id": 137209, "url": "http://patches.dpdk.org/api/patches/137209/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240226131848.2982242-3-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240226131848.2982242-3-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240226131848.2982242-3-michaelba@nvidia.com", "date": "2024-02-26T13:18:47", "name": "[v7,2/3] net/mlx5: add support to compare random value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "896989302338b25b9db5e623776d789ebde0319f", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240226131848.2982242-3-michaelba@nvidia.com/mbox/", "series": [ { "id": 31223, "url": "http://patches.dpdk.org/api/series/31223/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31223", "date": "2024-02-26T13:18:46", "name": "net/mlx5: add compare item support", "version": 7, "mbox": "http://patches.dpdk.org/series/31223/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137209/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137209/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1BD6343BED;\n\tMon, 26 Feb 2024 14:19:24 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EDF3A42E30;\n\tMon, 26 Feb 2024 14:19:18 +0100 (CET)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2079.outbound.protection.outlook.com [40.107.94.79])\n by mails.dpdk.org (Postfix) with ESMTP id BED8742E20\n for <dev@dpdk.org>; Mon, 26 Feb 2024 14:19:16 +0100 (CET)", "from CH2PR14CA0004.namprd14.prod.outlook.com (2603:10b6:610:60::14)\n by DM4PR12MB6301.namprd12.prod.outlook.com (2603:10b6:8:a5::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Mon, 26 Feb\n 2024 13:19:13 +0000", "from DS3PEPF000099E1.namprd04.prod.outlook.com\n (2603:10b6:610:60:cafe::ab) by CH2PR14CA0004.outlook.office365.com\n (2603:10b6:610:60::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.49 via Frontend\n Transport; Mon, 26 Feb 2024 13:19:13 +0000", "from mail.nvidia.com (216.228.118.233) by\n DS3PEPF000099E1.mail.protection.outlook.com (10.167.17.196) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7292.25 via Frontend Transport; Mon, 26 Feb 2024 13:19:13 +0000", "from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com\n (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 26 Feb\n 2024 05:19:00 -0800", "from drhqmail203.nvidia.com (10.126.190.182) by\n drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1258.12; Mon, 26 Feb 2024 05:18:59 -0800", "from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.182)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12 via Frontend\n Transport; Mon, 26 Feb 2024 05:18:57 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=MVwjw4IiR8bzoI1j7WIWCEg0JW2ktJeq40AUzaVRwuTfm5OyQLvHQyJ7li9GEsGnJL3CYnHEi8747evOsAG66mnqFNeHL91YEDnWLD9X5dTu2jW14kLjE3vIDrcttfZQ6Tu3Nhz8BySTUZOlLN5lBcV2oNF1lGPGL3Q4TD6TgA0B121S9sRT8n6LpkuCA0lsSzL7+qeNFD07rCC+KWAE4n5p7A4wclgy2hItoRu8IExC1QqU3eQqT2SwJqkS4zQTDwno4oOj2UzF4YYpjS1W5yYYvZQHUsjqS5SBOEQno7+7sZ0yGcMHoG47v8aLv6cf3sCOGwEOLPaKXGZugrYdoA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=lGZFxIkuX1rIjffvq6FX2PuuC4SyYV23myD8DPwkqig=;\n b=en0fIo5X53gcEz3hZoooV6f6ORsyHd5HHqjQqvsPBDCvaH9J0TMZ4i8rpUj3zG+i9ErDxA9eB98wP70aIX87gYhwhCdL7ejTZMG1dhY8JRVu19Tvo8dxmGbpMc2pfrGl/Kf8t5URDLeJOrcp/PfvKECJiVqkTzRtOHB1hrxtViaEhvxUfqWF+G4ZC24QHfbDnMBH5iD9oKhJYetMxj14Yxka1COEAP/lceHCc+3A2BKLYJwrD4zuca+LNEsx+5XbwYcdBzV2QzImx7lUCoIIL8ohat2S6qgzhzz2fb61u6ReCvl1b6P+u7z7QlqVp3dYHrtFt7dsPvAkjDcIZ15fcw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=lGZFxIkuX1rIjffvq6FX2PuuC4SyYV23myD8DPwkqig=;\n b=rwXt/Gn7v0OzHWA493SYNumcF1NTTuIs4VhMsDYRbQ8ycVhW1UefV/aPK+aAh3yZAqCkLmRAK9An9DN0P//9tywG3J2Wv2xMQCq0O7a2tSFhw4E4de/Fiyo+xgfWjjGtETzsVP0rW/HzF58DG9GgeGthYnFgZYW/qSssgRx6QvO8vXGfNurTk1Te8xW3Yq/hzxXes75SutSUXEL95P1Pp8qFi3H99xCSnCrIobDHruTc2ugGtEFl22tjk6jrcmofWKEQyulg8Vh070sE5QTnagMyuoHK8UDaWBQUw0ncjMbvflCZhGuZ3zKQDXplWowF4qQGr9Z4hTLMG5y8i9prMA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.118.233)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.118.233 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou\n <suanmingm@nvidia.com>", "Subject": "[PATCH v7 2/3] net/mlx5: add support to compare random value", "Date": "Mon, 26 Feb 2024 15:18:47 +0200", "Message-ID": "<20240226131848.2982242-3-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240226131848.2982242-1-michaelba@nvidia.com>", "References": "<20240226130324.2981025-1-michaelba@nvidia.com>\n <20240226131848.2982242-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DS3PEPF000099E1:EE_|DM4PR12MB6301:EE_", "X-MS-Office365-Filtering-Correlation-Id": "6ce4f9e6-e21d-47c4-6283-08dc36cd86d4", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n yMsYpLkjh0k57mdlF0Oy/ADPnxxFUA0p1A+AqjXH6eVmT0lmXyKTC5dZe3A71BuwYgenf2JhRLf5gyY2p2fPR/itJnno/woRiRYS0ghjVIv4i5x0fws/6caUsO9rAknXtYwotzlqOzCZ1NqVtdMDB1EGun4a8WZ3pQi/yF4AY9EHCaPei9oeiSCMmzuYwb3dsRUmc+4m4mBngbAcq5Ge1di+JzWJbhuI3QwWXd9upV2j/PJMaWZ2QJw+buGzJcXmqhsYgcNP2C25co5Z1ll3/uB/+KWQ6a67B+/lJGQdIFYbF1XaFNj2KxVmxiWzfaxn40vRI8ir/Rs7tGVN414GYc7kxjAoNYe0SLy4Q1C5Buf/VRVhCW71VD6wn8dej9r9249IQ1KCU9qzhU7eJ8Jw9xyFxldM49IQ+7zZRiBzTno3IXA1gBb+RneuE+E68Iep0CRFTDRWMFoihisWR2x6J1Bgkv+/t4mMBlSc410IIrUUuH6szbvz53GxSJa2Uo9aY+oKNmVa2FeQ/JWHcjtYuWa0rAIm3ky2VanPsVZoIhuj9qlQk6krZOOORWjxTlVQ9v+Je2yZqYR+sOYpcqNcQKB6YkFaZ+wkn5WjrqG2sqg73dqati6U4KPfdexNxSVX+hF21Duc9yBRBeWxixjtC3GX3e9XZt8wqvmQa2n3GRfUzzNUTwtHgBKc5MtVG5jTxc3LWrU2a6pz2Iensr5TYo6MS9m8rBZgWoaEi52uLewwyZb+ERkEeyW3rz7Lr4E9", "X-Forefront-Antispam-Report": "CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(36860700004); DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Feb 2024 13:19:13.6622 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6ce4f9e6-e21d-47c4-6283-08dc36cd86d4", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DS3PEPF000099E1.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM4PR12MB6301", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support to use \"RTE_FLOW_ITEM_TYPE_COMPARE\" with\n\"RTE_FLOW_FIELD_RAMDOM\" as an argument.\nThe random field is supported only when base is an immediate value,\nrandom field cannot be compared with enother field.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\nAcked-by: Suanming Mou <suanmingm@nvidia.com>\n---\n doc/guides/nics/mlx5.rst | 9 ++++-\n drivers/net/mlx5/mlx5_flow_hw.c | 70 ++++++++++++++++++++++++---------\n 2 files changed, 59 insertions(+), 20 deletions(-)", "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex 0d2213497a..c0a5768117 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -431,8 +431,13 @@ Limitations\n \n - Only supported in HW steering(``dv_flow_en`` = 2) mode.\n - Only single flow is supported to the flow table.\n- - Only 32-bit comparison is supported.\n- - Only match with compare result between packet fields is supported.\n+ - Only single item is supported per pattern template.\n+ - Only 32-bit comparison is supported or 16-bits for random field.\n+ - Only supported for ``RTE_FLOW_FIELD_META``, ``RTE_FLOW_FIELD_TAG``,\n+ ``RTE_FLOW_FIELD_RANDOM`` and ``RTE_FLOW_FIELD_VALUE``.\n+ - The field type ``RTE_FLOW_FIELD_VALUE`` must be the base (``b``) field.\n+ - The field type ``RTE_FLOW_FIELD_RANDOM`` can only be compared with\n+ ``RTE_FLOW_FIELD_VALUE``.\n \n - No Tx metadata go to the E-Switch steering domain for the Flow group 0.\n The flows within group 0 and set metadata action are rejected by hardware.\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 3ae1220587..f31ba2df2b 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -6721,18 +6721,55 @@ flow_hw_prepend_item(const struct rte_flow_item *items,\n \treturn copied_items;\n }\n \n-static inline bool\n-flow_hw_item_compare_field_supported(enum rte_flow_field_id field)\n+static int\n+flow_hw_item_compare_field_validate(enum rte_flow_field_id arg_field,\n+\t\t\t\t enum rte_flow_field_id base_field,\n+\t\t\t\t struct rte_flow_error *error)\n {\n-\tswitch (field) {\n+\tswitch (arg_field) {\n+\tcase RTE_FLOW_FIELD_TAG:\n+\tcase RTE_FLOW_FIELD_META:\n+\t\tbreak;\n+\tcase RTE_FLOW_FIELD_RANDOM:\n+\t\tif (base_field == RTE_FLOW_FIELD_VALUE)\n+\t\t\treturn 0;\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"compare random is supported only with immediate value\");\n+\tdefault:\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"compare item argument field is not supported\");\n+\t}\n+\tswitch (base_field) {\n \tcase RTE_FLOW_FIELD_TAG:\n \tcase RTE_FLOW_FIELD_META:\n \tcase RTE_FLOW_FIELD_VALUE:\n-\t\treturn true;\n+\t\tbreak;\n+\tdefault:\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"compare item base field is not supported\");\n+\t}\n+\treturn 0;\n+}\n+\n+static inline uint32_t\n+flow_hw_item_compare_width_supported(enum rte_flow_field_id field)\n+{\n+\tswitch (field) {\n+\tcase RTE_FLOW_FIELD_TAG:\n+\tcase RTE_FLOW_FIELD_META:\n+\t\treturn 32;\n+\tcase RTE_FLOW_FIELD_RANDOM:\n+\t\treturn 16;\n \tdefault:\n \t\tbreak;\n \t}\n-\treturn false;\n+\treturn 0;\n }\n \n static int\n@@ -6741,6 +6778,7 @@ flow_hw_validate_item_compare(const struct rte_flow_item *item,\n {\n \tconst struct rte_flow_item_compare *comp_m = item->mask;\n \tconst struct rte_flow_item_compare *comp_v = item->spec;\n+\tint ret;\n \n \tif (unlikely(!comp_m))\n \t\treturn rte_flow_error_set(error, EINVAL,\n@@ -6752,19 +6790,13 @@ flow_hw_validate_item_compare(const struct rte_flow_item *item,\n \t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t NULL,\n \t\t\t\t \"compare item only support full mask\");\n-\tif (!flow_hw_item_compare_field_supported(comp_m->a.field) ||\n-\t !flow_hw_item_compare_field_supported(comp_m->b.field))\n-\t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t NULL,\n-\t\t\t\t \"compare item field not support\");\n-\tif (comp_m->a.field == RTE_FLOW_FIELD_VALUE &&\n-\t comp_m->b.field == RTE_FLOW_FIELD_VALUE)\n-\t\treturn rte_flow_error_set(error, EINVAL,\n-\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t NULL,\n-\t\t\t\t \"compare between value is not valid\");\n+\tret = flow_hw_item_compare_field_validate(comp_m->a.field,\n+\t\t\t\t\t\t comp_m->b.field, error);\n+\tif (ret < 0)\n+\t\treturn ret;\n \tif (comp_v) {\n+\t\tuint32_t width;\n+\n \t\tif (comp_v->operation != comp_m->operation ||\n \t\t comp_v->a.field != comp_m->a.field ||\n \t\t comp_v->b.field != comp_m->b.field)\n@@ -6772,7 +6804,9 @@ flow_hw_validate_item_compare(const struct rte_flow_item *item,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t NULL,\n \t\t\t\t\t \"compare item spec/mask not matching\");\n-\t\tif ((comp_v->width & comp_m->width) != 32)\n+\t\twidth = flow_hw_item_compare_width_supported(comp_v->a.field);\n+\t\tMLX5_ASSERT(width > 0);\n+\t\tif ((comp_v->width & comp_m->width) != width)\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t NULL,\n", "prefixes": [ "v7", "2/3" ] }