Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137176/?format=api
{ "id": 137176, "url": "http://patches.dpdk.org/api/patches/137176/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240225150330.517225-4-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240225150330.517225-4-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240225150330.517225-4-mattias.ronnblom@ericsson.com", "date": "2024-02-25T15:03:27", "name": "[RFC,v4,3/6] random: keep PRNG state in lcore variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7562ae16b6a620a44bad1026e7d68df0f55f0419", "submitter": { "id": 1077, "url": "http://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240225150330.517225-4-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 31210, "url": "http://patches.dpdk.org/api/series/31210/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31210", "date": "2024-02-25T15:03:24", "name": "Lcore variables", "version": 4, "mbox": "http://patches.dpdk.org/series/31210/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137176/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137176/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 94BB143BD2;\n\tSun, 25 Feb 2024 16:12:35 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A212042DAC;\n\tSun, 25 Feb 2024 16:12:06 +0100 (CET)", "from EUR04-HE1-obe.outbound.protection.outlook.com\n (mail-he1eur04on2080.outbound.protection.outlook.com [40.107.7.80])\n by mails.dpdk.org (Postfix) with ESMTP id 54A8D427DD\n for <dev@dpdk.org>; Sun, 25 Feb 2024 16:11:57 +0100 (CET)", "from DU2PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:10:232::9)\n by AS8PR07MB7560.eurprd07.prod.outlook.com (2603:10a6:20b:2ae::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.33; Sun, 25 Feb\n 2024 15:11:55 +0000", "from DU2PEPF0001E9C6.eurprd03.prod.outlook.com\n (2603:10a6:10:232:cafe::38) by DU2PR04CA0064.outlook.office365.com\n (2603:10a6:10:232::9) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.49 via Frontend\n Transport; Sun, 25 Feb 2024 15:11:55 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n DU2PEPF0001E9C6.mail.protection.outlook.com (10.167.8.75) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7292.25 via Frontend Transport; Sun, 25 Feb 2024 15:11:55 +0000", "from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by\n smtp-central.internal.ericsson.com (100.87.178.60) with Microsoft SMTP Server\n id 15.2.1258.12; Sun, 25 Feb 2024 16:11:53 +0100", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id\n 957A8380061; Sun, 25 Feb 2024 16:11:53 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=a0EDza5COejNm+HjX2g5KjwmLTzQgnIGFpFkt45g0BIe0xj5fRQZ9e3PG9xKTh6tNrH40MDaAflo3xZv07T6jDexFdrke3jOhGBs2GI2R3f74C02e2wZmNGGjdMvC8Sm+jKa8xZFFKvUfyEBv1GS2Tavo+R3dwR6QosP6qS6nB28pRUXvoIfvI3bgQ6u6KBIvBYSJquSi4A6rXAkK/Dl6gOqqX4swDlrv0nfGkbfAcgYoyrjA20Pa+qS2tHEOKrOthas22TNQ4tb82AZMHBp/JruZg1VWYOkmZ1OYQ8ICqawkvhA8kfuO1xjEj9+Aa6U62TELluBNjPMKWNVWVhzwg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=8lBGZUWMvJ+xi/hRt3dkkJhhf0E7azD832S+1BFYhIY=;\n b=XaBz2HXO8q+LOs24J+hEh5XcDOlGk081cpD56oYL3EX9CkAoQXEyjSOpzTR1oBsHyVHKyjz+bf8GY6Hsfuehm8T1/HAC2Dvg5OIpOMsHqs9/AKGU0Hmz0pWrvFxYS62Leh/7vwRKfxpBC2mwm7Op6ilXWeX0cIAeyXivy7HbUHjpNSGvVb9areLKs70f9UWG2S5SbozZgL2NI6ahqj+jyMGDqSLn9IiwK7jHkzyW38Y11rw5Jgzh1Kfl/vtyKBB7M1+2xlde3YYv+F2rFzjtEzihkRaf52RZ7lbnaSc6AOD82kScvMeKCv/AoQRoCvPGa8HzixR0b8g60G7abxAtuw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=8lBGZUWMvJ+xi/hRt3dkkJhhf0E7azD832S+1BFYhIY=;\n b=ICPeAYrEkEY+N2zhZYX2M/rN0lCC6Xz607X+coGW3CPEJUsa52cnJupGrjYTjjth41X87nljSU8McyiJX845PVYxT0ohpq8bZnpTQChTgS0z1SlwKKeEXeqtgmemdk8yGMVwmNHHUtoRBtWAfKkBAkuCyk/92dtfZBESnc2hAIWvIP754/CGjpEqjqs2njzKFf4vV8Tq2z4a5WwURGJvPpG+AwbPcrVS2Y8BHxtpaFDWD2YxgGSxAzgfBYrUk4eHM3SpofBElEvjZ7JawTJhZFEWC/Cd3LTL3H3W0mr8KbUKdaqK/Wa+fiK105LW+cuEDC0y4Hg14HAqj9kOOTqHVA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Mattias_R=C3=B6nn?=\n\t=?utf-8?q?blom?= <mattias.ronnblom@ericsson.com>", "Subject": "[RFC v4 3/6] random: keep PRNG state in lcore variable", "Date": "Sun, 25 Feb 2024 16:03:27 +0100", "Message-ID": "<20240225150330.517225-4-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240225150330.517225-1-mattias.ronnblom@ericsson.com>", "References": "<20240220084908.488252-2-mattias.ronnblom@ericsson.com>\n <20240225150330.517225-1-mattias.ronnblom@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DU2PEPF0001E9C6:EE_|AS8PR07MB7560:EE_", "X-MS-Office365-Filtering-Correlation-Id": "348d29aa-ed2c-44a3-0743-08dc36141ad8", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n BdnUZwG51qYjJ41HCkPTqs6i8MIBc+aG9MqI7Z3WMDP6uCsv91H+f105amuvTZ/2DnQjugjX0GNSCWHeRkyO+/S2boYcEgLDs6MsSXLpUIYQqGe21Xv95eG00u7vq3hW3GCJMFzqUL55ibBDHGYh6igZZ/LByk6Tu+SvB8ajKUuDx0KHqSAmWRzMS/nUc1WBDg2YeaMA+RCtSzokIOKe6x4lb0hdCVbIr+JG7eRFfk1ahAx2iNpvcRPs38sLauybf94g549Spe/A5bMklCqo232W1xQWf+TLpt0LLIf3auo1J6SU8x2tZzv4yeZpo9AHW4iZLFpD0O63fLOAaC0iJHtBSzK8eTnmkYmWQb8f2L0ovgvk61heRXFqpZCf0Hwu1wShvCQwZga4PKmHvQos2LJrFdIy/xVsfP2ceDP3ejhrCJ66lsDc0G98by89qNqlrvUx8VRaM450MbPZv8yKbYXKdzvvZ7vmZV2vNIcOHkWbdJPYVFtzRXWLs3Y+Na93Jx7P2kBwxfkAiqUWQqmgMUKKLJ0tlyxVuXbe70ds88l4gQaCE4M9wMPHOlWjx/W9ElGq3QscmZsJKUZU7SI+HMJ70WiTXaOhA8UGqWjUEq0jfadRqrIXNtqyQOQxDTaPXfXg1xTwB221qX2xD/vZ7g==", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE; SFS:(13230031)(36860700004)(46966006)(40470700004); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "25 Feb 2024 15:11:55.6441 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 348d29aa-ed2c-44a3-0743-08dc36141ad8", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DU2PEPF0001E9C6.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AS8PR07MB7560", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of\ncache-aligned and RTE_CACHE_GUARDed struct instances with keeping the\nsame state in a more cache-friendly lcore variable.\n\nRFC v3:\n * Remove cache alignment on unregistered threads' rte_rand_state.\n (Morten Brørup)\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/eal/common/rte_random.c | 30 ++++++++++++++++++------------\n 1 file changed, 18 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/eal/common/rte_random.c b/lib/eal/common/rte_random.c\nindex 7709b8f2c6..adbbf13f0e 100644\n--- a/lib/eal/common/rte_random.c\n+++ b/lib/eal/common/rte_random.c\n@@ -11,6 +11,7 @@\n #include <rte_branch_prediction.h>\n #include <rte_cycles.h>\n #include <rte_lcore.h>\n+#include <rte_lcore_var.h>\n #include <rte_random.h>\n \n struct rte_rand_state {\n@@ -19,14 +20,12 @@ struct rte_rand_state {\n \tuint64_t z3;\n \tuint64_t z4;\n \tuint64_t z5;\n-\tRTE_CACHE_GUARD;\n-} __rte_cache_aligned;\n+};\n \n-/* One instance each for every lcore id-equipped thread, and one\n- * additional instance to be shared by all others threads (i.e., all\n- * unregistered non-EAL threads).\n- */\n-static struct rte_rand_state rand_states[RTE_MAX_LCORE + 1];\n+RTE_LCORE_VAR_HANDLE(struct rte_rand_state, rand_state);\n+\n+/* instance to be shared by all unregistered non-EAL threads */\n+static struct rte_rand_state unregistered_rand_state;\n \n static uint32_t\n __rte_rand_lcg32(uint32_t *seed)\n@@ -85,8 +84,14 @@ rte_srand(uint64_t seed)\n \tunsigned int lcore_id;\n \n \t/* add lcore_id to seed to avoid having the same sequence */\n-\tfor (lcore_id = 0; lcore_id < RTE_DIM(rand_states); lcore_id++)\n-\t\t__rte_srand_lfsr258(seed + lcore_id, &rand_states[lcore_id]);\n+\tfor (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {\n+\t\tstruct rte_rand_state *lcore_state =\n+\t\t\tRTE_LCORE_VAR_LCORE_PTR(lcore_id, rand_state);\n+\n+\t\t__rte_srand_lfsr258(seed + lcore_id, lcore_state);\n+\t}\n+\n+\t__rte_srand_lfsr258(seed + lcore_id, &unregistered_rand_state);\n }\n \n static __rte_always_inline uint64_t\n@@ -124,11 +129,10 @@ struct rte_rand_state *__rte_rand_get_state(void)\n \n \tidx = rte_lcore_id();\n \n-\t/* last instance reserved for unregistered non-EAL threads */\n \tif (unlikely(idx == LCORE_ID_ANY))\n-\t\tidx = RTE_MAX_LCORE;\n+\t\treturn &unregistered_rand_state;\n \n-\treturn &rand_states[idx];\n+\treturn RTE_LCORE_VAR_PTR(rand_state);\n }\n \n uint64_t\n@@ -228,6 +232,8 @@ RTE_INIT(rte_rand_init)\n {\n \tuint64_t seed;\n \n+\tRTE_LCORE_VAR_ALLOC(rand_state);\n+\n \tseed = __rte_random_initial_seed();\n \n \trte_srand(seed);\n", "prefixes": [ "RFC", "v4", "3/6" ] }