Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137164/?format=api
{ "id": 137164, "url": "http://patches.dpdk.org/api/patches/137164/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708762927-14126-12-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708762927-14126-12-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708762927-14126-12-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-24T08:21:56", "name": "[v5,11/22] net/fm10k: use mbuf descriptor accessors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f67bd8f6487e6a1e6b38412f8e0bfa8dc022d2c8", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708762927-14126-12-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31208, "url": "http://patches.dpdk.org/api/series/31208/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31208", "date": "2024-02-24T08:21:46", "name": "stop using RTE_MARKER extensions", "version": 5, "mbox": "http://patches.dpdk.org/series/31208/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137164/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/137164/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 219D543BBD;\n\tSat, 24 Feb 2024 09:25:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E46E442DDE;\n\tSat, 24 Feb 2024 09:24:10 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 60D39402DD\n for <dev@dpdk.org>; Sat, 24 Feb 2024 09:22:13 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id D3CF120B74CB; Sat, 24 Feb 2024 00:22:11 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com D3CF120B74CB", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708762931;\n bh=Ka2zgA7eDao2qQJobgjrXSpTWXjn+sAIITxtUuaggmY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ZRSTTibKRupQDf7dgsIYRdjgM3R0oZbvp0t52i6vsP3X3NkjijvmWOgdLfXV9reXG\n ljBAHmu/M7wibSY2vSlhDVuQaCmZoLft2SjIjc4ynAxGg+w3ztZWtTHjo1zv2VIlsk\n ma3NKooqd82VZc12Hcnh/1FHAPiiYhLZCKHleuiU=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 11/22] net/fm10k: use mbuf descriptor accessors", "Date": "Sat, 24 Feb 2024 00:21:56 -0800", "Message-Id": "<1708762927-14126-12-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708762927-14126-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1708762927-14126-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use\nnew rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors\nthat provide a compatible type pointer without using the marker fields.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/fm10k/fm10k_rxtx_vec.c | 19 +++++++------------\n 1 file changed, 7 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/net/fm10k/fm10k_rxtx_vec.c\nindex 2b6914b..e7d3810 100644\n--- a/drivers/net/fm10k/fm10k_rxtx_vec.c\n+++ b/drivers/net/fm10k/fm10k_rxtx_vec.c\n@@ -226,7 +226,6 @@\n int __rte_cold\n fm10k_rxq_vec_setup(struct fm10k_rx_queue *rxq)\n {\n-\tuintptr_t p;\n \tstruct rte_mbuf mb_def = { .buf_addr = 0 }; /* zeroed mbuf */\n \n \tmb_def.nb_segs = 1;\n@@ -239,8 +238,7 @@\n \n \t/* prevent compiler reordering: rearm_data covers previous fields */\n \trte_compiler_barrier();\n-\tp = (uintptr_t)&mb_def.rearm_data;\n-\trxq->mbuf_initializer = *(uint64_t *)p;\n+\trxq->mbuf_initializer = *rte_mbuf_rearm_data(&mb_def);\n \treturn 0;\n }\n \n@@ -282,7 +280,6 @@\n \t/* Initialize the mbufs in vector, process 2 mbufs in one loop */\n \tfor (i = 0; i < RTE_FM10K_RXQ_REARM_THRESH; i += 2, mb_alloc += 2) {\n \t\t__m128i vaddr0, vaddr1;\n-\t\tuintptr_t p0, p1;\n \n \t\tmb0 = mb_alloc[0];\n \t\tmb1 = mb_alloc[1];\n@@ -290,10 +287,8 @@\n \t\t/* Flush mbuf with pkt template.\n \t\t * Data to be rearmed is 6 bytes long.\n \t\t */\n-\t\tp0 = (uintptr_t)&mb0->rearm_data;\n-\t\t*(uint64_t *)p0 = rxq->mbuf_initializer;\n-\t\tp1 = (uintptr_t)&mb1->rearm_data;\n-\t\t*(uint64_t *)p1 = rxq->mbuf_initializer;\n+\t\t*rte_mbuf_rearm_data(mb0) = rxq->mbuf_initializer;\n+\t\t*rte_mbuf_rearm_data(mb1) = rxq->mbuf_initializer;\n \n \t\t/* load buf_addr(lo 64bit) and buf_iova(hi 64bit) */\n \t\tRTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, buf_iova) !=\n@@ -519,9 +514,9 @@\n \t\tstaterr = _mm_unpacklo_epi32(sterr_tmp1, sterr_tmp2);\n \n \t\t/* D.3 copy final 3,4 data to rx_pkts */\n-\t\t_mm_storeu_si128((void *)&rx_pkts[pos+3]->rx_descriptor_fields1,\n+\t\t_mm_storeu_si128(rte_mbuf_rx_descriptor_fields1(rx_pkts[pos+3]),\n \t\t\t\tpkt_mb4);\n-\t\t_mm_storeu_si128((void *)&rx_pkts[pos+2]->rx_descriptor_fields1,\n+\t\t_mm_storeu_si128(rte_mbuf_rx_descriptor_fields1(rx_pkts[pos+2]),\n \t\t\t\tpkt_mb3);\n \n \t\t/* C* extract and record EOP bit */\n@@ -557,9 +552,9 @@\n \t\tstaterr = _mm_packs_epi32(staterr, zero);\n \n \t\t/* D.3 copy final 1,2 data to rx_pkts */\n-\t\t_mm_storeu_si128((void *)&rx_pkts[pos+1]->rx_descriptor_fields1,\n+\t\t_mm_storeu_si128(rte_mbuf_rx_descriptor_fields1(rx_pkts[pos+1]),\n \t\t\t\tpkt_mb2);\n-\t\t_mm_storeu_si128((void *)&rx_pkts[pos]->rx_descriptor_fields1,\n+\t\t_mm_storeu_si128(rte_mbuf_rx_descriptor_fields1(rx_pkts[pos]),\n \t\t\t\tpkt_mb1);\n \n \t\tfm10k_desc_to_pktype_v(descs0, &rx_pkts[pos]);\n", "prefixes": [ "v5", "11/22" ] }