Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137160/?format=api
{ "id": 137160, "url": "http://patches.dpdk.org/api/patches/137160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708762927-14126-13-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708762927-14126-13-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708762927-14126-13-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-24T08:21:57", "name": "[v5,12/22] net/hns3: use mbuf descriptor accessors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9957c78696d5dc1f1a66dde6c3785900e503a4d6", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708762927-14126-13-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31208, "url": "http://patches.dpdk.org/api/series/31208/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31208", "date": "2024-02-24T08:21:46", "name": "stop using RTE_MARKER extensions", "version": 5, "mbox": "http://patches.dpdk.org/series/31208/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137160/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137160/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A6D543BBD;\n\tSat, 24 Feb 2024 09:25:07 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0F0A942DC1;\n\tSat, 24 Feb 2024 09:24:06 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 433B9402DC\n for <dev@dpdk.org>; Sat, 24 Feb 2024 09:22:13 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id E29BB20B74CC; Sat, 24 Feb 2024 00:22:11 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E29BB20B74CC", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708762931;\n bh=UR8/tFwZvKmNTbmYPlXw5P9bSROZKI7wmTQyU2lBH2M=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ZhHTqr9W+IA582/BXvf4QOwmVm5BitNdIohnzFqW31HG44xQhAgLFP6iD9b5XSzoa\n kd3j+foWrTJ0DVFY4xSl80mlzTaCP8wkbI997BxTb3RvNXAGPGfZBC0BJEOJp9KaaU\n k1ttEzlCP8ANeEw1bfoNhCRp60t1mr/A14h6EoJw=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 12/22] net/hns3: use mbuf descriptor accessors", "Date": "Sat, 24 Feb 2024 00:21:57 -0800", "Message-Id": "<1708762927-14126-13-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708762927-14126-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1708762927-14126-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use\nnew rte_mbuf_rearm_data and rte_mbuf_rx_descriptor_fields1 accessors\nthat provide a compatible type pointer without using the marker fields.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/hns3/hns3_rxtx_vec.c | 4 +---\n drivers/net/hns3/hns3_rxtx_vec_neon.h | 16 ++++++++--------\n 2 files changed, 9 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx_vec.c b/drivers/net/hns3/hns3_rxtx_vec.c\nindex 9708ec6..174be45 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec.c\n+++ b/drivers/net/hns3/hns3_rxtx_vec.c\n@@ -113,7 +113,6 @@\n static void\n hns3_rxq_vec_setup_rearm_data(struct hns3_rx_queue *rxq)\n {\n-\tuintptr_t p;\n \tstruct rte_mbuf mb_def = { .buf_addr = 0 }; /* zeroed mbuf */\n \n \tmb_def.nb_segs = 1;\n@@ -141,8 +140,7 @@\n \n \t/* prevent compiler reordering: rearm_data covers previous fields */\n \trte_compiler_barrier();\n-\tp = (uintptr_t)&mb_def.rearm_data;\n-\trxq->mbuf_initializer = *(uint64_t *)p;\n+\trxq->mbuf_initializer = *rte_mbuf_rearm_data(&mb_def);\n }\n \n void\ndiff --git a/drivers/net/hns3/hns3_rxtx_vec_neon.h b/drivers/net/hns3/hns3_rxtx_vec_neon.h\nindex 0dc6b9f..7b2c3e3 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec_neon.h\n+++ b/drivers/net/hns3/hns3_rxtx_vec_neon.h\n@@ -236,23 +236,23 @@\n \t\tpkt_mb4 = vreinterpretq_u8_u16(tmp);\n \n \t\t/* save packet info to rx_pkts mbuf */\n-\t\tvst1q_u8((void *)&sw_ring[pos + 0].mbuf->rx_descriptor_fields1,\n+\t\tvst1q_u8(rte_mbuf_rx_descriptor_fields1(sw_ring[pos + 0].mbuf),\n \t\t\t pkt_mb1);\n-\t\tvst1q_u8((void *)&sw_ring[pos + 1].mbuf->rx_descriptor_fields1,\n+\t\tvst1q_u8(rte_mbuf_rx_descriptor_fields1(sw_ring[pos + 1].mbuf),\n \t\t\t pkt_mb2);\n-\t\tvst1q_u8((void *)&sw_ring[pos + 2].mbuf->rx_descriptor_fields1,\n+\t\tvst1q_u8(rte_mbuf_rx_descriptor_fields1(sw_ring[pos + 2].mbuf),\n \t\t\t pkt_mb3);\n-\t\tvst1q_u8((void *)&sw_ring[pos + 3].mbuf->rx_descriptor_fields1,\n+\t\tvst1q_u8(rte_mbuf_rx_descriptor_fields1(sw_ring[pos + 3].mbuf),\n \t\t\t pkt_mb4);\n \n \t\t/* store the first 8 bytes of packets mbuf's rearm_data */\n-\t\t*(uint64_t *)&sw_ring[pos + 0].mbuf->rearm_data =\n+\t\t*rte_mbuf_rearm_data(&sw_ring[pos + 0].mbuf) =\n \t\t\trxq->mbuf_initializer;\n-\t\t*(uint64_t *)&sw_ring[pos + 1].mbuf->rearm_data =\n+\t\t*rte_mbuf_rearm_data(&sw_ring[pos + 1].mbuf) =\n \t\t\trxq->mbuf_initializer;\n-\t\t*(uint64_t *)&sw_ring[pos + 2].mbuf->rearm_data =\n+\t\t*rte_mbuf_rearm_data(&sw_ring[pos + 2].mbuf) =\n \t\t\trxq->mbuf_initializer;\n-\t\t*(uint64_t *)&sw_ring[pos + 3].mbuf->rearm_data =\n+\t\t*rte_mbuf_rearm_data(&sw_ring[pos + 3].mbuf) =\n \t\t\trxq->mbuf_initializer;\n \n \t\trte_prefetch_non_temporal(rxdp + HNS3_DEFAULT_DESCS_PER_LOOP);\n", "prefixes": [ "v5", "12/22" ] }