Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137151/?format=api
{ "id": 137151, "url": "http://patches.dpdk.org/api/patches/137151/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708762927-14126-3-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708762927-14126-3-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708762927-14126-3-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-24T08:21:47", "name": "[v5,02/22] mbuf: expand rte markers empty when building with MSVC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4134b50ade8c72773ed7b7dbe3e5dbad0904e574", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708762927-14126-3-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31208, "url": "http://patches.dpdk.org/api/series/31208/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31208", "date": "2024-02-24T08:21:46", "name": "stop using RTE_MARKER extensions", "version": 5, "mbox": "http://patches.dpdk.org/series/31208/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137151/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137151/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 23C1843BBD;\n\tSat, 24 Feb 2024 09:24:11 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3C92F402ED;\n\tSat, 24 Feb 2024 09:23:56 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 4B195402CC\n for <dev@dpdk.org>; Sat, 24 Feb 2024 09:22:12 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 4D9E620B74C2; Sat, 24 Feb 2024 00:22:11 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 4D9E620B74C2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708762931;\n bh=KIcBZuSyclC5wESrYqxGvTee2yjHZnxqZZG1TxnoLEs=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=V6pHjLGW8DDuIrV0+XakqMYtmyX7jMkGXUp9QA2yjY1b0g7O1d9i5OtsuM4Pp3M6z\n eJIOOPUlm+A8ojYagK/DrlmLY52Nc9aldVqof7MBPzJnuOiNA6dUJEjvfWwevFLMLX\n tq4g4lTLMfNUEP375LihffGVvCDSGkfzyyUivSZ8=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 02/22] mbuf: expand rte markers empty when building with\n MSVC", "Date": "Sat, 24 Feb 2024 00:21:47 -0800", "Message-Id": "<1708762927-14126-3-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708762927-14126-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1708762927-14126-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Use\n__rte_marker to expand RTE_MARKER fields empty in rte_mbuf struct.\n\nMake slight adjustment to cacheline1 __rte_cache_min_aligned as to\ncontinue maintaining correct alignment with or without the marker\nexpanding empty.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/mbuf/rte_mbuf_core.h | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h\nindex 5688683..4bf4587 100644\n--- a/lib/mbuf/rte_mbuf_core.h\n+++ b/lib/mbuf/rte_mbuf_core.h\n@@ -464,7 +464,7 @@ enum {\n * The generic rte_mbuf, containing a packet mbuf.\n */\n struct rte_mbuf {\n-\tRTE_MARKER cacheline0;\n+\t__rte_marker(RTE_MARKER, cacheline0)\n \n \tvoid *buf_addr; /**< Virtual address of segment buffer. */\n #if RTE_IOVA_IN_MBUF\n@@ -487,7 +487,7 @@ struct rte_mbuf {\n #endif\n \n \t/* next 8 bytes are initialised on RX descriptor rearm */\n-\tRTE_MARKER64 rearm_data;\n+\t__rte_marker(RTE_MARKER64, rearm_data)\n \tuint16_t data_off;\n \n \t/**\n@@ -514,7 +514,7 @@ struct rte_mbuf {\n \tuint64_t ol_flags; /**< Offload features. */\n \n \t/* remaining bytes are set on RX when pulling packet from descriptor */\n-\tRTE_MARKER rx_descriptor_fields1;\n+\t__rte_marker(RTE_MARKER, rx_descriptor_fields1)\n \n \t/*\n \t * The packet type, which is the combination of outer/inner L2, L3, L4\n@@ -595,8 +595,8 @@ struct rte_mbuf {\n \tstruct rte_mempool *pool; /**< Pool from which mbuf was allocated. */\n \n \t/* second cache line - fields only used in slow path or on TX */\n-\tRTE_MARKER cacheline1 __rte_cache_min_aligned;\n-\n+\t__rte_cache_min_aligned\n+\t__rte_marker(RTE_MARKER, cacheline1)\n #if RTE_IOVA_IN_MBUF\n \t/**\n \t * Next segment of scattered packet. Must be NULL in the last\n", "prefixes": [ "v5", "02/22" ] }