Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137145/?format=api
{ "id": 137145, "url": "http://patches.dpdk.org/api/patches/137145/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708715054-22386-37-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708715054-22386-37-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708715054-22386-37-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-23T19:04:11", "name": "[v5,36/39] fib: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6fb76d1febddb6fe6585defe58e04ec11c373e26", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708715054-22386-37-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31207, "url": "http://patches.dpdk.org/api/series/31207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31207", "date": "2024-02-23T19:03:37", "name": "use C11 alignas", "version": 5, "mbox": "http://patches.dpdk.org/series/31207/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137145/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D9DFD43BA4;\n\tFri, 23 Feb 2024 20:08:23 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 489CD42E2D;\n\tFri, 23 Feb 2024 20:05:06 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id DFFEB42C24\n for <dev@dpdk.org>; Fri, 23 Feb 2024 20:04:19 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 31ABB208432B; Fri, 23 Feb 2024 11:04:16 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 31ABB208432B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708715058;\n bh=Bt7wYT6/5SVDNGQZnQ/KW80P6rk2GfJkoY/4ChRxq4o=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=jHpiiztfuTuxitQ5GoPHxKNSpV+75yoILceAi3S7gLvEQfA0r9j965awPG3/sohVX\n V7RcCGbxNnJ60vQ86s3Hjk2xpmwJmZOe00zQ6qV/Uv135TMJkZMyrgAxlToYJktCys\n SHBSKRaPioNMwmc41PGLRvZramCUkL+P8pKK3HP0=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 36/39] fib: use C11 alignas", "Date": "Fri, 23 Feb 2024 11:04:11 -0800", "Message-Id": "<1708715054-22386-37-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708715054-22386-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1708715054-22386-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/fib/dir24_8.h | 4 +++-\n lib/fib/trie.h | 4 +++-\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/fib/dir24_8.h b/lib/fib/dir24_8.h\nindex b0d1a40..6d350f7 100644\n--- a/lib/fib/dir24_8.h\n+++ b/lib/fib/dir24_8.h\n@@ -6,6 +6,8 @@\n #ifndef _DIR24_8_H_\n #define _DIR24_8_H_\n \n+#include <stdalign.h>\n+\n #include <rte_prefetch.h>\n #include <rte_branch_prediction.h>\n \n@@ -32,7 +34,7 @@ struct dir24_8_tbl {\n \tuint64_t\t*tbl8;\t\t/**< tbl8 table. */\n \tuint64_t\t*tbl8_idxes;\t/**< bitmap containing free tbl8 idxes*/\n \t/* tbl24 table. */\n-\t__extension__ uint64_t\ttbl24[0] __rte_cache_aligned;\n+\t__extension__ alignas(RTE_CACHE_LINE_SIZE) uint64_t\ttbl24[0];\n };\n \n static inline void *\ndiff --git a/lib/fib/trie.h b/lib/fib/trie.h\nindex 3cf161a..36ce1fd 100644\n--- a/lib/fib/trie.h\n+++ b/lib/fib/trie.h\n@@ -6,6 +6,8 @@\n #ifndef _TRIE_H_\n #define _TRIE_H_\n \n+#include <stdalign.h>\n+\n /**\n * @file\n * RTE IPv6 Longest Prefix Match (LPM)\n@@ -36,7 +38,7 @@ struct rte_trie_tbl {\n \tuint32_t\t*tbl8_pool;\t/**< bitmap containing free tbl8 idxes*/\n \tuint32_t\ttbl8_pool_pos;\n \t/* tbl24 table. */\n-\t__extension__ uint64_t\ttbl24[0] __rte_cache_aligned;\n+\t__extension__ alignas(RTE_CACHE_LINE_SIZE) uint64_t\ttbl24[0];\n };\n \n static inline uint32_t\n", "prefixes": [ "v5", "36/39" ] }