Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137122/?format=api
http://patches.dpdk.org/api/patches/137122/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1708715054-22386-15-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1708715054-22386-15-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1708715054-22386-15-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-23T19:03:49", "name": "[v5,14/39] acl: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e998736ece6a27914b3773bc8871e25e86b870da", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1708715054-22386-15-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31207, "url": "http://patches.dpdk.org/api/series/31207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31207", "date": "2024-02-23T19:03:37", "name": "use C11 alignas", "version": 5, "mbox": "http://patches.dpdk.org/series/31207/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137122/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/137122/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C801A43BA4;\n\tFri, 23 Feb 2024 20:05:56 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2384E42DAC;\n\tFri, 23 Feb 2024 20:04:37 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 7CD42402C7\n for <dev@dpdk.org>; Fri, 23 Feb 2024 20:04:18 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id DB4E120B74CE; Fri, 23 Feb 2024 11:04:16 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com DB4E120B74CE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1708715056;\n bh=Hn3eQXdAV5zn27n+AE5FRJppLi+fzowk4K7ilapWlxo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=L1ISSyQz8KnQykymRQD7stA8sJ65dgNahK32pD6DoJoxFiV2oOE1VuptOAjC3Aamz\n IIkvrKXR4E9Tqi8A6RQrdF1M3AMgsdLOop9qLNq6hFNUskqbEzM9aBrTLKsLasw7Fp\n 1IhKlpe5P6nGIT4cgHBB4ZqRVjnwL5nuLFnspoeo=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 14/39] acl: use C11 alignas", "Date": "Fri, 23 Feb 2024 11:03:49 -0800", "Message-Id": "<1708715054-22386-15-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1708715054-22386-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1708715054-22386-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current location used for __rte_aligned(a) for alignment of types\nand variables is not compatible with MSVC. There is only a single\nlocation accepted by both toolchains.\n\nFor variables standard C11 offers alignas(a) supported by conformant\ncompilers i.e. both MSVC and GCC.\n\nFor types the standard offers no alignment facility that compatibly\ninteroperates with C and C++ but may be achieved by relocating the\nplacement of __rte_aligned(a) to the aforementioned location accepted\nby all currently supported toolchains.\n\nTo allow alignment for both compilers do the following:\n\n* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/acl/acl_run.h | 4 ++--\n lib/acl/acl_run_altivec.h | 6 ++++--\n lib/acl/acl_run_neon.h | 6 ++++--\n 3 files changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h\nindex 7d215de..7f09241 100644\n--- a/lib/acl/acl_run.h\n+++ b/lib/acl/acl_run.h\n@@ -55,12 +55,12 @@ struct acl_flow_data {\n * Structure to maintain running results for\n * a single packet (up to 4 tries).\n */\n-struct completion {\n+struct __rte_aligned(XMM_SIZE) completion {\n \tuint32_t *results; /* running results. */\n \tint32_t priority[RTE_ACL_MAX_CATEGORIES]; /* running priorities. */\n \tuint32_t count; /* num of remaining tries */\n \t/* true for allocated struct */\n-} __rte_aligned(XMM_SIZE);\n+};\n \n /*\n * One parms structure for each slot in the search engine.\ndiff --git a/lib/acl/acl_run_altivec.h b/lib/acl/acl_run_altivec.h\nindex 3c30466..2d398ff 100644\n--- a/lib/acl/acl_run_altivec.h\n+++ b/lib/acl/acl_run_altivec.h\n@@ -3,15 +3,17 @@\n * Copyright (C) IBM Corporation 2016.\n */\n \n+#include <stdalign.h>\n+\n #include \"acl_run.h\"\n #include \"acl_vect.h\"\n \n-struct _altivec_acl_const {\n+alignas(RTE_CACHE_LINE_SIZE) struct _altivec_acl_const {\n \trte_xmm_t xmm_shuffle_input;\n \trte_xmm_t xmm_index_mask;\n \trte_xmm_t xmm_ones_16;\n \trte_xmm_t range_base;\n-} altivec_acl_const __rte_cache_aligned = {\n+} altivec_acl_const = {\n \t{\n \t\t.u32 = {0x00000000, 0x04040404, 0x08080808, 0x0c0c0c0c}\n \t},\ndiff --git a/lib/acl/acl_run_neon.h b/lib/acl/acl_run_neon.h\nindex 69d1b6d..63074f8 100644\n--- a/lib/acl/acl_run_neon.h\n+++ b/lib/acl/acl_run_neon.h\n@@ -2,14 +2,16 @@\n * Copyright(c) 2015 Cavium, Inc\n */\n \n+#include <stdalign.h>\n+\n #include \"acl_run.h\"\n #include \"acl_vect.h\"\n \n-struct _neon_acl_const {\n+alignas(RTE_CACHE_LINE_SIZE) struct _neon_acl_const {\n \trte_xmm_t xmm_shuffle_input;\n \trte_xmm_t xmm_index_mask;\n \trte_xmm_t range_base;\n-} neon_acl_const __rte_cache_aligned = {\n+} neon_acl_const = {\n \t{\n \t\t.u32 = {0x00000000, 0x04040404, 0x08080808, 0x0c0c0c0c}\n \t},\n", "prefixes": [ "v5", "14/39" ] }{ "id": 137122, "url": "