Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137080/?format=api
{ "id": 137080, "url": "http://patches.dpdk.org/api/patches/137080/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240223032155.182162-3-rongweil@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240223032155.182162-3-rongweil@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240223032155.182162-3-rongweil@nvidia.com", "date": "2024-02-23T03:21:55", "name": "[v2,2/2] net/mlx5: fix modify flex item error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3279076107cc5d76a4470d211b9d22d89de42224", "submitter": { "id": 2223, "url": "http://patches.dpdk.org/api/people/2223/?format=api", "name": "Rongwei Liu", "email": "rongweil@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240223032155.182162-3-rongweil@nvidia.com/mbox/", "series": [ { "id": 31192, "url": "http://patches.dpdk.org/api/series/31192/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31192", "date": "2024-02-23T03:21:53", "name": "Fix modify flex item error", "version": 2, "mbox": "http://patches.dpdk.org/series/31192/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137080/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/137080/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1995C43B94;\n\tFri, 23 Feb 2024 04:22:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D00BD4111C;\n\tFri, 23 Feb 2024 04:22:47 +0100 (CET)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2060.outbound.protection.outlook.com [40.107.243.60])\n by mails.dpdk.org (Postfix) with ESMTP id 4A05F410F6;\n Fri, 23 Feb 2024 04:22:46 +0100 (CET)", "from BN9PR03CA0776.namprd03.prod.outlook.com (2603:10b6:408:13a::31)\n by BN9PR12MB5036.namprd12.prod.outlook.com (2603:10b6:408:135::8)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.23; Fri, 23 Feb\n 2024 03:22:43 +0000", "from BN1PEPF0000468D.namprd05.prod.outlook.com\n (2603:10b6:408:13a:cafe::ac) by BN9PR03CA0776.outlook.office365.com\n (2603:10b6:408:13a::31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.43 via Frontend\n Transport; Fri, 23 Feb 2024 03:22:43 +0000", "from mail.nvidia.com (216.228.117.160) by\n BN1PEPF0000468D.mail.protection.outlook.com (10.167.243.138) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7292.25 via Frontend Transport; Fri, 23 Feb 2024 03:22:43 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 22 Feb\n 2024 19:22:21 -0800", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Thu, 22 Feb\n 2024 19:22:15 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Qt7ijBt+Nf7v1Bzup3sbE1bP7V8s0hIUzEg+54lZrN8dFUAOVbiFlbPSbHhNNXyEqdOkyVcqS5alBMmRZB9jHY0rDBTWkReNrLLQtZVy3F7vP2ILOUP7ojMXKLtLPaetr1fSpdNuT2K7dzNViaHqLb6kXhcMzBu+kEsmI9yUZ+dTiA9K3V8rHfCWqJkvahorw+Cs0UMg4eO4yiuaVqsECp6WikW7F4hJxOthSJKAlZB3+aJ8dqdz0SElQYt1eqJaMfArw0uZLAT94G/JNNTvVZ/yZAz9YQizKsZL4Oh7XZyZwOW4vJHCiwM4ZYshnRbDNkbg/TPhiYsVkHTyzrA4Tw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=saCFzZaI1aTLTz0C+9JE7A6oxg2519Z3aLSSZxOwUzc=;\n b=oWrqelphCONShshFPAa054R/XwM5nhYmP4rnL6xQv3BOjfvVXzB7vyUEuqLIvFwGl3TlLxVnoE9Srn78r2xBL5baaPEjrad+s+exsuq2E6os7kIbDhoct4SbgxTz7REXyz4wkxslvh85Ed3ReYhGH3gu2wNg2c2A1Flp5BBD1oyQ/zNcAdYzv0+Dfv+8Mk0ETlVRC2Acj4MN0faR/dkuziC5Q/ieRyrah9wdMv103CGoQ2pvGSojl4FNd8plwcg8ganBU93G2+kQ1BSvSvqJwfACLnX7SguHRBctZI3KyWZb/fNge6qMe6BWHS3HNNkBW5YcqjP8sUGNgMxu3WUOXA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=saCFzZaI1aTLTz0C+9JE7A6oxg2519Z3aLSSZxOwUzc=;\n b=uO1PfM8MX2UdN00+g46C5RNpWfm1fBWGAyKs30ojUcmC5TpP6x1KE+5XIXys5dt7L/tgrco33taC5mTGs/Y9r/nzFqrVMlVB+OazMeKvnkZCbmeWA7Zs7kmf/0hMy4ZS0ftc8J4zHs/t42uTXeuwxlAoU0G+lyXoVMp/CiNBHjncaIbcOWfDRgmElO/HoP4vAqSmI0AsHQ3otMcpg8x4nv+pIrz2nOPYfhDZlYPfBGsEnz1Vw/bg8gSlYqrKfS4k6l16NRnntmyJac4Fca8OzKTbVP2RWXozhVv1cGdbzIb83S5REJBYQ1LkTtnRrGLm1q3fITJHWF4CZoaEy8K9CA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Rongwei Liu <rongweil@nvidia.com>", "To": "<dev@dpdk.org>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,\n <orika@nvidia.com>, <suanmingm@nvidia.com>, <thomas@monjalon.net>", "CC": "<michaelba@nvidia.com>, <stable@dpdk.org>, Dariusz Sosnowski\n <dsosnowski@nvidia.com>", "Subject": "[PATCH v2 2/2] net/mlx5: fix modify flex item error", "Date": "Fri, 23 Feb 2024 05:21:55 +0200", "Message-ID": "<20240223032155.182162-3-rongweil@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20240223032155.182162-1-rongweil@nvidia.com>", "References": "<9698f520-f64c-41ea-8159-52932b96b61b@amd.com>\n <20240223032155.182162-1-rongweil@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN1PEPF0000468D:EE_|BN9PR12MB5036:EE_", "X-MS-Office365-Filtering-Correlation-Id": "03e7ce85-eb0a-4bd3-631d-08dc341eb2db", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n /9i6H51E4+dLw6UXCbI44rj1VYSQCRrAHAJKbVFI1eNRqMgJzDb6auGIzbh1Ye5WTgGFaY/6lKkIdi0ddjI+lcW/Zt4QEizcv5ligg7/UuEtPJzp3GGlp73+jiLQIke90Cg+fNdXwXN87CanXUEqESNI8KaA0BoUGBruNK/ArUkHJt+dvqA9OVABMH+z4blARyeu+GnqZLEePoBfexaeGsiHtC68A/XFSdfGEhIbXcTVYRQmfJSK0Ny+MqvQ6+EYf5KoFsC84gYrvgOQmJzWKBcaSi+8vLorcII0SPPlR33dQbZNdCKGh2d3itPUig2K/1WrJry2nhJmlqoR5hKE6NKctEgOhlLoVYm4wGrER8nSOGNz0AlRsipv25Ew/apFrC+DPoKbTYdWX4vSAkIqQaweri0CgN8l4AJtpCD2/KR4DhOio/F9K5yhunhTuLkTgsJUp/bSVW3YQ6NQjfsIl6feu29r/GSDtm+yHz5OmojI6xemEvWDGUH/zn7+r+BSTg4ljoMjMUFDnh5QhgLNcat/ECl6jVqpuGfN6gjP/42o1ktawmBx5GmyrXI90xs9OF2Ly56Rc+cEMoWAih4B85uPFlMYjp66yrk36/Va6EdUDdxPOXHNBdw4NbxxI9QW/T+NdSI2OMS7sUJrVWeCbyWAtBrCda69L/5gt9wCOPw=", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(36860700004)(46966006)(40470700004); DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Feb 2024 03:22:43.1028 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 03e7ce85-eb0a-4bd3-631d-08dc341eb2db", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN1PEPF0000468D.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN9PR12MB5036", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In the rte_flow_field_data structure, the flex item handle is part\nof union with other members like level/tag_index.\n\nIf the user wants to modify the flex item as source or destination,\nthere should not be any checking against zero.\n\nSigned-off-by: Rongwei Liu <rongweil@nvidia.com>\nFixes: c23626f27b09 (\"ethdev: add MPLS header modification\")\nCc: michaelba@nvidia.com\nCc: stable@dpdk.org\nAcked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 2 +-\n drivers/net/mlx5/mlx5_flow_hw.c | 6 ++++--\n 2 files changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 2b2ae62618..d8ed1ed6f6 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -2384,7 +2384,7 @@ int\n flow_validate_modify_field_level(const struct rte_flow_field_data *data,\n \t\t\t\t struct rte_flow_error *error)\n {\n-\tif (data->level == 0)\n+\tif (data->level == 0 || data->field == RTE_FLOW_FIELD_FLEX_ITEM)\n \t\treturn 0;\n \tif (data->field != RTE_FLOW_FIELD_TAG &&\n \t data->field != (enum rte_flow_field_id)MLX5_RTE_FLOW_FIELD_META_REG)\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex bcf43f5457..5b269b9c82 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -5036,7 +5036,8 @@ flow_hw_validate_action_modify_field(struct rte_eth_dev *dev,\n \tret = flow_validate_modify_field_level(&action_conf->dst, error);\n \tif (ret)\n \t\treturn ret;\n-\tif (!flow_hw_modify_field_is_geneve_opt(action_conf->dst.field)) {\n+\tif (action_conf->dst.field != RTE_FLOW_FIELD_FLEX_ITEM &&\n+\t !flow_hw_modify_field_is_geneve_opt(action_conf->dst.field)) {\n \t\tif (action_conf->dst.tag_index &&\n \t\t !flow_modify_field_support_tag_array(action_conf->dst.field))\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n@@ -5061,7 +5062,8 @@ flow_hw_validate_action_modify_field(struct rte_eth_dev *dev,\n \t\t\t\t\"destination field mask and template are not equal\");\n \tif (action_conf->src.field != RTE_FLOW_FIELD_POINTER &&\n \t action_conf->src.field != RTE_FLOW_FIELD_VALUE) {\n-\t\tif (!flow_hw_modify_field_is_geneve_opt(action_conf->src.field)) {\n+\t\tif (action_conf->src.field != RTE_FLOW_FIELD_FLEX_ITEM &&\n+\t\t !flow_hw_modify_field_is_geneve_opt(action_conf->src.field)) {\n \t\t\tif (action_conf->src.tag_index &&\n \t\t\t !flow_modify_field_support_tag_array(action_conf->src.field))\n \t\t\t\treturn rte_flow_error_set(error, EINVAL,\n", "prefixes": [ "v2", "2/2" ] }