Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/137028/?format=api
{ "id": 137028, "url": "http://patches.dpdk.org/api/patches/137028/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240222122342.16375-2-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240222122342.16375-2-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240222122342.16375-2-pbhagavatula@marvell.com", "date": "2024-02-22T12:23:39", "name": "[24.11,v3,2/5] graph: add node fastpath error counters", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3c9b66f061909e080e7b15857d5fd56293b62e49", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240222122342.16375-2-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 31181, "url": "http://patches.dpdk.org/api/series/31181/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31181", "date": "2024-02-22T12:23:39", "name": "[24.11,v3,1/5] graph: add support for node specific errors", "version": 3, "mbox": "http://patches.dpdk.org/series/31181/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/137028/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/137028/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5793A43B74;\n\tThu, 22 Feb 2024 13:23:59 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 45F3E402CE;\n\tThu, 22 Feb 2024 13:23:59 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 69D15409FA\n for <dev@dpdk.org>; Thu, 22 Feb 2024 13:23:57 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id\n 41M9BMF5021869; Thu, 22 Feb 2024 04:23:56 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3we3dw8j6h-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 22 Feb 2024 04:23:56 -0800 (PST)", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 22 Feb 2024 04:23:54 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 22 Feb 2024 04:23:54 -0800", "from MININT-80QBFE8.corp.innovium.com (unknown [10.28.164.106])\n by maili.marvell.com (Postfix) with ESMTP id BFCD63F71D3;\n Thu, 22 Feb 2024 04:23:51 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=\n pfpt0220; bh=T7I1xto+LXgIR45RR8YCBH3IVze2msLGxo+inOHK2eA=; b=SAb\n qXTb+KOdrxnAmIkEoQCTyGX+emYvVr2h2vcwehEWk0wYGIDt/zHyY2eP+enbfCOm\n ZwqljJVz6ifp65YmpAuPja/7L7clP0CQlv7BKizNuT6TcMdHYvfC9OUs/+fli6rP\n 5bHJEDNSZ6LvbTZ2P01+pY9KNtSd8m/9H7NX4kNn3eGjH5opyYRYYult1/E3EsqF\n xSJCus/kgt5sPGVj5brlBc/8MHGsn3TFbmQLkug6j1/EupvSyso2nSa5DdxVSKXd\n sydNl3mFzKUB0A2VXZMtCg58tXCv49ho5uwS5EJneEoORqWbdLCj+PNmeJHKAPnF\n YAVqudSpWFNSwDtfAGw==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, <ndabilpuram@marvell.com>,\n <kirankumark@marvell.com>,\n <zhirun.yan@intel.com>", "CC": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>", "Subject": "[24.11 PATCH v3 2/5] graph: add node fastpath error counters", "Date": "Thu, 22 Feb 2024 17:53:39 +0530", "Message-ID": "<20240222122342.16375-2-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20240222122342.16375-1-pbhagavatula@marvell.com>", "References": "<20240222053639.15057-1-pbhagavatula@marvell.com>\n <20240222122342.16375-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "H83e7Xpqtx2p9ZBVCS2XmNh4gDYsUe8m", "X-Proofpoint-ORIG-GUID": "H83e7Xpqtx2p9ZBVCS2XmNh4gDYsUe8m", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2024-02-22_09,2024-02-22_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nAdd node fastpath error counters advertised during\nnode registration.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n lib/graph/graph_populate.c | 22 +++++++++++++++++++---\n lib/graph/graph_private.h | 2 ++\n lib/graph/rte_graph_worker_common.h | 1 +\n 3 files changed, 22 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/graph/graph_populate.c b/lib/graph/graph_populate.c\nindex ed596a7711..924f5a3034 100644\n--- a/lib/graph/graph_populate.c\n+++ b/lib/graph/graph_populate.c\n@@ -39,6 +39,15 @@ graph_fp_mem_calc_size(struct graph *graph)\n \t\t/* Pointer to next nodes(edges) */\n \t\tsz += sizeof(struct rte_node *) * graph_node->node->nb_edges;\n \t}\n+\tsz = RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE);\n+\tgraph->errors_start = sz;\n+\t/* For 0..N node objects with error counters */\n+\tSTAILQ_FOREACH (graph_node, &graph->node_list, next) {\n+\t\tif (graph_node->node->errs == NULL)\n+\t\t\tcontinue;\n+\t\tsz = RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE);\n+\t\tsz += sizeof(uint64_t) * graph_node->node->errs->nb_errors;\n+\t}\n \n \tgraph->mem_sz = sz;\n \treturn sz;\n@@ -64,6 +73,7 @@ graph_header_popluate(struct graph *_graph)\n static void\n graph_nodes_populate(struct graph *_graph)\n {\n+\trte_graph_off_t err_off = _graph->errors_start;\n \trte_graph_off_t off = _graph->nodes_start;\n \tstruct rte_graph *graph = _graph->graph;\n \tstruct graph_node *graph_node;\n@@ -99,6 +109,12 @@ graph_nodes_populate(struct graph *_graph)\n \t\t\t\t\t\t ->adjacency_list[count]\n \t\t\t\t\t\t ->node->name[0];\n \n+\t\tif (graph_node->node->errs != NULL) {\n+\t\t\tnode->err_off = err_off - off;\n+\t\t\terr_off += sizeof(uint64_t) * graph_node->node->errs->nb_errors;\n+\t\t\terr_off = RTE_ALIGN(err_off, RTE_CACHE_LINE_SIZE);\n+\t\t}\n+\n \t\toff += sizeof(struct rte_node *) * nb_edges;\n \t\toff = RTE_ALIGN(off, RTE_CACHE_LINE_SIZE);\n \t\tnode->next = off;\n@@ -158,7 +174,7 @@ graph_node_nexts_populate(struct graph *_graph)\n }\n \n static int\n-graph_src_nodes_populate(struct graph *_graph)\n+graph_src_nodes_offset_populate(struct graph *_graph)\n {\n \tstruct rte_graph *graph = _graph->graph;\n \tstruct graph_node *graph_node;\n@@ -193,7 +209,7 @@ graph_fp_mem_populate(struct graph *graph)\n \t\tgraph_pcap_init(graph);\n \tgraph_nodes_populate(graph);\n \trc = graph_node_nexts_populate(graph);\n-\trc |= graph_src_nodes_populate(graph);\n+\trc |= graph_src_nodes_offset_populate(graph);\n \n \treturn rc;\n }\n@@ -228,7 +244,7 @@ graph_nodes_mem_destroy(struct rte_graph *graph)\n \tif (graph == NULL)\n \t\treturn;\n \n-\trte_graph_foreach_node(count, off, graph, node)\n+\trte_graph_foreach_node (count, off, graph, node)\n \t\trte_free(node->objs);\n }\n \ndiff --git a/lib/graph/graph_private.h b/lib/graph/graph_private.h\nindex eb4d461c6e..a185a5a4ea 100644\n--- a/lib/graph/graph_private.h\n+++ b/lib/graph/graph_private.h\n@@ -104,6 +104,8 @@ struct graph {\n \t/**< Memzone to store graph data. */\n \trte_graph_off_t nodes_start;\n \t/**< Node memory start offset in graph reel. */\n+\trte_graph_off_t errors_start;\n+\t/**< Node error memory start offset in graph reel. */\n \trte_node_t src_node_count;\n \t/**< Number of source nodes in a graph. */\n \tstruct rte_graph *graph;\ndiff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h\nindex 4045a7a8dc..b58f37c734 100644\n--- a/lib/graph/rte_graph_worker_common.h\n+++ b/lib/graph/rte_graph_worker_common.h\n@@ -107,6 +107,7 @@ struct rte_node {\n \t\t\tuint64_t total_sched_fail; /**< Number of scheduled failure. */\n \t\t} dispatch;\n \t};\n+\trte_graph_off_t err_off; /**< Offset to error counters. */\n \t/* Fast path area */\n #define RTE_NODE_CTX_SZ 16\n \tuint8_t ctx[RTE_NODE_CTX_SZ] __rte_cache_aligned; /**< Node Context. */\n", "prefixes": [ "24.11", "v3", "2/5" ] }