Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 136923,
    "url": "http://patches.dpdk.org/api/patches/136923/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240220131502.47510-5-fengchengwen@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240220131502.47510-5-fengchengwen@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240220131502.47510-5-fengchengwen@huawei.com",
    "date": "2024-02-20T13:15:02",
    "name": "[4/4] test/argparse: refine testcases",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "c87e139f6d523c8d57f8bad2bfb6a288ea2aefee",
    "submitter": {
        "id": 2146,
        "url": "http://patches.dpdk.org/api/people/2146/?format=api",
        "name": "fengchengwen",
        "email": "fengchengwen@huawei.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240220131502.47510-5-fengchengwen@huawei.com/mbox/",
    "series": [
        {
            "id": 31152,
            "url": "http://patches.dpdk.org/api/series/31152/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31152",
            "date": "2024-02-20T13:15:00",
            "name": "refine argparse library",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/31152/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/136923/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/136923/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6954343B57;\n\tTue, 20 Feb 2024 14:16:58 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0620B406B8;\n\tTue, 20 Feb 2024 14:16:36 +0100 (CET)",
            "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id 6A949402CE\n for <dev@dpdk.org>; Tue, 20 Feb 2024 14:16:30 +0100 (CET)",
            "from mail.maildlp.com (unknown [172.19.88.105])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4TfKdQ0TbhzNlnw;\n Tue, 20 Feb 2024 21:15:06 +0800 (CST)",
            "from dggpeml500024.china.huawei.com (unknown [7.185.36.10])\n by mail.maildlp.com (Postfix) with ESMTPS id 27B6E140154;\n Tue, 20 Feb 2024 21:16:28 +0800 (CST)",
            "from localhost.localdomain (10.50.165.33) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35; Tue, 20 Feb 2024 21:16:27 +0800"
        ],
        "From": "Chengwen Feng <fengchengwen@huawei.com>",
        "To": "<thomas@monjalon.net>, <dev@dpdk.org>",
        "Subject": "[PATCH 4/4] test/argparse: refine testcases",
        "Date": "Tue, 20 Feb 2024 13:15:02 +0000",
        "Message-ID": "<20240220131502.47510-5-fengchengwen@huawei.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20240220131502.47510-1-fengchengwen@huawei.com>",
        "References": "<20240220131502.47510-1-fengchengwen@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.50.165.33]",
        "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n dggpeml500024.china.huawei.com (7.185.36.10)",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Refine testcases, including:\n1. add testcase comment.\n2. argv[0] should set obj->prog_name.\n3. set val_set as NULL in test_argparse_invalid_arg_flags, let it\ntest to the specified code logic.\n4. enable index verification in opt_callback_parse_int_of_no_val.\n\nFixes: 6c5c6571601c (\"argparse: verify argument config\")\nFixes: 31ed9f9f43bb (\"argparse: parse parameters\")\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n app/test/test_argparse.c | 40 +++++++++++++++++++++++++---------------\n 1 file changed, 25 insertions(+), 15 deletions(-)",
    "diff": "diff --git a/app/test/test_argparse.c b/app/test/test_argparse.c\nindex 708a575e16..5be9552aae 100644\n--- a/app/test/test_argparse.c\n+++ b/app/test/test_argparse.c\n@@ -196,11 +196,13 @@ test_argparse_invalid_has_val(void)\n \tuint32_t index;\n \tint ret;\n \n+\t/* test optional arg don't config has-value. */\n \tobj = test_argparse_init_obj();\n \tobj->args[0].flags &= ~0x3ull;\n \tret = rte_argparse_parse(obj, default_argc, default_argv);\n \tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n \n+\t/* test positional arg don't config required-value. */\n \tfor (index = 0; index < RTE_DIM(set_mask); index++) {\n \t\tobj = test_argparse_init_obj();\n \t\tobj->args[0].name_long = \"abc\";\n@@ -268,21 +270,24 @@ test_argparse_invalid_arg_flags(void)\n \tstruct rte_argparse *obj;\n \tint ret;\n \n+\t/* test set unused bits. */\n \tobj = test_argparse_init_obj();\n \tobj->args[0].flags |= ~0x7FFull;\n \tret = rte_argparse_parse(obj, default_argc, default_argv);\n \tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n \n+\t/* test positional arg should not config multiple.  */\n \tobj = test_argparse_init_obj();\n \tobj->args[0].name_long = \"positional\";\n \tobj->args[0].name_short = NULL;\n \tobj->args[0].val_saver = (void *)1;\n-\tobj->args[0].val_set = (void *)1;\n+\tobj->args[0].val_set = NULL;\n \tobj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE | RTE_ARGPARSE_ARG_VALUE_INT |\n \t\t\t     RTE_ARGPARSE_ARG_SUPPORT_MULTI;\n \tret = rte_argparse_parse(obj, default_argc, default_argv);\n \tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n \n+\t/* test optional arg enabled multiple but prased by autosave. */\n \tobj = test_argparse_init_obj();\n \tobj->args[0].flags |= RTE_ARGPARSE_ARG_SUPPORT_MULTI;\n \tret = rte_argparse_parse(obj, default_argc, default_argv);\n@@ -320,13 +325,13 @@ test_argparse_invalid_option(void)\n \tint ret;\n \n \tobj = test_argparse_init_obj();\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"--invalid\");\n \tret = rte_argparse_parse(obj, 2, argv);\n \tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n \n \tobj = test_argparse_init_obj();\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"invalid\");\n \tret = rte_argparse_parse(obj, 2, argv);\n \tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n@@ -350,7 +355,7 @@ test_argparse_opt_autosave_parse_int_of_no_val(void)\n \tobj->args[0].val_set = (void *)100;\n \tobj->args[0].flags = flags;\n \tobj->args[1].name_long = NULL;\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"--test-long\");\n \tret = rte_argparse_parse(obj, 2, argv);\n \tTEST_ASSERT(ret == 0, \"Argparse parse expect success!\");\n@@ -382,7 +387,7 @@ test_argparse_opt_autosave_parse_int_of_required_val(void)\n \tobj->args[0].val_set = NULL;\n \tobj->args[0].flags = flags;\n \tobj->args[1].name_long = NULL;\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"--test-long\");\n \targv[2] = test_strdup(\"100\");\n \tret = rte_argparse_parse(obj, 3, argv);\n@@ -416,6 +421,7 @@ test_argparse_opt_autosave_parse_int_of_optional_val(void)\n \tchar *argv[2];\n \tint ret;\n \n+\t/* test without value. */\n \tobj = test_argparse_init_obj();\n \tobj->args[0].name_long = \"--test-long\";\n \tobj->args[0].name_short = \"-t\";\n@@ -423,7 +429,7 @@ test_argparse_opt_autosave_parse_int_of_optional_val(void)\n \tobj->args[0].val_set = (void *)100;\n \tobj->args[0].flags = flags;\n \tobj->args[1].name_long = NULL;\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"--test-long\");\n \tret = rte_argparse_parse(obj, 2, argv);\n \tTEST_ASSERT(ret == 0, \"Argparse parse expect success!\");\n@@ -467,7 +473,8 @@ test_argparse_opt_autosave_parse_int_of_optional_val(void)\n static int\n opt_callback_parse_int_of_no_val(uint32_t index, const char *value, void *opaque)\n {\n-\tRTE_SET_USED(index);\n+\tif (index != 1)\n+\t\treturn -EINVAL;\n \tif (value != NULL)\n \t\treturn -EINVAL;\n \t*(int *)opaque = 100;\n@@ -488,10 +495,10 @@ test_argparse_opt_callback_parse_int_of_no_val(void)\n \tobj->args[0].name_long = \"--test-long\";\n \tobj->args[0].name_short = \"-t\";\n \tobj->args[0].val_saver = NULL;\n-\tobj->args[0].val_set = (void *)100;\n+\tobj->args[0].val_set = (void *)1;\n \tobj->args[0].flags = RTE_ARGPARSE_ARG_NO_VALUE;\n \tobj->args[1].name_long = NULL;\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"--test-long\");\n \tret = rte_argparse_parse(obj, 2, argv);\n \tTEST_ASSERT(ret == 0, \"Argparse parse expect success!\");\n@@ -542,7 +549,7 @@ test_argparse_opt_callback_parse_int_of_required_val(void)\n \tobj->args[0].val_set = (void *)1;\n \tobj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE;\n \tobj->args[1].name_long = NULL;\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"--test-long\");\n \targv[2] = test_strdup(\"100\");\n \tret = rte_argparse_parse(obj, 3, argv);\n@@ -606,7 +613,7 @@ test_argparse_opt_callback_parse_int_of_optional_val(void)\n \tobj->args[0].val_set = (void *)1;\n \tobj->args[0].flags = RTE_ARGPARSE_ARG_OPTIONAL_VALUE;\n \tobj->args[1].name_long = NULL;\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"--test-long\");\n \tret = rte_argparse_parse(obj, 2, argv);\n \tTEST_ASSERT(ret == 0, \"Argparse parse expect success!\");\n@@ -651,6 +658,7 @@ test_argparse_pos_autosave_parse_int(void)\n \tchar *argv[3];\n \tint ret;\n \n+\t/* test positional autosave parse successful. */\n \tobj = test_argparse_init_obj();\n \tobj->args[0].name_long = \"test-long\";\n \tobj->args[0].name_short = NULL;\n@@ -658,19 +666,20 @@ test_argparse_pos_autosave_parse_int(void)\n \tobj->args[0].val_set = NULL;\n \tobj->args[0].flags = flags;\n \tobj->args[1].name_long = NULL;\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"100\");\n \tret = rte_argparse_parse(obj, 2, argv);\n \tTEST_ASSERT(ret == 0, \"Argparse parse expect success!\");\n \tTEST_ASSERT(val_saver == 100, \"Argparse parse expect success!\");\n \n+\t/* test positional autosave parse failed. */\n \tobj->args[0].flags = flags;\n \tval_saver = 0;\n \targv[1] = test_strdup(\"100a\");\n \tret = rte_argparse_parse(obj, 2, argv);\n \tTEST_ASSERT(ret == -EINVAL, \"Argparse parse expect failed!\");\n \n-\t/* test over position parameters. */\n+\t/* test too much position parameters. */\n \tobj->args[0].flags = flags;\n \targv[1] = test_strdup(\"100\");\n \targv[2] = test_strdup(\"200\");\n@@ -708,6 +717,7 @@ test_argparse_pos_callback_parse_int(void)\n \tchar *argv[3];\n \tint ret;\n \n+\t/* test positional callback parse successful. */\n \tobj = test_argparse_init_obj();\n \tobj->callback = pos_callback_parse_int;\n \tobj->opaque = (void *)val_saver;\n@@ -722,7 +732,7 @@ test_argparse_pos_callback_parse_int(void)\n \tobj->args[1].val_set = (void *)2;\n \tobj->args[1].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE;\n \tobj->args[2].name_long = NULL;\n-\targv[0] = test_strdup(obj->usage);\n+\targv[0] = test_strdup(obj->prog_name);\n \targv[1] = test_strdup(\"100\");\n \targv[2] = test_strdup(\"200\");\n \tret = rte_argparse_parse(obj, 3, argv);\n@@ -730,7 +740,7 @@ test_argparse_pos_callback_parse_int(void)\n \tTEST_ASSERT(val_saver[1] == 100, \"Argparse parse expect success!\");\n \tTEST_ASSERT(val_saver[2] == 200, \"Argparse parse expect success!\");\n \n-\t/* test callback return failed. */\n+\t/* test positional callback parse failed. */\n \tobj->args[0].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE;\n \tobj->args[1].flags = RTE_ARGPARSE_ARG_REQUIRED_VALUE;\n \targv[2] = test_strdup(\"200a\");\n",
    "prefixes": [
        "4/4"
    ]
}