Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136888/?format=api
{ "id": 136888, "url": "http://patches.dpdk.org/api/patches/136888/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240220081451.2640526-2-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240220081451.2640526-2-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240220081451.2640526-2-chaoyong.he@corigine.com", "date": "2024-02-20T08:14:50", "name": "[1/2] net/nfp: fix meta data process problem of NFD3", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3789057721dd976dd964cb795327dc39827c7289", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240220081451.2640526-2-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 31144, "url": "http://patches.dpdk.org/api/series/31144/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31144", "date": "2024-02-20T08:14:49", "name": "fix meta data process problem", "version": 1, "mbox": "http://patches.dpdk.org/series/31144/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136888/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136888/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BEACF43B51;\n\tTue, 20 Feb 2024 09:15:22 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C660140648;\n\tTue, 20 Feb 2024 09:15:17 +0100 (CET)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2137.outbound.protection.outlook.com [40.107.93.137])\n by mails.dpdk.org (Postfix) with ESMTP id 0FFF04029B;\n Tue, 20 Feb 2024 09:15:16 +0100 (CET)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by BY5PR13MB3874.namprd13.prod.outlook.com (2603:10b6:a03:220::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39; Tue, 20 Feb\n 2024 08:15:14 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::8e02:f738:570a:f8aa]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::8e02:f738:570a:f8aa%7]) with mapi id 15.20.7292.036; Tue, 20 Feb 2024\n 08:15:14 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=C46gzAHnUBAoRKyvay+mnZq/oxqDrNInO3VP7nKRw+dOnCD1vLdnTYWKFgAvOqMnSlMH3Zv5rctPmeLLkOIw8mjcHmJtzVj3xytvwA/lA7yBpEhc2cRqku6kA7hXe6Fo594pAVuPSQVKdyGO8sJh/TZEzUN1Dgdj43UKAgA/Y7yd0dMUIjS9JANrWh4ejUPtu4wAmiwR7oJS/UFxhvmZOsVSfMJwwEAwL9QwYMkEBt2zB8vSC+ZUcYikxeXeELxH4RQwHwRdLNmPGuc1weIYVNTZfebGCBoR4zpKjbZ4DTs//2bLAon891ognFNVr6t1fQUG2v1m9WCp2m5RbFUuBg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=buy09BmHPhqq1Xzj9YrFQjCPn0FWhGxzmfW1ry6Wf64=;\n b=Rmgpqz+IHbsizYmKZC6/NDWK7xSanPxhoWRohDKjsdSogz6551gS0qhTz62iJLId0nVeBYgQ0a7M4UaXV3a5L6EljrkEOG+RtbbFC5dQD3Z1Sw0yfiWwDCaUvjT62OX3wf5HZYl4q0LwhQWzOj7v+d4Tq64EQGGyPCCldPDY7AmNZ8mEWIvwuxUOnPyN1oNrUNbjZvp76aXKnu9EtBUbJB6zXzrlY/BsucCw+h0wy5SiR4HLdw3A7ZMs3dAXDAspP5ttdbGtZ+YW5GwozuaQNy/M+nBoiQdxlI92GilSZ95VFJvVO78bljaUrtrMgB0J6A1dEzkD4S1DrXK9nkB4/A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=buy09BmHPhqq1Xzj9YrFQjCPn0FWhGxzmfW1ry6Wf64=;\n b=kS4kh/Coulof3VvdnznkiBAUti5MvECtRC6DPZyRHS/gXeyM9uOqUBDG1NlK9Cu8Q0TKFleuotJM6me/Lhxf5Leg8XIYbJsk9WCTfUU4Cn/8FXKAzV9jRoSTGgqIVPiIEUU6vDIa4NAyHBrttJozWuo7PZQXQaklrLjskmJyUeA=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n peng.zhang@corigine.com, stable@dpdk.org, Long Wu <long.wu@corigine.com>", "Subject": "[PATCH 1/2] net/nfp: fix meta data process problem of NFD3", "Date": "Tue, 20 Feb 2024 16:14:50 +0800", "Message-Id": "<20240220081451.2640526-2-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20240220081451.2640526-1-chaoyong.he@corigine.com>", "References": "<20240220081451.2640526-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SJ0PR13CA0206.namprd13.prod.outlook.com\n (2603:10b6:a03:2c3::31) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|BY5PR13MB3874:EE_", "X-MS-Office365-Filtering-Correlation-Id": "25bcd121-93ba-4514-51e4-08dc31ec10db", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n GRMMoG8HhgKIs+NMXCWehndS7YaAmlWVyuH4CS+SKPMmKzUJRPor8AGSSk8yIrysZ/ryfamEDdCoPMNkWqcPJLaxE2TdxnOVVrt/lyPNCUzZ95eAwPkLOqshAR8CaDJvG6BVz4H3k7cuBc9pvCw92y6QmDD2GvX/Mb28iaqvc5llk0/NL3RYbIUeKXDo3332YUcxfqtJZPbarp7B2yVp4eLjNqcqSxEbJGiKeWxjpgpnfEiSksvHFuUBvA8wvrXly6c8odGuWJGyqad11XSwH+GVOj1IZ/jcw49slGE5vt0f2i9k4281XhmqCIKb1GbUFiCAtSxwa4KpJ/LpTuOCBWAX53mYxCFnrncb7+9uymrbDOSd6GZNKd7t9EGWWv17S3nHIcNgzk8nwhh6j/7mogxPOnsv135VbKWs9QlfMvvHFkXySFBi45EBc3fuRios18emj+VxrftVJFbRZDg9oZ3YWoiY9Q5CbIKfS3tzGp4iQXPIA3gmmzTiuqa5olh/rU19e3icuWe2dDA0zR0dl1Yr9dOpQS2DQCU9d5jxI5Ih7cCykeQqTSOYDEkCwthbsNxL0thdc6gnt38+xVlqApQ6gzHDfxwNYj5FSYELUQIR7Lh4kerhcwQicaq1fUYA", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(38350700005); DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n 0CJOMgMcZt3e2qfdcLaTAkjOoOUVV9kavhL1BzC9dK0Fr7DvJ97Vj+AOwoh2vCfCso0oBWMKd1peSDN3Bg5TsDkkkotHHouD8JAV4GN+EcHCdowGdYqA+pEagqp/xp+59DSj/R9SklkMMvjIYnaUdmdsjHuSZ2vIKE3Hz4U95vcZNMvAtZCusSDvnFbJ+qezD/jzc2+ogwEAY7xL8/odszHGFf6FnPvbsTjB6c+kWgq5bda1IXK9mxelqqzuVOty0hvnxvNcCQlawzDxsT1KfuymWzAWWGv5ct1nEWnCyAGxYJ9iYcTGoYfatBx786Utb3o8g046C1CmPPluqPE4X0oiu+T8nck4cDsvXqzRJlIZXJhPhcyfk4yf2iA9fQIXtDx367uRc9iLF/+TjM8oeUV9U0nMQ04Y+wK7mitiNTWr1OvbfQr5XvIxPndNiCv7+KUwMsVF+6F5JiNvyLgSH7dPrGtWWstXnPDOmHWQSkWcjgxvi4Vc0JfZZyL3DGTE4GtXwKXBxvhQSe+4MjvG61/TofYRM3np4X9jZR3Ea2ZxJSIEgWhfNQsRKE4y8RiwcrgyadKY6cEvjeUk+hKVY69RwRUsBeSdsh7dSPrYCJk6jFZgiQR/ArcnkQGTLq7DKsJTEs6+IPAzq32Ho6vjMcsXMGpmjW+IwwL4a/2tk+BgHApSdwVOncsa+iSvfytcWWCoXVXS0SfdhIzyekYQyNY3hIKdKWswECtwR7BWeP/3EPpsOLJ4ae3Z/ewodPKJMTuLvzyjmJBWE/XTNXPjuHWuNnoomG4F7+88Aqov+0lfmHwu8D/AelbYDGtwkbGYxoPpM3dXFtP8qVzw/tV2krAdNxJMOU7cqz6JVIjMcgQUGZdx8JyOjuEAydxT55dOXzvP0tJb1iurM5M8J5zAjev2thW5dgpJ1pIf1/+uQ+51HEF7YIzglxgme/ATUup31Ckz9zf9hMBqb+4xocqOJ7oSCYSm9G/Y+Eds+6M1Tx8grD/KWQwxfWJAojstfUX+Yl0i2QsRVggGSKoULWrDVRtUIkF3a4jl2jvL+I8qMUNZUrBdTQfDq2Yk/EyZRcXEbZYEKIWEHnMq7bXtvA0CD94g8EBN3qh36Cr70Jq3JNO4+iv9Is2TXZvGboHwBwanzdi9fGlbIfCodmJDh+zVSOj+X22ag4xkh8kOIu0HPhensH5cDs86yEC1Iq6j943S8NcCWgGdN2JPFZiQd8+ovHXUJOvCZJ/FRGC1LnwdrEbt9JLUpATzcMTWCbdT3jnoSqCHvJeAm4m51OFkDMoefQTqAnKQ4XtFgY2SqLHJkEACwXWGRHCjIvBHYSO1mHNtLud6JgL/3D7h/EEECG2CvbIJS++XEjX9FAjuuRH0TtBphTdidvOkInGEsrapze7G3gWx9kxfiC52Q2MyVKxyTaHOMEvioGGlEIo59X1uqiFbg+jEynHyoYV49ZagZN74EvZGXnkU5Ig6U/wjpDORj2zXTUyfJrPFC2Ztod5BkliMSrZIT58J4Z8RuTLjZFBlEPhjxGFs+QTgyL3c4On87dgq12WlFtoPDjFxzvcdYAT0touYya9O2RmTtvooC9koktVnwv+gnoi7S/H+2tiJnA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 25bcd121-93ba-4514-51e4-08dc31ec10db", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Feb 2024 08:15:14.7203 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n vWwFu8Kf/tKfZVWBtROja7NlfZSgg8nS5M/XN/kgeIamyH4VTeSKHizfqqoYo2XERaOareaHBX/vqwQhUtwzdVXoBiZIJuxZkjiuvWgvA80=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR13MB3874", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The Tx function can not check if the meta data process success for\nthe process function with void return type.\n\nFix it by change the return type of the meata data function from\nvoid to integer and add the error handle logic in the Tx function.\n\nFixes: 962791ba6804 (\"net/nfp: support VLAN insert with NFD3\")\nCc: peng.zhang@corigine.com\nCc: stable@dpdk.org\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 19 +++++++++++++------\n 1 file changed, 13 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfd3/nfp_nfd3_dp.c b/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\nindex ee120f55ab..be31f4ac33 100644\n--- a/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\n+++ b/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\n@@ -142,7 +142,7 @@ nfp_net_nfd3_tx_vlan(struct nfp_net_txq *txq,\n \t}\n }\n \n-static inline void\n+static inline int\n nfp_net_nfd3_set_meta_data(struct nfp_net_meta_raw *meta_data,\n \t\tstruct nfp_net_txq *txq,\n \t\tstruct rte_mbuf *pkt)\n@@ -177,7 +177,7 @@ nfp_net_nfd3_set_meta_data(struct nfp_net_meta_raw *meta_data,\n \t}\n \n \tif (meta_data->length == 0)\n-\t\treturn;\n+\t\treturn 0;\n \n \tmeta_info = meta_data->header;\n \tmeta_data->header = rte_cpu_to_be_32(meta_data->header);\n@@ -191,15 +191,16 @@ nfp_net_nfd3_set_meta_data(struct nfp_net_meta_raw *meta_data,\n \t\tcase NFP_NET_META_VLAN:\n \t\t\tif (vlan_layer > 0) {\n \t\t\t\tPMD_DRV_LOG(ERR, \"At most 1 layers of vlan is supported\");\n-\t\t\t\treturn;\n+\t\t\t\treturn -EINVAL;\n \t\t\t}\n+\n \t\t\tnfp_net_set_meta_vlan(meta_data, pkt, layer);\n \t\t\tvlan_layer++;\n \t\t\tbreak;\n \t\tcase NFP_NET_META_IPSEC:\n \t\t\tif (ipsec_layer > 2) {\n \t\t\t\tPMD_DRV_LOG(ERR, \"At most 3 layers of ipsec is supported for now.\");\n-\t\t\t\treturn;\n+\t\t\t\treturn -EINVAL;\n \t\t\t}\n \n \t\t\tnfp_net_set_meta_ipsec(meta_data, txq, pkt, layer, ipsec_layer);\n@@ -207,11 +208,13 @@ nfp_net_nfd3_set_meta_data(struct nfp_net_meta_raw *meta_data,\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tPMD_DRV_LOG(ERR, \"The metadata type not supported\");\n-\t\t\treturn;\n+\t\t\treturn -ENOTSUP;\n \t\t}\n \n \t\tmemcpy(meta, &meta_data->data[layer], sizeof(meta_data->data[layer]));\n \t}\n+\n+\treturn 0;\n }\n \n uint16_t\n@@ -228,6 +231,7 @@ nfp_net_nfd3_xmit_pkts_common(void *tx_queue,\n \t\tuint16_t nb_pkts,\n \t\tbool repr_flag)\n {\n+\tint ret;\n \tuint16_t i;\n \tuint8_t offset;\n \tuint32_t pkt_size;\n@@ -274,7 +278,10 @@ nfp_net_nfd3_xmit_pkts_common(void *tx_queue,\n \t\tif (!repr_flag) {\n \t\t\tstruct nfp_net_meta_raw meta_data;\n \t\t\tmemset(&meta_data, 0, sizeof(meta_data));\n-\t\t\tnfp_net_nfd3_set_meta_data(&meta_data, txq, pkt);\n+\t\t\tret = nfp_net_nfd3_set_meta_data(&meta_data, txq, pkt);\n+\t\t\tif (unlikely(ret != 0))\n+\t\t\t\tgoto xmit_end;\n+\n \t\t\toffset = meta_data.length;\n \t\t} else {\n \t\t\toffset = FLOWER_PKT_DATA_OFFSET;\n", "prefixes": [ "1/2" ] }