Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136854/?format=api
{ "id": 136854, "url": "http://patches.dpdk.org/api/patches/136854/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240216170704.55523-3-andrew.boyer@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240216170704.55523-3-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240216170704.55523-3-andrew.boyer@amd.com", "date": "2024-02-16T17:07:03", "name": "[2/3] net/ionic: remove duplicate barriers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "96272e8a9548ab61afc0239afe6056e079372c74", "submitter": { "id": 2861, "url": "http://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240216170704.55523-3-andrew.boyer@amd.com/mbox/", "series": [ { "id": 31131, "url": "http://patches.dpdk.org/api/series/31131/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31131", "date": "2024-02-16T17:07:01", "name": "net/ionic, common/ionic: add vdev support", "version": 1, "mbox": "http://patches.dpdk.org/series/31131/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136854/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136854/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8A34543B31;\n\tFri, 16 Feb 2024 18:07:54 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C5135406B6;\n\tFri, 16 Feb 2024 18:07:52 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2066.outbound.protection.outlook.com [40.107.220.66])\n by mails.dpdk.org (Postfix) with ESMTP id 84E75406B6\n for <dev@dpdk.org>; Fri, 16 Feb 2024 18:07:51 +0100 (CET)", "from MW4PR03CA0133.namprd03.prod.outlook.com (2603:10b6:303:8c::18)\n by PH7PR12MB6980.namprd12.prod.outlook.com (2603:10b6:510:1ba::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.27; Fri, 16 Feb\n 2024 17:07:46 +0000", "from MWH0EPF000989E8.namprd02.prod.outlook.com\n (2603:10b6:303:8c:cafe::77) by MW4PR03CA0133.outlook.office365.com\n (2603:10b6:303:8c::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.40 via Frontend\n Transport; Fri, 16 Feb 2024 17:07:46 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n MWH0EPF000989E8.mail.protection.outlook.com (10.167.241.135) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7292.25 via Frontend Transport; Fri, 16 Feb 2024 17:07:46 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 16 Feb\n 2024 11:07:45 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=X/QeCJXID3L2Y+AY4KkdIJiAOEu/xR/qGSSqT5mzIhztfUbB5JyHkq22u1XRMtPIbzLEZSHzVPHmcPETE7kNGr3Qmr4puGyi94/UhcmdI1cjGzJbNaIctDNuMwdtCeSrkprdexTB7RjB+spj5EQglOMwdns0XGmI9rZPUuwa+8oC33jMrY8yUpCZnxpgcL+VmwqqLuLvmGrxcXRfUAbm05nDsf7D63HfhgV9QzYS2A5eW/dp7NkJT/ztfcqipCa2WxkUIXk08Vfsf+OqgIPVpmV/nMgERVVYighba1Xige4MIEPKgiAR/fkqtI6SQ0GhWz+dAWF96s6cPCCmQD5rOw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=6g9GZ2x3w2Lw+ONBuh26YIywhch60weTTQayx+Tr5CM=;\n b=lb4wxBq2xdUQu2dL5Pr/6P6RqB3BC5eN7+hsaU+Ydmir5XIEhFgTLDAIcs25x/p4ueTMWh21DwHjN0AHm7i2g96Wd2OTdEpk/7K1i2UdEEGpqPRX2rc/vc7A5vdWl2VoP34Ri8wAaM0SeKvIK99j19LB//P0/1QxqeG3VYX/yJkMN2CfbsncKSvbD/jQVOyL8Qp3v5Bz4qj50JnpbwTZ+s80o2QpnHR6xmE3TG/YRTRGDXVpFNPqV5WEcfnj9qgV/Fw6VcfTYxc7lWMSxDxOUE3WCdgQzLkx/4KL5Evb0enXFuWuYC/mY6dfsxz7BMby17tFw7XLc9Wn+4CzapaK5A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6g9GZ2x3w2Lw+ONBuh26YIywhch60weTTQayx+Tr5CM=;\n b=UBGhvDPYyG+c8JvDcO9t92YMuGBlPsVvVaABajO+TWXBQ7PhGCbeSKBQ9RB+PQ3GZqOsnJtUxRjCJdni64vB3jhPGBb8Z53rYtHpU75WFSfqWCvmF132EpUj97GAofGXc1tO4fNOxQJKyFYpo60LWpCl1oQMFzz55bbyUowFjzo=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>, Neel Patel <neel.patel@amd.com>", "Subject": "[PATCH 2/3] net/ionic: remove duplicate barriers", "Date": "Fri, 16 Feb 2024 09:07:03 -0800", "Message-ID": "<20240216170704.55523-3-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240216170704.55523-1-andrew.boyer@amd.com>", "References": "<20240216170704.55523-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MWH0EPF000989E8:EE_|PH7PR12MB6980:EE_", "X-MS-Office365-Filtering-Correlation-Id": "52cec93f-87dc-479c-5a26-08dc2f11cc21", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 7+9cDM4+ZCcv00jiokXO0Yx6XzwE0688EcWQkuKQov8e+UtS3OPn7aR6WmQi8+sym/a6PtW3HnrvYL8oem1bfqad+dWE1ZjPfKO+Q4GTIDPODGy5srsJ9KvEynGiIstdRCimsKO3ofXMfgGD+Xn7UhDTyIyBVxgm8msbe3vitbPFoKrBgtZQ+aB41ACuz6toK8zmfTVWMA7e0aoDOBWari7QIqLQqXOMUNYRB/CkGWxq1a+bMs6AUHHLrnmwQCL7hseftU4Y1EANXBud4qZb1Ld03zwb7ho78eLD7AKfYo7VtoYf8fBeFCA5/fJgXsml+cTaG89gVrVcItq0k85hLskD/qoMu8d14G8i/Ogo9tzTv3tnxQw8O0AoVVdo1gfZ4JMABm7+Mln2qVLD5ao7FwFj34JNghWfxIG6bzMGyQn6nQoYGb89QOvMbaz/85Cu/0u2xuZUZHqCfuzsQwkt/nxY0MZbYNnX8a3GXf1M0OpLwupL/DU1/W0drJ96c5qoLyKZbPgSjnIIOv02+FkOkw/47CkLhMH/dG2DXYFkGNSRhaM206kp3V4HPtWp2PaYqI3vfVpq5GwBYTuh/TcQwi1tKE5tISsYV+SukgSx6VdfmfXZ6OSutB2Z/9OlQgQbK2Zkb3JZ1CpZMP8AW2dvBrLIH84K3/HIe4allzpBAcg=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(136003)(39860400002)(396003)(376002)(346002)(230922051799003)(1800799012)(82310400011)(186009)(451199024)(36860700004)(64100799003)(40470700004)(46966006)(2906002)(5660300002)(44832011)(8936002)(4326008)(8676002)(41300700001)(86362001)(82740400003)(83380400001)(81166007)(356005)(54906003)(36756003)(2616005)(6916009)(426003)(1076003)(6666004)(70206006)(16526019)(70586007)(478600001)(336012)(26005)(316002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 Feb 2024 17:07:46.4048 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 52cec93f-87dc-479c-5a26-08dc2f11cc21", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n MWH0EPF000989E8.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR12MB6980", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "These barriers are duplicated by the barriers inside\nrte_write64(). Remove them to improve performance.\n\nSigned-off-by: Neel Patel <neel.patel@amd.com>\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_main.c | 1 -\n drivers/net/ionic/ionic_rxtx_sg.c | 1 -\n drivers/net/ionic/ionic_rxtx_simple.c | 1 -\n 3 files changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c\nindex 1f24f64a33..814bb3b8f4 100644\n--- a/drivers/net/ionic/ionic_main.c\n+++ b/drivers/net/ionic/ionic_main.c\n@@ -223,7 +223,6 @@ ionic_adminq_post(struct ionic_lif *lif, struct ionic_admin_ctx *ctx)\n \tq->head_idx = Q_NEXT_TO_POST(q, 1);\n \n \t/* Ring doorbell */\n-\trte_wmb();\n \tionic_q_flush(q);\n \n err_out:\ndiff --git a/drivers/net/ionic/ionic_rxtx_sg.c b/drivers/net/ionic/ionic_rxtx_sg.c\nindex e8dec99c04..3820fd850f 100644\n--- a/drivers/net/ionic/ionic_rxtx_sg.c\n+++ b/drivers/net/ionic/ionic_rxtx_sg.c\n@@ -218,7 +218,6 @@ ionic_xmit_pkts_sg(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t}\n \n \tif (nb_tx > 0) {\n-\t\trte_wmb();\n \t\tionic_txq_flush(q);\n \n \t\ttxq->last_wdog_cycles = rte_get_timer_cycles();\ndiff --git a/drivers/net/ionic/ionic_rxtx_simple.c b/drivers/net/ionic/ionic_rxtx_simple.c\nindex 9674b4d1df..4c9b9415ad 100644\n--- a/drivers/net/ionic/ionic_rxtx_simple.c\n+++ b/drivers/net/ionic/ionic_rxtx_simple.c\n@@ -191,7 +191,6 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t}\n \n \tif (nb_tx > 0) {\n-\t\trte_wmb();\n \t\tionic_txq_flush(q);\n \n \t\ttxq->last_wdog_cycles = rte_get_timer_cycles();\n", "prefixes": [ "2/3" ] }