Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136807/?format=api
http://patches.dpdk.org/api/patches/136807/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1707978080-28859-9-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707978080-28859-9-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707978080-28859-9-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-15T06:21:10", "name": "[v4,08/18] net/sfc: stop using zero sized marker fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d16c48baf4762ade8e361d49b3e2506e460f47e2", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1707978080-28859-9-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31113, "url": "http://patches.dpdk.org/api/series/31113/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31113", "date": "2024-02-15T06:21:02", "name": "stop using zero sized marker fields", "version": 4, "mbox": "http://patches.dpdk.org/series/31113/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136807/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136807/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9632843B06;\n\tThu, 15 Feb 2024 07:22:30 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C7FAE433BC;\n\tThu, 15 Feb 2024 07:21:48 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id D22D04338A\n for <dev@dpdk.org>; Thu, 15 Feb 2024 07:21:37 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 780AB20B2001; Wed, 14 Feb 2024 22:21:36 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 780AB20B2001", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707978096;\n bh=mo1dy4TZyp68OHPtuhu7OQkyG3B9B6++kxsvz/sSA6o=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=EFnbYH0DZy8C5QhER8TPTYjRxiCftHSwjNEKmrZnoVyaMdbSA3W/tZZDMrntAuXKG\n bzcLs2VrBN/9NLW9GZzrANedW3qT2As4SWATHa5EnPJyFHBCEGBxA4lEJbdPlTGIvq\n JH1u2xFPjSCnI+ahOx3cqelDMySNILE1A8nFIR44=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Andrew Boyer <andrew.boyer@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbox@nvidia.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n Hyong Youb Kim <hyonkim@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jie Hai <haijie1@huawei.com>, Jingjing Wu <jingjing.wu@intel.com>,\n John Daley <johndale@cisco.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Satha Rao <skoteshwar@marvell.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Yuying Zhang <Yuying.Zhang@intel.com>, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 08/18] net/sfc: stop using zero sized marker fields", "Date": "Wed, 14 Feb 2024 22:21:10 -0800", "Message-Id": "<1707978080-28859-9-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com>\n <1707978080-28859-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Update to reference newly named anonymous union markers supported by\nstandard C and stop referencing zero sized compiler extension markers.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n drivers/net/sfc/sfc_ef100_rx.c | 10 +++++-----\n drivers/net/sfc/sfc_ef10_rx.c | 14 +++++++-------\n 2 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c\nindex 2677003..b316a6d 100644\n--- a/drivers/net/sfc/sfc_ef100_rx.c\n+++ b/drivers/net/sfc/sfc_ef100_rx.c\n@@ -553,9 +553,9 @@ struct sfc_ef100_rxq {\n \t\tpkt = sfc_ef100_rx_next_mbuf(rxq);\n \t\t__rte_mbuf_raw_sanity_check(pkt);\n \n-\t\tRTE_BUILD_BUG_ON(sizeof(pkt->rearm_data[0]) !=\n+\t\tRTE_BUILD_BUG_ON(sizeof(pkt->mbuf_rearm_data) !=\n \t\t\t\t sizeof(rxq->rearm_data));\n-\t\tpkt->rearm_data[0] = rxq->rearm_data;\n+\t\t*(uint64_t *)&pkt->mbuf_rearm_data[0] = rxq->rearm_data;\n \n \t\t/* data_off already moved past Rx prefix */\n \t\trx_prefix = (const efx_xword_t *)sfc_ef100_rx_pkt_prefix(pkt);\n@@ -757,10 +757,10 @@ struct sfc_ef100_rxq {\n \tm.nb_segs = 1;\n \tm.port = port_id;\n \n-\t/* rearm_data covers structure members filled in above */\n+\t/* mbuf_rearm_data covers structure members filled in above */\n \trte_compiler_barrier();\n-\tRTE_BUILD_BUG_ON(sizeof(m.rearm_data[0]) != sizeof(uint64_t));\n-\treturn m.rearm_data[0];\n+\tRTE_BUILD_BUG_ON(sizeof(m.mbuf_rearm_data) != sizeof(uint64_t));\n+\treturn *(uint64_t *)&m.mbuf_rearm_data[0];\n }\n \n static sfc_dp_rx_qcreate_t sfc_ef100_rx_qcreate;\ndiff --git a/drivers/net/sfc/sfc_ef10_rx.c b/drivers/net/sfc/sfc_ef10_rx.c\nindex 30a320d..7b9103c 100644\n--- a/drivers/net/sfc/sfc_ef10_rx.c\n+++ b/drivers/net/sfc/sfc_ef10_rx.c\n@@ -322,8 +322,8 @@ struct sfc_ef10_rxq {\n \n \tm = rxd->mbuf;\n \n-\tRTE_BUILD_BUG_ON(sizeof(m->rearm_data[0]) != sizeof(rxq->rearm_data));\n-\tm->rearm_data[0] = rxq->rearm_data;\n+\tRTE_BUILD_BUG_ON(sizeof(m->mbuf_rearm_data) != sizeof(rxq->rearm_data));\n+\t*(uint64_t *)&m->mbuf_rearm_data[0] = rxq->rearm_data;\n \n \t/* Classify packet based on Rx event */\n \t/* Mask RSS hash offload flag if RSS is not enabled */\n@@ -377,9 +377,9 @@ struct sfc_ef10_rxq {\n \t\t\trxq->completed = pending;\n \t\t}\n \n-\t\tRTE_BUILD_BUG_ON(sizeof(m->rearm_data[0]) !=\n+\t\tRTE_BUILD_BUG_ON(sizeof(m->mbuf_rearm_data) !=\n \t\t\t\t sizeof(rxq->rearm_data));\n-\t\tm->rearm_data[0] = rxq->rearm_data;\n+\t\t*(uint64_t *)&m->mbuf_rearm_data[0] = rxq->rearm_data;\n \n \t\t/* Event-dependent information is the same */\n \t\tm->ol_flags = m0->ol_flags;\n@@ -631,10 +631,10 @@ struct sfc_ef10_rxq {\n \tm.nb_segs = 1;\n \tm.port = port_id;\n \n-\t/* rearm_data covers structure members filled in above */\n+\t/* mbuf_rearm_data covers structure members filled in above */\n \trte_compiler_barrier();\n-\tRTE_BUILD_BUG_ON(sizeof(m.rearm_data[0]) != sizeof(uint64_t));\n-\treturn m.rearm_data[0];\n+\tRTE_BUILD_BUG_ON(sizeof(m.mbuf_rearm_data) != sizeof(uint64_t));\n+\treturn *(uint64_t *)&m.mbuf_rearm_data[0];\n }\n \n static sfc_dp_rx_qcreate_t sfc_ef10_rx_qcreate;\n", "prefixes": [ "v4", "08/18" ] }{ "id": 136807, "url": "