Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136763/?format=api
{ "id": 136763, "url": "http://patches.dpdk.org/api/patches/136763/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1707928564-28796-12-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707928564-28796-12-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707928564-28796-12-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-14T16:35:36", "name": "[v4,11/39] ethdev: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "754d7b455884cc281bdd473d2ca155486cfea8fd", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1707928564-28796-12-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31107, "url": "http://patches.dpdk.org/api/series/31107/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31107", "date": "2024-02-14T16:35:25", "name": "use C11 alignas and normalize type alignment", "version": 4, "mbox": "http://patches.dpdk.org/series/31107/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136763/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136763/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8226343B38;\n\tWed, 14 Feb 2024 17:37:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3198442F7D;\n\tWed, 14 Feb 2024 17:36:21 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id CA15842B71\n for <dev@dpdk.org>; Wed, 14 Feb 2024 17:36:07 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 779E020B200B; Wed, 14 Feb 2024 08:36:06 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 779E020B200B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707928566;\n bh=ZpomPayVC9Q0RdLnom0uLzofLMVwSTsxNCVqzblWH0U=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=FDcY+bvxufMWh0E410uwCzCCCSRgzWk9eV85nV0viFMwbVBea1TG6qI9Kf0kXFjJN\n rAvX5eSdmFxs1hCa1T4u1JRUdCmAvC2xeImqsldmT+sJenc0BQALnDdcHd3cFvnpd9\n OsOiC6cQX1nfHs8OKp7gEiPOmWU3KwHl/1MEtKIU=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 11/39] ethdev: use C11 alignas", "Date": "Wed, 14 Feb 2024 08:35:36 -0800", "Message-Id": "<1707928564-28796-12-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707928564-28796-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1707928564-28796-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/ethdev/ethdev_driver.h | 8 ++++----\n lib/ethdev/rte_ethdev.h | 16 ++++++++--------\n lib/ethdev/rte_ethdev_core.h | 4 ++--\n 3 files changed, 14 insertions(+), 14 deletions(-)", "diff": "diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h\nindex b482cd1..2edad71 100644\n--- a/lib/ethdev/ethdev_driver.h\n+++ b/lib/ethdev/ethdev_driver.h\n@@ -48,7 +48,7 @@ struct rte_eth_rxtx_callback {\n * memory. This split allows the function pointer and driver data to be per-\n * process, while the actual configuration data for the device is shared.\n */\n-struct rte_eth_dev {\n+struct __rte_cache_aligned rte_eth_dev {\n \teth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function */\n \teth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function */\n \n@@ -89,7 +89,7 @@ struct rte_eth_dev {\n \n \tenum rte_eth_dev_state state; /**< Flag indicating the port state */\n \tvoid *security_ctx; /**< Context for security ops */\n-} __rte_cache_aligned;\n+};\n \n struct rte_eth_dev_sriov;\n struct rte_eth_dev_owner;\n@@ -100,7 +100,7 @@ struct rte_eth_dev {\n * device. This structure is safe to place in shared memory to be common\n * among different processes in a multi-process configuration.\n */\n-struct rte_eth_dev_data {\n+struct __rte_cache_aligned rte_eth_dev_data {\n \tchar name[RTE_ETH_NAME_MAX_LEN]; /**< Unique identifier name */\n \n \tvoid **rx_queues; /**< Array of pointers to Rx queues */\n@@ -186,7 +186,7 @@ struct rte_eth_dev_data {\n \tuint16_t backer_port_id;\n \n \tpthread_mutex_t flow_ops_mutex; /**< rte_flow ops mutex */\n-} __rte_cache_aligned;\n+};\n \n /**\n * @internal\ndiff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 21e3a21..b7eca2f 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -333,12 +333,12 @@ struct rte_eth_stats {\n * A structure used to retrieve link-level information of an Ethernet port.\n */\n __extension__\n-struct rte_eth_link {\n+struct __rte_aligned(8) rte_eth_link {\n \tuint32_t link_speed; /**< RTE_ETH_SPEED_NUM_ */\n \tuint16_t link_duplex : 1; /**< RTE_ETH_LINK_[HALF/FULL]_DUPLEX */\n \tuint16_t link_autoneg : 1; /**< RTE_ETH_LINK_[AUTONEG/FIXED] */\n \tuint16_t link_status : 1; /**< RTE_ETH_LINK_[DOWN/UP] */\n-} __rte_aligned(8); /**< aligned for atomic64 read/write */\n+}; /**< aligned for atomic64 read/write */\n \n /**@{@name Link negotiation\n * Constants used in link management.\n@@ -1835,7 +1835,7 @@ struct rte_eth_dev_info {\n * Ethernet device Rx queue information structure.\n * Used to retrieve information about configured queue.\n */\n-struct rte_eth_rxq_info {\n+struct __rte_cache_min_aligned rte_eth_rxq_info {\n \tstruct rte_mempool *mp; /**< mempool used by that queue. */\n \tstruct rte_eth_rxconf conf; /**< queue config parameters. */\n \tuint8_t scattered_rx; /**< scattered packets Rx supported. */\n@@ -1849,17 +1849,17 @@ struct rte_eth_rxq_info {\n \t * Value 0 means that the threshold monitoring is disabled.\n \t */\n \tuint8_t avail_thresh;\n-} __rte_cache_min_aligned;\n+};\n \n /**\n * Ethernet device Tx queue information structure.\n * Used to retrieve information about configured queue.\n */\n-struct rte_eth_txq_info {\n+struct __rte_cache_min_aligned rte_eth_txq_info {\n \tstruct rte_eth_txconf conf; /**< queue config parameters. */\n \tuint16_t nb_desc; /**< configured number of TXDs. */\n \tuint8_t queue_state; /**< one of RTE_ETH_QUEUE_STATE_*. */\n-} __rte_cache_min_aligned;\n+};\n \n /**\n * @warning\n@@ -1869,7 +1869,7 @@ struct rte_eth_txq_info {\n * Used to retrieve Rx queue information when Tx queue reusing mbufs and moving\n * them into Rx mbuf ring.\n */\n-struct rte_eth_recycle_rxq_info {\n+struct __rte_cache_min_aligned rte_eth_recycle_rxq_info {\n \tstruct rte_mbuf **mbuf_ring; /**< mbuf ring of Rx queue. */\n \tstruct rte_mempool *mp; /**< mempool of Rx queue. */\n \tuint16_t *refill_head; /**< head of Rx queue refilling mbufs. */\n@@ -1883,7 +1883,7 @@ struct rte_eth_recycle_rxq_info {\n \t * Value 0 means that PMD drivers have no requirement for this.\n \t */\n \tuint16_t refill_requirement;\n-} __rte_cache_min_aligned;\n+};\n \n /* Generic Burst mode flag definition, values can be ORed. */\n \ndiff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h\nindex 4bfaf79..fdfc68f 100644\n--- a/lib/ethdev/rte_ethdev_core.h\n+++ b/lib/ethdev/rte_ethdev_core.h\n@@ -81,7 +81,7 @@ struct rte_ethdev_qdata {\n * On 64-bit systems contents of this structure occupy exactly two 64B lines.\n * On 32-bit systems contents of this structure fits into one 64B line.\n */\n-struct rte_eth_fp_ops {\n+struct __rte_cache_aligned rte_eth_fp_ops {\n \n \t/**@{*/\n \t/**\n@@ -119,7 +119,7 @@ struct rte_eth_fp_ops {\n \tuintptr_t reserved2[2];\n \t/**@}*/\n \n-} __rte_cache_aligned;\n+};\n \n extern struct rte_eth_fp_ops rte_eth_fp_ops[RTE_MAX_ETHPORTS];\n \n", "prefixes": [ "v4", "11/39" ] }