Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136756/?format=api
{ "id": 136756, "url": "http://patches.dpdk.org/api/patches/136756/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1707928564-28796-4-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707928564-28796-4-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707928564-28796-4-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-14T16:35:28", "name": "[v4,03/39] stack: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9af64d39f7675f6cc31ede6ce9b99a68e5f7cbe5", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1707928564-28796-4-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31107, "url": "http://patches.dpdk.org/api/series/31107/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31107", "date": "2024-02-14T16:35:25", "name": "use C11 alignas and normalize type alignment", "version": 4, "mbox": "http://patches.dpdk.org/series/31107/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136756/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136756/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9635343B38;\n\tWed, 14 Feb 2024 17:36:26 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ADF7642E54;\n\tWed, 14 Feb 2024 17:36:12 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id C8F8D427D7\n for <dev@dpdk.org>; Wed, 14 Feb 2024 17:36:06 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id F3DE220B2003; Wed, 14 Feb 2024 08:36:05 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com F3DE220B2003", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707928566;\n bh=LhiAcFL8IpVzmmAPJgAv0jg/+iGj/fmqJp/gNSqIbVI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ipPssHTCv0b9AV3VCDNmQLHye0LSckLmQtZ/DBOSDXPVqUXU/Gg7ll9VXMhmkE1hI\n HZHNDf5y7eu3+nQN/y8NJXlB5puYtxnGRZwvZpC+X2NjDYIadchyycHcZS1vc2AeBm\n 149zAd9ardv8n/BRFOcVmYpDpJuubfHjp6a957Vo=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v4 03/39] stack: use C11 alignas", "Date": "Wed, 14 Feb 2024 08:35:28 -0800", "Message-Id": "<1707928564-28796-4-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707928564-28796-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>\n <1707928564-28796-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/stack/rte_stack.h | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/stack/rte_stack.h b/lib/stack/rte_stack.h\nindex a379300..8ff0659 100644\n--- a/lib/stack/rte_stack.h\n+++ b/lib/stack/rte_stack.h\n@@ -15,6 +15,8 @@\n #ifndef _RTE_STACK_H_\n #define _RTE_STACK_H_\n \n+#include <stdalign.h>\n+\n #ifdef __cplusplus\n extern \"C\" {\n #endif\n@@ -42,7 +44,7 @@ struct rte_stack_lf_head {\n \n struct rte_stack_lf_list {\n \t/** List head */\n-\tstruct rte_stack_lf_head head __rte_aligned(16);\n+\talignas(16) struct rte_stack_lf_head head;\n \t/** List len */\n \tRTE_ATOMIC(uint64_t) len;\n };\n@@ -52,11 +54,11 @@ struct rte_stack_lf_list {\n */\n struct rte_stack_lf {\n \t/** LIFO list of elements */\n-\tstruct rte_stack_lf_list used __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) struct rte_stack_lf_list used;\n \t/** LIFO list of free elements */\n-\tstruct rte_stack_lf_list free __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) struct rte_stack_lf_list free;\n \t/** LIFO elements */\n-\tstruct rte_stack_lf_elem elems[] __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) struct rte_stack_lf_elem elems[];\n };\n \n /* Structure containing the LIFO, its current length, and a lock for mutual\n@@ -71,9 +73,9 @@ struct rte_stack_std {\n /* The RTE stack structure contains the LIFO structure itself, plus metadata\n * such as its name and memzone pointer.\n */\n-struct rte_stack {\n+struct __rte_cache_aligned rte_stack {\n \t/** Name of the stack. */\n-\tchar name[RTE_STACK_NAMESIZE] __rte_cache_aligned;\n+\talignas(RTE_CACHE_LINE_SIZE) char name[RTE_STACK_NAMESIZE];\n \t/** Memzone containing the rte_stack structure. */\n \tconst struct rte_memzone *memzone;\n \tuint32_t capacity; /**< Usable size of the stack. */\n@@ -82,7 +84,7 @@ struct rte_stack {\n \t\tstruct rte_stack_lf stack_lf; /**< Lock-free LIFO structure. */\n \t\tstruct rte_stack_std stack_std;\t/**< LIFO structure. */\n \t};\n-} __rte_cache_aligned;\n+};\n \n /**\n * The stack uses lock-free push and pop functions. This flag is only\n", "prefixes": [ "v4", "03/39" ] }