Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136684/?format=api
http://patches.dpdk.org/api/patches/136684/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1707873986-29352-6-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707873986-29352-6-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707873986-29352-6-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-14T01:26:17", "name": "[05/14] pipeline: use C11 alignas", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7500229e0dcfef4e03a7dc883a318fdb8d3757d3", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1707873986-29352-6-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31100, "url": "http://patches.dpdk.org/api/series/31100/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31100", "date": "2024-02-14T01:26:12", "name": "use C11 alignas and normalize type alignment", "version": 1, "mbox": "http://patches.dpdk.org/series/31100/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136684/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136684/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E61B843B21;\n\tWed, 14 Feb 2024 02:27:12 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 70C2442EE5;\n\tWed, 14 Feb 2024 02:26:38 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id C1DE340278\n for <dev@dpdk.org>; Wed, 14 Feb 2024 02:26:29 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 52D6420B2005; Tue, 13 Feb 2024 17:26:28 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 52D6420B2005", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707873988;\n bh=L1ZnXSfMFHkQ9EvVoxwPvpfe0MCNUFV9AKEjTyS4vGQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=A+a28yLC3nEXfaLal5/1oU0OYlTyd3iUaDHALeAKqxt8yij+BOtFduAUK6mZLmWua\n kA1pjDZZWA179OdF2kZ7TYUKa34O6Zwuhok9UZvXPnUIVsgG/BX1Thnr21VNFQjguc\n DJ3Nzt1PLo1gLVIoD/He5lPGKg4au4WeLsPGyfO8=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Min Zhou <zhoumin@loongson.cn>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 05/14] pipeline: use C11 alignas", "Date": "Tue, 13 Feb 2024 17:26:17 -0800", "Message-Id": "<1707873986-29352-6-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "* Move __rte_aligned from the end of {struct,union} definitions to\n be between {struct,union} and tag.\n\n The placement between {struct,union} and the tag allows the desired\n alignment to be imparted on the type regardless of the toolchain being\n used for all of GCC, LLVM, MSVC compilers building both C and C++.\n\n* Replace use of __rte_aligned(a) on variables/fields with alignas(a).\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/pipeline/rte_table_action.c | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/pipeline/rte_table_action.c b/lib/pipeline/rte_table_action.c\nindex dfdbc66..87c3e0e 100644\n--- a/lib/pipeline/rte_table_action.c\n+++ b/lib/pipeline/rte_table_action.c\n@@ -465,11 +465,11 @@ struct encap_qinq_data {\n \t((((uint64_t)(s)) & 0x1LLU) << 8) | \\\n \t(((uint64_t)(ttl)) & 0xFFLLU)))\n \n-struct encap_mpls_data {\n+struct __rte_aligned(2) encap_mpls_data {\n \tstruct rte_ether_hdr ether;\n \tuint32_t mpls[RTE_TABLE_ACTION_MPLS_LABELS_MAX];\n \tuint32_t mpls_count;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n #define PPP_PROTOCOL_IP 0x0021\n \n@@ -487,42 +487,42 @@ struct encap_pppoe_data {\n \n #define IP_PROTO_UDP 17\n \n-struct encap_vxlan_ipv4_data {\n+struct __rte_aligned(2) encap_vxlan_ipv4_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_ipv4_hdr ipv4;\n \tstruct rte_udp_hdr udp;\n \tstruct rte_vxlan_hdr vxlan;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n-struct encap_vxlan_ipv4_vlan_data {\n+struct __rte_aligned(2) encap_vxlan_ipv4_vlan_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_vlan_hdr vlan;\n \tstruct rte_ipv4_hdr ipv4;\n \tstruct rte_udp_hdr udp;\n \tstruct rte_vxlan_hdr vxlan;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n-struct encap_vxlan_ipv6_data {\n+struct __rte_aligned(2) encap_vxlan_ipv6_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_ipv6_hdr ipv6;\n \tstruct rte_udp_hdr udp;\n \tstruct rte_vxlan_hdr vxlan;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n-struct encap_vxlan_ipv6_vlan_data {\n+struct __rte_aligned(2) encap_vxlan_ipv6_vlan_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_vlan_hdr vlan;\n \tstruct rte_ipv6_hdr ipv6;\n \tstruct rte_udp_hdr udp;\n \tstruct rte_vxlan_hdr vxlan;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n-struct encap_qinq_pppoe_data {\n+struct __rte_aligned(2) encap_qinq_pppoe_data {\n \tstruct rte_ether_hdr ether;\n \tstruct rte_vlan_hdr svlan;\n \tstruct rte_vlan_hdr cvlan;\n \tstruct pppoe_ppp_hdr pppoe_ppp;\n-} __rte_packed __rte_aligned(2);\n+} __rte_packed;\n \n static size_t\n encap_data_size(struct rte_table_action_encap_config *encap)\n", "prefixes": [ "05/14" ] }{ "id": 136684, "url": "