Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136673/?format=api
{ "id": 136673, "url": "http://patches.dpdk.org/api/patches/136673/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1707849292-19519-22-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707849292-19519-22-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707849292-19519-22-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-13T18:34:52", "name": "[v2,21/21] devtools: forbid direct use of compiler alignof and typeof", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "17116f5af0b6a0ee65208cd022b9222bb831f161", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1707849292-19519-22-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31096, "url": "http://patches.dpdk.org/api/series/31096/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31096", "date": "2024-02-13T18:34:32", "name": "use C11 alignof", "version": 2, "mbox": "http://patches.dpdk.org/series/31096/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136673/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136673/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AF46343B0D;\n\tTue, 13 Feb 2024 19:37:32 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B617742EFC;\n\tTue, 13 Feb 2024 19:35:19 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 1E6F842D7B\n for <dev@dpdk.org>; Tue, 13 Feb 2024 19:34:57 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id EE7ED20B2014; Tue, 13 Feb 2024 10:34:54 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com EE7ED20B2014", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707849294;\n bh=vAFbWuH3EQmhq208jJcWNqYnzvXlxMwI6iAxf97lD44=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=mQsAcs7UCQ8YeZO33RddpVZRwhmilSBngwyiQ9EdbuPzIcU25dkQ8qStH7Cn0SJV0\n GQKlBCoYcUUU0/wv/GG9E2JavUK+15WG91dqCHHrmp4TZa1twv74Q0s4bTODi34EM5\n umZ9fBQQg8JkKzR6wF3nNGFui6b+BNdSxNGclc08=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Akhil Goyal <gakhil@marvell.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Anoob Joseph <anoobj@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chaoyong He <chaoyong.he@corigine.com>, Chenbo Xia <chenbox@nvidia.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jerin Jacob <jerinj@marvell.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Jochen Behrens <jbehrens@vmware.com>,\n John McNamara <john.mcnamara@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Volodymyr Fialko <vfialko@marvell.com>, Zhirun Yan <zhirun.yan@intel.com>,\n david.marchand@redhat.com, Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 21/21] devtools: forbid direct use of compiler alignof and\n typeof", "Date": "Tue, 13 Feb 2024 10:34:52 -0800", "Message-Id": "<1707849292-19519-22-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com>\n <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add 2 checks forbidding direct use of __alignof__ and __typeof__ instead\nC11 alignof and rte_common.h typeof macros should be used.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n devtools/checkpatches.sh | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh\nindex c9e466f..e379700 100755\n--- a/devtools/checkpatches.sh\n+++ b/devtools/checkpatches.sh\n@@ -151,6 +151,22 @@ check_forbidden_additions() { # <patch>\n \t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n \t\t\"$1\" || res=1\n \n+\t# forbid use of __alignof__\n+\tawk -v FOLDERS=\"lib drivers app examples\" \\\n+\t\t-v EXPRESSIONS='\\\\<__alignof__\\\\>' \\\n+\t\t-v RET_ON_FAIL=1 \\\n+\t\t-v MESSAGE='Using __alignof__, prefer C11 alignof' \\\n+\t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n+\t\t\"$1\" || res=1\n+\n+\t# forbid use of __typeof__\n+\tawk -v FOLDERS=\"lib drivers app examples\" \\\n+\t\t-v EXPRESSIONS='\\\\<__typeof__\\\\>' \\\n+\t\t-v RET_ON_FAIL=1 \\\n+\t\t-v MESSAGE='Using __typeof__, prefer typeof' \\\n+\t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n+\t\t\"$1\" || res=1\n+\n \t# forbid use of non abstracted bit count operations\n \tawk -v FOLDERS=\"lib drivers app examples\" \\\n \t\t-v EXPRESSIONS='\\\\<__builtin_(clz|clzll|ctz|ctzll|popcount|popcountll)\\\\>' \\\n", "prefixes": [ "v2", "21/21" ] }