Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136663/?format=api
{ "id": 136663, "url": "http://patches.dpdk.org/api/patches/136663/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1707849292-19519-11-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707849292-19519-11-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707849292-19519-11-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-13T18:34:41", "name": "[v2,10/21] test: use C11 alignof", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "626a24d8c02f7516f8f337811d75b745bb0f5fec", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1707849292-19519-11-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31096, "url": "http://patches.dpdk.org/api/series/31096/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31096", "date": "2024-02-13T18:34:32", "name": "use C11 alignof", "version": 2, "mbox": "http://patches.dpdk.org/series/31096/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136663/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136663/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A9E9843B0D;\n\tTue, 13 Feb 2024 19:36:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 12F5842EC1;\n\tTue, 13 Feb 2024 19:35:09 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 837D742E10\n for <dev@dpdk.org>; Tue, 13 Feb 2024 19:34:55 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 4ACA220B2009; Tue, 13 Feb 2024 10:34:53 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 4ACA220B2009", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707849294;\n bh=jyenPvEHcrqt6izxlPmNOVHkg7GzKVfzC7TyCETChUY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=FC98RWQpslWoKgs15JaBUDobbpeSDsxOpTGQr9ve6VuIdnjGuNIhCwb3rG+DSuE4f\n YfTDxkwIN+bjRx8xe1vIAl+8dFQ5B+58oSKzHcarg7vZtAn9vKH511X9uuLz+2KlZN\n IDyM85TG6fMC3aDGz4OdBAFBzuPqImaVLKg2F1BU=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Akhil Goyal <gakhil@marvell.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Anoob Joseph <anoobj@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chaoyong He <chaoyong.he@corigine.com>, Chenbo Xia <chenbox@nvidia.com>,\n David Hunt <david.hunt@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jerin Jacob <jerinj@marvell.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Jochen Behrens <jbehrens@vmware.com>,\n John McNamara <john.mcnamara@intel.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Ori Kam <orika@nvidia.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Volodymyr Fialko <vfialko@marvell.com>, Zhirun Yan <zhirun.yan@intel.com>,\n david.marchand@redhat.com, Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 10/21] test: use C11 alignof", "Date": "Tue, 13 Feb 2024 10:34:41 -0800", "Message-Id": "<1707849292-19519-11-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1706138276-28224-1-git-send-email-roretzla@linux.microsoft.com>\n <1707849292-19519-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace use of __alignof__(T) with C11 alignof(T) to improve portability\nbetween toolchains.\n\nReplace use of __alignof__(e) with C11 alignof(typeof(e)) to improve\nportability between toolchains\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n app/test/test_distributor.c | 3 ++-\n app/test/test_graph.c | 3 ++-\n app/test/test_mbuf.c | 9 +++++----\n app/test/test_ring_stress_impl.h | 6 ++++--\n 4 files changed, 13 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c\nindex 6cb27f4..d2037b7 100644\n--- a/app/test/test_distributor.c\n+++ b/app/test/test_distributor.c\n@@ -5,6 +5,7 @@\n #include \"test.h\"\n \n #include <unistd.h>\n+#include <stdalign.h>\n #include <string.h>\n #include <rte_cycles.h>\n #include <rte_errno.h>\n@@ -831,7 +832,7 @@ int test_error_distributor_create_numworkers(void)\n \tstatic const struct rte_mbuf_dynfield seq_dynfield_desc = {\n \t\t.name = \"test_distributor_dynfield_seq\",\n \t\t.size = sizeof(seq_dynfield_t),\n-\t\t.align = __alignof__(seq_dynfield_t),\n+\t\t.align = alignof(seq_dynfield_t),\n \t};\n \tseq_dynfield_offset =\n \t\trte_mbuf_dynfield_register(&seq_dynfield_desc);\ndiff --git a/app/test/test_graph.c b/app/test/test_graph.c\nindex 3dd017e..b8409bc 100644\n--- a/app/test/test_graph.c\n+++ b/app/test/test_graph.c\n@@ -7,6 +7,7 @@\n #include <assert.h>\n #include <inttypes.h>\n #include <signal.h>\n+#include <stdalign.h>\n #include <stdio.h>\n #include <string.h>\n #include <unistd.h>\n@@ -935,7 +936,7 @@ struct test_node_register {\n \tstatic const struct rte_mbuf_dynfield graph_dynfield_desc = {\n \t\t.name = \"test_graph_dynfield\",\n \t\t.size = sizeof(graph_dynfield_t),\n-\t\t.align = __alignof__(graph_dynfield_t),\n+\t\t.align = alignof(graph_dynfield_t),\n \t};\n \tgraph_dynfield_offset =\n \t\trte_mbuf_dynfield_register(&graph_dynfield_desc);\ndiff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex d7393df..51ea6ef 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -5,6 +5,7 @@\n #include \"test.h\"\n \n #include <string.h>\n+#include <stdalign.h>\n #include <stdarg.h>\n #include <stdio.h>\n #include <stdlib.h>\n@@ -2534,19 +2535,19 @@ struct test_case {\n \tconst struct rte_mbuf_dynfield dynfield = {\n \t\t.name = \"test-dynfield\",\n \t\t.size = sizeof(uint8_t),\n-\t\t.align = __alignof__(uint8_t),\n+\t\t.align = alignof(uint8_t),\n \t\t.flags = 0,\n \t};\n \tconst struct rte_mbuf_dynfield dynfield2 = {\n \t\t.name = \"test-dynfield2\",\n \t\t.size = sizeof(uint16_t),\n-\t\t.align = __alignof__(uint16_t),\n+\t\t.align = alignof(uint16_t),\n \t\t.flags = 0,\n \t};\n \tconst struct rte_mbuf_dynfield dynfield3 = {\n \t\t.name = \"test-dynfield3\",\n \t\t.size = sizeof(uint8_t),\n-\t\t.align = __alignof__(uint8_t),\n+\t\t.align = alignof(uint8_t),\n \t\t.flags = 0,\n \t};\n \tconst struct rte_mbuf_dynfield dynfield_fail_big = {\n@@ -2564,7 +2565,7 @@ struct test_case {\n \tconst struct rte_mbuf_dynfield dynfield_fail_flag = {\n \t\t.name = \"test-dynfield\",\n \t\t.size = sizeof(uint8_t),\n-\t\t.align = __alignof__(uint8_t),\n+\t\t.align = alignof(uint8_t),\n \t\t.flags = 1,\n \t};\n \tconst struct rte_mbuf_dynflag dynflag_fail_flag = {\ndiff --git a/app/test/test_ring_stress_impl.h b/app/test/test_ring_stress_impl.h\nindex 62f046a..2dec897 100644\n--- a/app/test/test_ring_stress_impl.h\n+++ b/app/test/test_ring_stress_impl.h\n@@ -2,6 +2,8 @@\n * Copyright(c) 2020 Intel Corporation\n */\n \n+#include <stdalign.h>\n+\n #include \"test_ring_stress.h\"\n \n /**\n@@ -285,7 +287,7 @@ struct ring_elem {\n \t*data = NULL;\n \n \tsz = num * sizeof(*elm);\n-\telm = rte_zmalloc(NULL, sz, __alignof__(*elm));\n+\telm = rte_zmalloc(NULL, sz, alignof(typeof(*elm)));\n \tif (elm == NULL) {\n \t\tprintf(\"%s: alloc(%zu) for %u elems data failed\",\n \t\t\t__func__, sz, num);\n@@ -297,7 +299,7 @@ struct ring_elem {\n \t/* alloc ring */\n \tnr = 2 * num;\n \tsz = rte_ring_get_memsize(nr);\n-\tr = rte_zmalloc(NULL, sz, __alignof__(*r));\n+\tr = rte_zmalloc(NULL, sz, alignof(typeof(*r)));\n \tif (r == NULL) {\n \t\tprintf(\"%s: alloc(%zu) for FIFO with %u elems failed\",\n \t\t\t__func__, sz, nr);\n", "prefixes": [ "v2", "10/21" ] }