Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136617/?format=api
http://patches.dpdk.org/api/patches/136617/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1707774557-16012-16-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707774557-16012-16-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707774557-16012-16-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-12T21:49:17", "name": "[15/15] vhost: use GCC and MSVC common VA ARGS extension", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9dda0d9fc9cf393327ba472b00e4924fcef4bdba", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1707774557-16012-16-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31079, "url": "http://patches.dpdk.org/api/series/31079/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31079", "date": "2024-02-12T21:49:02", "name": "use GCC/MSVC compatible __VA_ARGS__", "version": 1, "mbox": "http://patches.dpdk.org/series/31079/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136617/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136617/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B1C0B43AFE;\n\tMon, 12 Feb 2024 22:50:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5057841140;\n\tMon, 12 Feb 2024 22:49:40 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 448F440E36\n for <dev@dpdk.org>; Mon, 12 Feb 2024 22:49:24 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 0B90920B200F; Mon, 12 Feb 2024 13:49:22 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 0B90920B200F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707774563;\n bh=KKaB/DL9OZoncT9X5DBVsRHKm3WAFuyserzgF20yKXg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=i1l6rZcrp6IKd1ixChj8EUszWwVrSoUICs9pP39/LNHUTow6XSob9UzdSjdsZENoE\n z1ds/FTXOLpiFN6+i8kg+8NbK0NF05jMALFT4pg6f0jYdRCywDsYFw5RgcqpuWCp77\n uATmAoQAt8PL8HPXj7pAASjhpzV7CBomdl4qlPlw=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Anatoly Burakov <anatoly.burakov@intel.com>,\n Ashish Gupta <ashish.gupta@marvell.com>, Chenbo Xia <chenbox@nvidia.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Hunt <david.hunt@intel.com>, Fan Zhang <fanzhang.oss@gmail.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Srikanth Yalavarthi <syalavarthi@marvell.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Sunil Kumar Kori <skori@marvell.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 15/15] vhost: use GCC and MSVC common VA ARGS extension", "Date": "Mon, 12 Feb 2024 13:49:17 -0800", "Message-Id": "<1707774557-16012-16-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use ... and forward with __VA_ARGS__ instead of args... and args.\nNeither mechanism is conformant with the standard but the former works\nwith both GCC and MSVC.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/vhost/vhost.h | 8 ++++----\n lib/vhost/vhost_crypto.c | 14 +++++++-------\n 2 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h\nindex 0b13374..b539d6c 100644\n--- a/lib/vhost/vhost.h\n+++ b/lib/vhost/vhost.h\n@@ -677,11 +677,11 @@ void __vhost_log_write_iova(struct virtio_net *dev, struct vhost_virtqueue *vq,\n extern int vhost_data_log_level;\n #define RTE_LOGTYPE_VHOST_DATA vhost_data_log_level\n \n-#define VHOST_CONFIG_LOG(prefix, level, fmt, args...)\t\t\\\n-\tRTE_LOG_LINE(level, VHOST_CONFIG, \"(%s) \" fmt, prefix, ##args)\n+#define VHOST_CONFIG_LOG(prefix, level, fmt, ...)\t\t\\\n+\tRTE_LOG_LINE(level, VHOST_CONFIG, \"(%s) \" fmt, prefix, ## __VA_ARGS__)\n \n-#define VHOST_DATA_LOG(prefix, level, fmt, args...)\t\t\\\n-\tRTE_LOG_DP_LINE(level, VHOST_DATA, \"(%s) \" fmt, prefix, ##args)\n+#define VHOST_DATA_LOG(prefix, level, fmt, ...)\t\t\\\n+\tRTE_LOG_DP_LINE(level, VHOST_DATA, \"(%s) \" fmt, prefix, ## __VA_ARGS__)\n \n #ifdef RTE_LIBRTE_VHOST_DEBUG\n #define VHOST_MAX_PRINT_BUFF 6072\ndiff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c\nindex 3704fbb..86983c1 100644\n--- a/lib/vhost/vhost_crypto.c\n+++ b/lib/vhost/vhost_crypto.c\n@@ -20,19 +20,19 @@\n RTE_LOG_REGISTER_SUFFIX(vhost_crypto_logtype, crypto, INFO);\n #define RTE_LOGTYPE_VHOST_CRYPTO\tvhost_crypto_logtype\n \n-#define VC_LOG_ERR(fmt, args...)\t\t\t\t\\\n+#define VC_LOG_ERR(fmt, ...)\t\t\t\t\\\n \tRTE_LOG_LINE(ERR, VHOST_CRYPTO, \"%s() line %u: \" fmt,\t\\\n-\t\t__func__, __LINE__, ## args)\n-#define VC_LOG_INFO(fmt, args...)\t\t\t\t\\\n+\t\t__func__, __LINE__, ## __VA_ARGS__)\n+#define VC_LOG_INFO(fmt, ...)\t\t\t\t\\\n \tRTE_LOG_LINE(INFO, VHOST_CRYPTO, \"%s() line %u: \" fmt,\t\\\n-\t\t__func__, __LINE__, ## args)\n+\t\t__func__, __LINE__, ## __VA_ARGS__)\n \n #ifdef RTE_LIBRTE_VHOST_DEBUG\n-#define VC_LOG_DBG(fmt, args...)\t\t\t\t\\\n+#define VC_LOG_DBG(fmt, ...)\t\t\t\t\\\n \tRTE_LOG_LINE(DEBUG, VHOST_CRYPTO, \"%s() line %u: \" fmt,\t\\\n-\t\t__func__, __LINE__, ## args)\n+\t\t__func__, __LINE__, ## __VA_ARGS__)\n #else\n-#define VC_LOG_DBG(fmt, args...)\n+#define VC_LOG_DBG(fmt, ...)\n #endif\n \n #define VIRTIO_CRYPTO_FEATURES ((1ULL << VIRTIO_F_NOTIFY_ON_EMPTY) |\t\\\n", "prefixes": [ "15/15" ] }{ "id": 136617, "url": "