Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136613/?format=api
{ "id": 136613, "url": "http://patches.dpdk.org/api/patches/136613/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1707774557-16012-14-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1707774557-16012-14-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1707774557-16012-14-git-send-email-roretzla@linux.microsoft.com", "date": "2024-02-12T21:49:15", "name": "[13/15] rcu: use GCC and MSVC common VA ARGS extension", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "129a0ac1a9c9b7128aca6c7788efb9d7bb2e6b0d", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1707774557-16012-14-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31079, "url": "http://patches.dpdk.org/api/series/31079/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31079", "date": "2024-02-12T21:49:02", "name": "use GCC/MSVC compatible __VA_ARGS__", "version": 1, "mbox": "http://patches.dpdk.org/series/31079/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136613/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136613/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4B07C43AFE;\n\tMon, 12 Feb 2024 22:50:27 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C8042410E3;\n\tMon, 12 Feb 2024 22:49:35 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 4C24440E54\n for <dev@dpdk.org>; Mon, 12 Feb 2024 22:49:24 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id E446F20B200D; Mon, 12 Feb 2024 13:49:22 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E446F20B200D", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1707774562;\n bh=ClSaUhf4lmWT7ckBPc9dfhDreaOuY91h0rENNVVVtSo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Vxi7s/wFxpa6iBHPJ2e+uZ+GdUKVAwThJopnVabrw0FQ1F0vaBWsUtBm+LwbwzMEn\n Qu/q1VMhiEAnbhIaZyFOgGSxqS9XqBfn82U0bxu49m0CG5l7AyF4jEtl3uPRFuBKfm\n LEzvjO2mnLAOC3MqQwA5ykBia8dB0GlzluWni54A=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Anatoly Burakov <anatoly.burakov@intel.com>,\n Ashish Gupta <ashish.gupta@marvell.com>, Chenbo Xia <chenbox@nvidia.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n David Hunt <david.hunt@intel.com>, Fan Zhang <fanzhang.oss@gmail.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Srikanth Yalavarthi <syalavarthi@marvell.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Sunil Kumar Kori <skori@marvell.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 13/15] rcu: use GCC and MSVC common VA ARGS extension", "Date": "Mon, 12 Feb 2024 13:49:15 -0800", "Message-Id": "<1707774557-16012-14-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use ... and forward with __VA_ARGS__ instead of args... and args.\nNeither mechanism is conformant with the standard but the former works\nwith both GCC and MSVC.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/rcu/rte_rcu_qsbr.c | 4 ++--\n lib/rcu/rte_rcu_qsbr.h | 12 ++++++------\n 2 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c\nindex bd0b83b..4aff573 100644\n--- a/lib/rcu/rte_rcu_qsbr.c\n+++ b/lib/rcu/rte_rcu_qsbr.c\n@@ -19,8 +19,8 @@\n #include \"rte_rcu_qsbr.h\"\n #include \"rcu_qsbr_pvt.h\"\n \n-#define RCU_LOG(level, fmt, args...) \\\n-\tRTE_LOG_LINE(level, RCU, \"%s(): \" fmt, __func__, ## args)\n+#define RCU_LOG(level, fmt, ...) \\\n+\tRTE_LOG_LINE(level, RCU, \"%s(): \" fmt, __func__, ## __VA_ARGS__)\n \n /* Get the memory size of QSBR variable */\n size_t\ndiff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h\nindex 23c9f89..f55e53a 100644\n--- a/lib/rcu/rte_rcu_qsbr.h\n+++ b/lib/rcu/rte_rcu_qsbr.h\n@@ -39,19 +39,19 @@\n #define RTE_LOGTYPE_RCU rte_rcu_log_type\n \n #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG\n-#define __RTE_RCU_DP_LOG(level, fmt, args...) \\\n-\tRTE_LOG_LINE(level, RCU, \"%s(): \" fmt, __func__, ## args)\n+#define __RTE_RCU_DP_LOG(level, fmt, ...) \\\n+\tRTE_LOG_LINE(level, RCU, \"%s(): \" fmt, __func__, ## __VA_ARGS__)\n #else\n-#define __RTE_RCU_DP_LOG(level, fmt, args...)\n+#define __RTE_RCU_DP_LOG(level, fmt, ...)\n #endif\n \n #if defined(RTE_LIBRTE_RCU_DEBUG)\n-#define __RTE_RCU_IS_LOCK_CNT_ZERO(v, thread_id, level, fmt, args...) do { \\\n+#define __RTE_RCU_IS_LOCK_CNT_ZERO(v, thread_id, level, fmt, ...) do { \\\n \tif (v->qsbr_cnt[thread_id].lock_cnt) \\\n-\t\tRTE_LOG_LINE(level, RCU, \"%s(): \" fmt, __func__, ## args); \\\n+\t\tRTE_LOG_LINE(level, RCU, \"%s(): \" fmt, __func__, ## __VA_ARGS__); \\\n } while (0)\n #else\n-#define __RTE_RCU_IS_LOCK_CNT_ZERO(v, thread_id, level, fmt, args...)\n+#define __RTE_RCU_IS_LOCK_CNT_ZERO(v, thread_id, level, fmt, ...)\n #endif\n \n /* Registered thread IDs are stored as a bitmap of 64b element array.\n", "prefixes": [ "13/15" ] }