Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136515/?format=api
http://patches.dpdk.org/api/patches/136515/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240208054311.3642-4-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240208054311.3642-4-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240208054311.3642-4-ajit.khaparde@broadcom.com", "date": "2024-02-08T05:43:11", "name": "[3/3] net/bnxt: add IPv6 flow label based RSS support", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "899161bab73c4ed6c34d40997ea910ec10d33a82", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240208054311.3642-4-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 31047, "url": "http://patches.dpdk.org/api/series/31047/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31047", "date": "2024-02-08T05:43:08", "name": "Support IPv6 flow label based RSS", "version": 1, "mbox": "http://patches.dpdk.org/series/31047/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136515/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/136515/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E76E43AC3;\n\tThu, 8 Feb 2024 06:43:39 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7B9E742DEF;\n\tThu, 8 Feb 2024 06:43:23 +0100 (CET)", "from mail-qv1-f43.google.com (mail-qv1-f43.google.com\n [209.85.219.43]) by mails.dpdk.org (Postfix) with ESMTP id 14F5940691\n for <dev@dpdk.org>; Thu, 8 Feb 2024 06:43:21 +0100 (CET)", "by mail-qv1-f43.google.com with SMTP id\n 6a1803df08f44-68c4fb9e7ccso6537416d6.3\n for <dev@dpdk.org>; Wed, 07 Feb 2024 21:43:21 -0800 (PST)", "from localhost.localdomain ([2605:a601:a780:1400:500e:b22e:1a:2d97])\n by smtp.gmail.com with ESMTPSA id\n mc3-20020a056214554300b0068cc4248169sm622949qvb.100.2024.02.07.21.43.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 07 Feb 2024 21:43:19 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1707371000; x=1707975800; darn=dpdk.org;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=fCsc8+RaOuYZEDxfNXB9eiMdMkQRXOYmSUYWph/YOkA=;\n b=RRUasC0g4o+d8EBJxoiUs1TQ24AAVRnLVUQaOo7cH6CDDfshI7pbu3uUBhb91t5Tsb\n FWsy2bKAGKxq2OcZ+6knBpZE2/OcZGOdwsaFl109t42VRvdNPu82zhUlHNM/3YVSpo+6\n 55F3iilyzws7BoF7YsI1DD7Zhi2VIpddL9j0E=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1707371000; x=1707975800;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=fCsc8+RaOuYZEDxfNXB9eiMdMkQRXOYmSUYWph/YOkA=;\n b=CqgZXM96WfFy0zCJ1L3px9HtlR9lEIOT+cKfVpXOmG2Oqr9McBbR5S/nBqr2jSIajB\n nlsG8Gh1n33W0bWl1TrUMVLmMh3i4WdjPuI6YCiZWrIJL2ydOInn2Ay92tT+ZpktuoV/\n gWTvvBk7hIpf2tC1RtoguqU9EDaWmY4CXCtz8zpO9BmZ0ZWXU0ClLLG4VtInXjcPqyas\n zF1QAdHA9Xo+/jTyPS1cQOJ+5zG2A03ewWFJWDpXzPxmULW8EiekuVWYIjHrGPU1prnQ\n NhH4Y+vZ94mT0RNtm9pLbBclh9ZDuGzG15eKNOIPgXxwq11DRRxAKYxofW+tQPg79bDB\n BZ7Q==", "X-Gm-Message-State": "AOJu0YwRNrxHd+tL3OtkDjvCqB7vKnCxN+XQwUJIu0ZIKK71bps3shr2\n He9Vak6TZhkhE+tVAyYDPWiyPeHozi96n2aeNZ5PnGZoMwUit2/6wdL5gpwaTSLAuFl9nlPlGFN\n pgkbB9gZecoqv74UTPpjgWn0m8v43/AEv7AZhF0NWhHXaCFnD3qnDApte84R4MEpAk+D9HNNDdA\n 5GsXentXJxwWnNRxSY5VBBVMNCpsgZ", "X-Google-Smtp-Source": "\n AGHT+IEorVCziCwe+y50460qWMhlaC6f5CcM2C82ouWopT03S+MoeuDunnLqPOajD8Lj9I2YDwQgcw==", "X-Received": "by 2002:a05:6214:400b:b0:68c:9336:279a with SMTP id\n kd11-20020a056214400b00b0068c9336279amr9744247qvb.6.1707371000065;\n Wed, 07 Feb 2024 21:43:20 -0800 (PST)", "X-Forwarded-Encrypted": "i=1;\n AJvYcCU0aDoDkLtgjrL+bozPtiiHT58x5eDi6dGIh3DhfhDgqKPdHyBBEeeOiO0FIvzPnFhzwvPtuUi92SI9M6fMsglCrUKWi/zNJ1bDvKj1cQ==", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tandrew.rybchenko@oktetlabs.ru", "Subject": "[PATCH 3/3] net/bnxt: add IPv6 flow label based RSS support", "Date": "Wed, 7 Feb 2024 21:43:11 -0800", "Message-Id": "<20240208054311.3642-4-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.39.2 (Apple Git-143)", "In-Reply-To": "<20240208054311.3642-1-ajit.khaparde@broadcom.com>", "References": "<20240208054311.3642-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000f9a5210610d84950\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "P7 hardware family can support IPv6 flow label based RSS.\nCheck if the firmware indicates capability bit to support\nIPv6 flow label based RSS and parse the RSS hash types\nappropriately.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_ethdev.c | 2 ++\n drivers/net/bnxt/bnxt_hwrm.c | 7 +++++++\n drivers/net/bnxt/bnxt_vnic.c | 9 +++++++--\n 4 files changed, 17 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex b604284256..42ecca35d7 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -868,6 +868,7 @@ struct bnxt {\n #define BNXT_VNIC_CAP_OUTER_RSS_TRUSTED_VF\tBIT(4)\n #define BNXT_VNIC_CAP_XOR_MODE\t\tBIT(5)\n #define BNXT_VNIC_CAP_CHKSM_MODE\tBIT(6)\n+#define BNXT_VNIC_CAP_IPV6_FLOW_LABEL_MODE\tBIT(7)\n #define BNXT_VNIC_CAP_L2_CQE_MODE\tBIT(8)\n #define BNXT_VNIC_CAP_AH_SPI4_CAP\tBIT(9)\n #define BNXT_VNIC_CAP_AH_SPI6_CAP\tBIT(10)\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex bc98594c2f..abe46e8004 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1086,6 +1086,8 @@ uint64_t bnxt_eth_rss_support(struct bnxt *bp)\n \tif (bp->vnic_cap_flags & BNXT_VNIC_CAP_CHKSM_MODE)\n \t\tsupport |= RTE_ETH_RSS_IPV4_CHKSUM |\n \t\t\t RTE_ETH_RSS_L4_CHKSUM;\n+\tif (bp->vnic_cap_flags & BNXT_VNIC_CAP_IPV6_FLOW_LABEL_MODE)\n+\t\tsupport |= RTE_ETH_RSS_IPV6_FLOW_LABEL;\n \tif (bp->vnic_cap_flags & BNXT_VNIC_CAP_AH_SPI_CAP)\n \t\tsupport |= RTE_ETH_RSS_AH;\n \tif (bp->vnic_cap_flags & BNXT_VNIC_CAP_ESP_SPI_CAP)\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 802973ba97..17527a3c4d 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -1307,6 +1307,9 @@ int bnxt_hwrm_vnic_qcaps(struct bnxt *bp)\n \tif (flags & HWRM_VNIC_QCAPS_OUTPUT_FLAGS_RING_SELECT_MODE_TOEPLITZ_CHKSM_CAP)\n \t\tbp->vnic_cap_flags |= BNXT_VNIC_CAP_CHKSM_MODE;\n \n+\tif (flags & HWRM_VNIC_QCAPS_OUTPUT_FLAGS_RSS_IPV6_FLOW_LABEL_CAP)\n+\t\tbp->vnic_cap_flags |= BNXT_VNIC_CAP_IPV6_FLOW_LABEL_MODE;\n+\n \tif (flags & HWRM_VNIC_QCAPS_OUTPUT_FLAGS_L2_CQE_MODE_CAP)\n \t\tbp->vnic_cap_flags |= BNXT_VNIC_CAP_L2_CQE_MODE;\n \n@@ -2772,6 +2775,10 @@ static uint32_t bnxt_sanitize_rss_type(struct bnxt *bp, uint32_t types)\n {\n \tuint32_t hwrm_type = types;\n \n+\tif (types & HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV6_FLOW_LABEL &&\n+\t !(bp->vnic_cap_flags & BNXT_VNIC_CAP_IPV6_FLOW_LABEL_MODE))\n+\t\thwrm_type &= ~HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV6_FLOW_LABEL;\n+\n \tif (types & HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_ESP_SPI_IPV4 &&\n \t !(bp->vnic_cap_flags & BNXT_VNIC_CAP_ESP_SPI4_CAP))\n \t\thwrm_type &= ~HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_ESP_SPI_IPV4;\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex 5092a7d774..76905ebdd1 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -280,6 +280,8 @@ uint32_t bnxt_rte_to_hwrm_hash_types(uint64_t rte_type)\n \t\thwrm_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_TCP_IPV6;\n \tif (rte_type & RTE_ETH_RSS_NONFRAG_IPV6_UDP)\n \t\thwrm_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_UDP_IPV6;\n+\tif (rte_type & RTE_ETH_RSS_IPV6_FLOW_LABEL)\n+\t\thwrm_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV6_FLOW_LABEL;\n \tif (rte_type & RTE_ETH_RSS_ESP)\n \t\thwrm_type |= HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_ESP_SPI_IPV4 |\n \t\t\t HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_ESP_SPI_IPV6;\n@@ -302,6 +304,7 @@ int bnxt_rte_to_hwrm_hash_level(struct bnxt *bp, uint64_t hash_f, uint32_t lvl)\n \tbool l3_and_l4 = l3 && l4;\n \tbool cksum = !!(hash_f &\n \t\t\t(RTE_ETH_RSS_IPV4_CHKSUM | RTE_ETH_RSS_L4_CHKSUM));\n+\tbool fl = !!(hash_f & RTE_ETH_RSS_IPV6_FLOW_LABEL);\n \n \t/* If FW has not advertised capability to configure outer/inner\n \t * RSS hashing , just log a message. HW will work in default RSS mode.\n@@ -317,12 +320,12 @@ int bnxt_rte_to_hwrm_hash_level(struct bnxt *bp, uint64_t hash_f, uint32_t lvl)\n \tswitch (lvl) {\n \tcase BNXT_RSS_LEVEL_INNERMOST:\n \t\t/* Irrespective of what RTE says, FW always does 4 tuple */\n-\t\tif (l3_and_l4 || l4 || l3_only || cksum)\n+\t\tif (l3_and_l4 || l4 || l3_only || cksum || fl)\n \t\t\tmode = BNXT_HASH_MODE_INNERMOST;\n \t\tbreak;\n \tcase BNXT_RSS_LEVEL_OUTERMOST:\n \t\t/* Irrespective of what RTE says, FW always does 4 tuple */\n-\t\tif (l3_and_l4 || l4 || l3_only || cksum)\n+\t\tif (l3_and_l4 || l4 || l3_only || cksum || fl)\n \t\t\tmode = BNXT_HASH_MODE_OUTERMOST;\n \t\tbreak;\n \tdefault:\n@@ -1415,6 +1418,8 @@ void bnxt_hwrm_rss_to_rte_hash_conf(struct bnxt_vnic_info *vnic,\n \t\t*rss_conf |= RTE_ETH_RSS_NONFRAG_IPV6_TCP;\n \tif (hash_types & HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_UDP_IPV6)\n \t\t*rss_conf |= RTE_ETH_RSS_NONFRAG_IPV6_UDP;\n+\tif (hash_types & HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_IPV6_FLOW_LABEL)\n+\t\t*rss_conf |= RTE_ETH_RSS_IPV6_FLOW_LABEL;\n \tif (hash_types & HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_AH_SPI_IPV6 ||\n \t hash_types & HWRM_VNIC_RSS_CFG_INPUT_HASH_TYPE_AH_SPI_IPV4)\n \t\t*rss_conf |= RTE_ETH_RSS_AH;\n", "prefixes": [ "3/3" ] }{ "id": 136515, "url": "