Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136454/?format=api
{ "id": 136454, "url": "http://patches.dpdk.org/api/patches/136454/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240207021849.52988-11-andrew.boyer@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240207021849.52988-11-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240207021849.52988-11-andrew.boyer@amd.com", "date": "2024-02-07T02:18:46", "name": "[v2,10/13] net/ionic: fix device close sequence to avoid crash", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f7c5a56b3c7874215d67b44bdedcebe72afca7e4", "submitter": { "id": 2861, "url": "http://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240207021849.52988-11-andrew.boyer@amd.com/mbox/", "series": [ { "id": 31028, "url": "http://patches.dpdk.org/api/series/31028/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31028", "date": "2024-02-07T02:18:46", "name": null, "version": 2, "mbox": "http://patches.dpdk.org/series/31028/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136454/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136454/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 89FD143A1B;\n\tWed, 7 Feb 2024 03:20:55 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E5FE742DF0;\n\tWed, 7 Feb 2024 03:20:07 +0100 (CET)", "from NAM04-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam04on2084.outbound.protection.outlook.com [40.107.101.84])\n by mails.dpdk.org (Postfix) with ESMTP id 727C442DD2;\n Wed, 7 Feb 2024 03:19:57 +0100 (CET)", "from PR3PR09CA0015.eurprd09.prod.outlook.com (2603:10a6:102:b7::20)\n by CH3PR12MB9169.namprd12.prod.outlook.com (2603:10b6:610:1a0::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.16; Wed, 7 Feb\n 2024 02:19:55 +0000", "from SA2PEPF000015CC.namprd03.prod.outlook.com\n (2603:10a6:102:b7:cafe::d2) by PR3PR09CA0015.outlook.office365.com\n (2603:10a6:102:b7::20) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend\n Transport; Wed, 7 Feb 2024 02:19:55 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n SA2PEPF000015CC.mail.protection.outlook.com (10.167.241.202) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7249.19 via Frontend Transport; Wed, 7 Feb 2024 02:19:54 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 6 Feb\n 2024 20:19:48 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FH6dhrK3myi/pwzzPM+0SkLJTLp/IHFHcr0wpEL9lJrF4Eiud2YyAxPjI8wa+SqyZwqMdvK0oN3GBLYfSCPChudEGkDu+pCkNLXjX1QgBdlZyRWhtD+0pCcI2UgPCMh44SEU6TYH3uboWXYILL81PHvOq39DDyFbU8hTkndZhXgynY78MtcHYWsKAJZiesic3OuRS3Pp5k5I+IhpbOaXStWYZtwyr04CZ8wqH+WoxJjOZRKAf56IfnPOGq3f4gQlmYLHkcxXGV00lyZzC7k3F44lvOXC1mA6tTOIMYnho4FWTJmW1ZCCxZ8as6Z6j34K+9LgNYELNC4xAgszRfr1ig==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=LcRgPIMTJAnmXNj/5UNG2ORGY/fyNR4AsY07IQOYQQ4=;\n b=c1t+U8pLZaeW5hzpRJRJ9+MBIyEhVNXD/wTJvv3Nxal8CE13+Re87F/q9wc5vT15XYxkP/eoec/fs7J1QxcZ/HZXsfiwJTvAGoLtO/Z++uEmigMQnrf3oBbLuaqVehjyLTIAuqDRYdHxr+qAxMEO1yxobrsYvCra844eVie+ukKA3w6oSoh2Bzx80hW0EbqieTjiC9qds5CIvZ24iT4fWPkKnfVmkwMjfIsciy4Jx9x1O2d6QtSEm4h4Rguei8wDZ6COW0tuMnGzmGKQpfPbmHgWw+zynbmJ4p95gc7EgfGlg2gZgBh9BgtPMxvb+2ivTgeZOIpPZfaxPTYbPWMgZA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LcRgPIMTJAnmXNj/5UNG2ORGY/fyNR4AsY07IQOYQQ4=;\n b=EhkdmE+u5S5oPSZmHHkKtPJOH4FugTQIPOwM0l/GwtYJDss+qKvgZjNZRjqwOovIUzc6kO+UrQO9UM1w5CPdOs0ILUqeuoxvbuLvvxkAk3Ax9pmXR170YYZjg0Id/WGb5S8C9iJ3EEY0/MMLxd2hom6WWC8s/snV5o7wgjtvYTY=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>, <stable@dpdk.org>", "Subject": "[PATCH v2 10/13] net/ionic: fix device close sequence to avoid crash", "Date": "Tue, 6 Feb 2024 18:18:46 -0800", "Message-ID": "<20240207021849.52988-11-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240202193238.62669-1-andrew.boyer@amd.com>", "References": "<20240202193238.62669-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SA2PEPF000015CC:EE_|CH3PR12MB9169:EE_", "X-MS-Office365-Filtering-Correlation-Id": "3371ed31-753d-4ed3-2126-08dc2783461f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n HM9Bb2NF6uRo7fi9wEm+IJtqO9vDSAEeBcHX5adBc9rTblsyDev+jIrSB61VT7yMYNNbjgqpoq3FPh5noMcnX4bO/0eqz6p9+m7IShkmIX/rQUX2UJAXMYkJe8TB692RFFACAYxFYDDmTsfu1oaAi8Ye99pbBOJF+bzZPDUd2sU9Kuuzu1Fy5Co9g6X5lXWYJb4OMweTMW3r+dS0LWCJHcgRvQ3nWcazrhf8r+vrvIV2ZgOwTDptLs1qoSKICbJcV0rCEXRx7WlIsVJHZiLgj855ZVgfd4ifhm+l6SrJX0ZJfKKvRr7dbnY4J0IZ6dVsxJHDgJFqihPi8vJHlCx2Uf/XFOBwKI72ObunfzP94CgFhd66aD16FWN8ZRrQmrT10nTBKfI6B7BLtnX4U/3v4SVAcdPjSHaThgfA7Ge+/tKNrxLj18LyWfTjWA7OjgaP8QmeUbUB2gHnAOqoDaj3TD/zDsGbGjky+94Qf/OzVDNOOSGPO1PZwQoyYFjytBxdfiy/H7Ri3VIo9HccDIC4JU8fZvTSumgsT+EPeCh5gWjokJD7y6yZivF+Xg0C6hG3gyG+N09Sp7aR7jZfuXXl2c//XW5oux/lSU+zKs4TRglCvuTemzFu5y8+Jw+5yBHicrBigVP7GkXKOPC4qS+WVJh4VYYI2VPxs1rhdxft4cxH54S7yiQwP4F7T3UwmyjJeOyRF5ZYLQBZaa1If9M3udLGo6uw9pb3Nl6ssoE6y/zRAyCi5k2brdkquLzFEfsqzhJn+o59Z5Q+ZsQsbNIt+A==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(136003)(39860400002)(376002)(396003)(346002)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(82310400011)(36840700001)(46966006)(40470700004)(36756003)(44832011)(5660300002)(2906002)(41300700001)(86362001)(426003)(47076005)(83380400001)(336012)(16526019)(26005)(2616005)(36860700001)(40480700001)(478600001)(40460700003)(1076003)(81166007)(356005)(82740400003)(70586007)(8936002)(6916009)(316002)(70206006)(450100002)(4326008)(54906003)(8676002)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Feb 2024 02:19:54.9630 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3371ed31-753d-4ed3-2126-08dc2783461f", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SA2PEPF000015CC.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH3PR12MB9169", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The close routine should release all resources, but not\ncall rte_eth_dev_destroy(). As written this code will call\nrte_eth_dev_release_port() twice and segfault.\n\nInstead, move rte_eth_dev_destroy() to the remove routine.\neth_ionic_dev_uninit() will call close if necessary.\n\nFixes: 175e4e7ed760 (\"net/ionic: complete release on close\")\nCc: stable@dpdk.org\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_ethdev.c | 30 +++++++++++++++---------------\n 1 file changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex 7c55a26956..bedcf958e2 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -1009,19 +1009,21 @@ ionic_dev_close(struct rte_eth_dev *eth_dev)\n \n \tionic_lif_stop(lif);\n \n-\tionic_lif_free_queues(lif);\n-\n \tIONIC_PRINT(NOTICE, \"Removing device %s\", eth_dev->device->name);\n \tif (adapter->intf->unconfigure_intr)\n \t\t(*adapter->intf->unconfigure_intr)(adapter);\n \n-\trte_eth_dev_destroy(eth_dev, eth_ionic_dev_uninit);\n-\n \tionic_port_reset(adapter);\n \tionic_reset(adapter);\n+\n+\tionic_lif_free_queues(lif);\n+\tionic_lif_deinit(lif);\n+\tionic_lif_free(lif); /* Does not free LIF object */\n+\n \tif (adapter->intf->unmap_bars)\n \t\t(*adapter->intf->unmap_bars)(adapter);\n \n+\tlif->adapter = NULL;\n \trte_free(adapter);\n \n \treturn 0;\n@@ -1098,21 +1100,18 @@ eth_ionic_dev_init(struct rte_eth_dev *eth_dev, void *init_params)\n static int\n eth_ionic_dev_uninit(struct rte_eth_dev *eth_dev)\n {\n-\tstruct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);\n-\tstruct ionic_adapter *adapter = lif->adapter;\n-\n \tIONIC_PRINT_CALL();\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n-\tadapter->lif = NULL;\n-\n-\tionic_lif_deinit(lif);\n-\tionic_lif_free(lif);\n+\tif (eth_dev->state != RTE_ETH_DEV_UNUSED)\n+\t\tionic_dev_close(eth_dev);\n \n-\tif (!(lif->state & IONIC_LIF_F_FW_RESET))\n-\t\tionic_lif_reset(lif);\n+\teth_dev->dev_ops = NULL;\n+\teth_dev->rx_pkt_burst = NULL;\n+\teth_dev->tx_pkt_burst = NULL;\n+\teth_dev->tx_pkt_prepare = NULL;\n \n \treturn 0;\n }\n@@ -1267,17 +1266,18 @@ eth_ionic_dev_remove(struct rte_device *rte_dev)\n {\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n \tstruct rte_eth_dev *eth_dev;\n+\tint ret = 0;\n \n \t/* Adapter lookup is using the eth_dev name */\n \tsnprintf(name, sizeof(name), \"%s_lif\", rte_dev->name);\n \n \teth_dev = rte_eth_dev_allocated(name);\n \tif (eth_dev)\n-\t\tionic_dev_close(eth_dev);\n+\t\tret = rte_eth_dev_destroy(eth_dev, eth_ionic_dev_uninit);\n \telse\n \t\tIONIC_PRINT(DEBUG, \"Cannot find device %s\", rte_dev->name);\n \n-\treturn 0;\n+\treturn ret;\n }\n \n RTE_LOG_REGISTER_DEFAULT(ionic_logtype, NOTICE);\n", "prefixes": [ "v2", "10/13" ] }