Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136453/?format=api
{ "id": 136453, "url": "http://patches.dpdk.org/api/patches/136453/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240207021849.52988-12-andrew.boyer@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240207021849.52988-12-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240207021849.52988-12-andrew.boyer@amd.com", "date": "2024-02-07T02:18:47", "name": "[v2,11/13] net/ionic: optimize device close operation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "06e05452764e89a8304568fe4e50a3c8bb6fe5f9", "submitter": { "id": 2861, "url": "http://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240207021849.52988-12-andrew.boyer@amd.com/mbox/", "series": [ { "id": 31027, "url": "http://patches.dpdk.org/api/series/31027/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31027", "date": "2024-02-07T02:18:47", "name": null, "version": 2, "mbox": "http://patches.dpdk.org/series/31027/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136453/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/136453/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D1CA43A1B;\n\tWed, 7 Feb 2024 03:20:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 776E842DEA;\n\tWed, 7 Feb 2024 03:20:06 +0100 (CET)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2060.outbound.protection.outlook.com [40.107.223.60])\n by mails.dpdk.org (Postfix) with ESMTP id A123F42D91\n for <dev@dpdk.org>; Wed, 7 Feb 2024 03:19:59 +0100 (CET)", "from PR3PR09CA0015.eurprd09.prod.outlook.com (2603:10a6:102:b7::20)\n by IA1PR12MB8189.namprd12.prod.outlook.com (2603:10b6:208:3f0::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.16; Wed, 7 Feb\n 2024 02:19:57 +0000", "from SA2PEPF000015CC.namprd03.prod.outlook.com\n (2603:10a6:102:b7:cafe::af) by PR3PR09CA0015.outlook.office365.com\n (2603:10a6:102:b7::20) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend\n Transport; Wed, 7 Feb 2024 02:19:56 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n SA2PEPF000015CC.mail.protection.outlook.com (10.167.241.202) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7249.19 via Frontend Transport; Wed, 7 Feb 2024 02:19:56 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 6 Feb\n 2024 20:19:50 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=akG67OpSk0OoSoo3uRka0YrXXyefenLvQBX7lpznm/YRsXdaOJiZUMgRQOPJ2aDZ72O7HYMvmEfoxJB1aN1BgzL6i/Zog68H7tPheNmpgEVNF1zK7KNDkpJN/o4KsnrPFL/jhrE0t9lw+i9NEQGHzmDuGll4g82SF3gHfgBJ9ksdp75u8T2lb/CYD8ixuLyOFdPsd48mLc1YNtrRDO5+k4VLT8EclGz1R5FrftHh3e+gtMYqsWuLrhWz/zWISqpFrRBGkKjXnQPltepOnjpLfl/PSv3Nf6p2SSkNpguIGFmq1DakqgR8b9Ex21QT/lffktjGrTq0+/Thzbg9HR+7jA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=5J3092k9T17Wa49OVwS9Nv2UbOxevuyZkdD+SgnvS44=;\n b=fmbjrvUUhmwxfMWzdSc8cOsVWkm7lAfHaZezS9GNnqqblggqo4d62XTh2KVKF7XirpQX0G1cSV5SPwyqhS6NSkP5xx8cMbViZiBGishNrxQvyL26bU2Sg2qzAPy+ZBbVKpwqZx2dY98fiXQeCRoK5HpoE2YgyKdMulBVebsZdVu490FmEt6Qk1/2PnsVfs/FIT5JDiW8sa8AzxkJvSlx9PnYk+agswR+V69HDgckjXogGeMDmG14oo0xq8bbkgYUZ3EZyNmoBqGJwY14vVKAZG8Xi5PmJgXOj5o2Wg7oalglDjnzafRISxPPgZGx9Iw6hSh+BxZk1RNLkEFh9uk+Rw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=5J3092k9T17Wa49OVwS9Nv2UbOxevuyZkdD+SgnvS44=;\n b=nlJNK13HWIVUZ5BISZcX3OY83opVoBtMyxccKSzVT9LzR/LSzAI+beScUwYQDenexkgCHDKB65WXUPow6sSbLAsivwARFg1nOTZNd5DaYxmXvc7K++3ZriQPUZIs+rwZCD7oDUPvDjLfLH4zqg8Ml8wj1hPlQKwBButYT6JnEdE=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH v2 11/13] net/ionic: optimize device close operation", "Date": "Tue, 6 Feb 2024 18:18:47 -0800", "Message-ID": "<20240207021849.52988-12-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240202193238.62669-1-andrew.boyer@amd.com>", "References": "<20240202193238.62669-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SA2PEPF000015CC:EE_|IA1PR12MB8189:EE_", "X-MS-Office365-Filtering-Correlation-Id": "9b888c73-959c-4db8-da4f-08dc2783471b", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n rO3ATrPK9Mi6ZmpFc8JXxQUiGbPajn9laYNWrykwaM974qgVgzQduhmFySLjExQYUH3+Pff8V4CETJHg5/cPrMEqhb+ouNscqck4euQLTsjuP/en3YffmHTL3UiII7G19KJZLhx0X6wKgGwdbpNlO3NOrrRwBLyYh36Kg7G5ISb9PotofJBrXDjLA+Le7gz25u5QDVCwf6mPcDgF37BGRk4m0Jir4W9z08hhu/gE+prnmzsxKLA9x40OMY6WxSbPZ4o2ekz0/ZHB+Q+9bj0Yv2sUKa7+maZAQ8aI/q2Lz3qcRYeRfc5RjOgJ0gZRIwfXq19FX+EIJ/95Xyp1Z9eY8Llr5CC4NUtF3wZlGkCVgtCjt8RIDDtVg8A+S6EUMSW4YybF2g1vzMZBKU2in6UCaN8ih782rLvbaZ5iWOc4krc296aCo+1B2lAZlpcYO5SHfoMA2xKTOxr2Q0oigDiQIV2HYTCs3cupUG8H1WGCxzaJMbjpRm+uhv8e1crFemy52hqotJyQ7jc7vSaZBkqcfkPqP56yri0yE18jzZJL4SJ07xa8eVMPU4cOYQMvPZOHQQdZq9HHDCLaYNZhwEXweGSsq+DlXGLy6NWSXvshZ53EaOOVwM0Xlznz30uaDzvmMdYwcSIjgqP0Mh4LUBpCuTw/V9O9U/k0fAWuUUoC27YunCCgytOZ0M4V70+5i5aChObJyvf9ZCqWXLZ6T+IqtPahcNtkNi3s7Lvn0229VLNPoooeLe0XSm8HsjJMvddEEa2eJQ66ToaDumL4UnXluw==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(376002)(396003)(346002)(39860400002)(136003)(230922051799003)(64100799003)(186009)(82310400011)(451199024)(1800799012)(36840700001)(46966006)(40470700004)(2616005)(40480700001)(40460700003)(6666004)(83380400001)(1076003)(26005)(336012)(426003)(356005)(36756003)(82740400003)(86362001)(2906002)(81166007)(4326008)(5660300002)(8936002)(41300700001)(8676002)(47076005)(16526019)(44832011)(36860700001)(70586007)(316002)(6916009)(70206006)(478600001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Feb 2024 02:19:56.5099 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9b888c73-959c-4db8-da4f-08dc2783471b", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SA2PEPF000015CC.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "IA1PR12MB8189", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use a single device reset command to speed up dev_close(). The LIF stop\nand port reset commands are not needed.\nThis reduces the outage window when restarting the process by about 2ms\nplus another 1ms per queue.\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_ethdev.c | 3 ---\n drivers/net/ionic/ionic_lif.c | 8 +-------\n 2 files changed, 1 insertion(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex bedcf958e2..7e80751846 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -1007,13 +1007,10 @@ ionic_dev_close(struct rte_eth_dev *eth_dev)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n-\tionic_lif_stop(lif);\n-\n \tIONIC_PRINT(NOTICE, \"Removing device %s\", eth_dev->device->name);\n \tif (adapter->intf->unconfigure_intr)\n \t\t(*adapter->intf->unconfigure_intr)(adapter);\n \n-\tionic_port_reset(adapter);\n \tionic_reset(adapter);\n \n \tionic_lif_free_queues(lif);\ndiff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex 2713f8aa24..90efcc8cbb 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -1231,13 +1231,7 @@ ionic_lif_rss_setup(struct ionic_lif *lif)\n static void\n ionic_lif_rss_teardown(struct ionic_lif *lif)\n {\n-\tif (!lif->rss_ind_tbl)\n-\t\treturn;\n-\n-\tif (lif->rss_ind_tbl_z) {\n-\t\t/* Disable RSS on the NIC */\n-\t\tionic_lif_rss_config(lif, 0x0, NULL, NULL);\n-\n+\tif (lif->rss_ind_tbl) {\n \t\tlif->rss_ind_tbl = NULL;\n \t\tlif->rss_ind_tbl_pa = 0;\n \t\trte_memzone_free(lif->rss_ind_tbl_z);\n", "prefixes": [ "v2", "11/13" ] }