Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136444/?format=api
{ "id": 136444, "url": "http://patches.dpdk.org/api/patches/136444/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240207021849.52988-2-andrew.boyer@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240207021849.52988-2-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240207021849.52988-2-andrew.boyer@amd.com", "date": "2024-02-07T02:18:37", "name": "[v2,01/13] net/ionic: add stat for completion queue entries processed", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fc7267c3535bfeda5cd49ab71d7063f46d1b09df", "submitter": { "id": 2861, "url": "http://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240207021849.52988-2-andrew.boyer@amd.com/mbox/", "series": [ { "id": 31018, "url": "http://patches.dpdk.org/api/series/31018/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31018", "date": "2024-02-07T02:18:37", "name": "[v2,01/13] net/ionic: add stat for completion queue entries processed", "version": 2, "mbox": "http://patches.dpdk.org/series/31018/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136444/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136444/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B905A43A1B;\n\tWed, 7 Feb 2024 03:19:39 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A0A1F402EA;\n\tWed, 7 Feb 2024 03:19:39 +0100 (CET)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2050.outbound.protection.outlook.com [40.107.237.50])\n by mails.dpdk.org (Postfix) with ESMTP id ADDB940151\n for <dev@dpdk.org>; Wed, 7 Feb 2024 03:19:38 +0100 (CET)", "from PR3PR09CA0003.eurprd09.prod.outlook.com (2603:10a6:102:b7::8)\n by CH0PR12MB5137.namprd12.prod.outlook.com (2603:10b6:610:bc::24) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Wed, 7 Feb\n 2024 02:19:36 +0000", "from SA2PEPF000015CC.namprd03.prod.outlook.com\n (2603:10a6:102:b7:cafe::11) by PR3PR09CA0003.outlook.office365.com\n (2603:10a6:102:b7::8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend\n Transport; Wed, 7 Feb 2024 02:19:33 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n SA2PEPF000015CC.mail.protection.outlook.com (10.167.241.202) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7249.19 via Frontend Transport; Wed, 7 Feb 2024 02:19:32 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 6 Feb\n 2024 20:19:31 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Z4eU9/apFsiDYKQrZvK9FYiFGLpfp4XM/McZHqKYH4fPHKR+RrL7xYoYCJZ196FOYgNGxcgirhy2GuLYjAqHOOfDFQ+HtAiiGyBhXNPkapqqbZJMkjRyRlgtkX/16m5HmR5sJqopLRYR8PdLwBEXRzJ//5tV4kd4+Blfukc6/jYVUxEyK6jwyNudaf/KDx+p4i9HNGpxAS4EXfY5QgKjxHx0JttxriRWDdYqvN/xLzp20GNYyIhs3zpgZeck6Bsnh/qg/zEhtLSizzPekE9sH25RKbaaHy2Lk/7/NRwlmcnIdnDbTVJ28ZgJ8ODtKVa74/IV8VlyLDSWvwZS5eUYRQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=VnjUuTNvh3P1kmLlB8IDpihoHlmAO5FwR2yDIWgbrWY=;\n b=SMi86L29PzJjRD4fko3OcuUAUVK3x6scnoobMKWgHodCmkcI9j4ZbHLplBriGJewV132NAguy4VBXLJMM/fdOye/vIohwf0bQdqRn/gZYurAurZLPGVi/IlViscwN248jErUEcCCCfHahAP/mcr8Ks0NuTdEpliiVbmW2L+pM5nZrSaU/DjJUj7JvrwxNY9xtN/Q0q4EPz+Hc6Xn85yzjnQSPxsFxoV/1z+XXSqMdaGk0oPFCgvi8wtc2HmbnmdzPDqSTkpj0/TvHjLl3BWzULmfLOO7lGYpxd5c0vMY5Vd/jjIpsDRoJe1yQvB16KxiDRWcgWddj3/d//gQ2lWORA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=VnjUuTNvh3P1kmLlB8IDpihoHlmAO5FwR2yDIWgbrWY=;\n b=c1xCKhkSr49WGFgwnrQRTfhkFITYCQqbukXzBL8kyldjZKpqvWhbpUHJQQW5Gh5t179xJOcNPgRArS6zZoJxy3mEfsm+n/NGt0vOppFDPfBK/Eo0UU/mZFKuvFIdCMAyxD5p4Rstw5y7nA3DbL1sNCsb7YAodOvnOvqtGTVVae0=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH v2 01/13] net/ionic: add stat for completion queue entries\n processed", "Date": "Tue, 6 Feb 2024 18:18:37 -0800", "Message-ID": "<20240207021849.52988-2-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20240202193238.62669-1-andrew.boyer@amd.com>", "References": "<20240202193238.62669-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SA2PEPF000015CC:EE_|CH0PR12MB5137:EE_", "X-MS-Office365-Filtering-Correlation-Id": "aa553522-8575-45ed-1f71-08dc278338ef", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n RiBBFFcC4gJjAJWZxOPy+cui9ZStYdCUnYxykm7zz44ilfkTAYWZVCqpcmXtgUhsUxfqXqmjBl8ttopDoT88R1GaPnOYUHHOBQX5ySgMkstWCx1ifcEYtEUxF/OptA+zdaY55ylzfhOjJN7OZEFt75Mwfv5t8YYKw0q2MVjAP4Mo4XZycwG1gzcJ9/ssB6z3SiJuXzY1GcmFrO02ViXfiNV5vhHgd+ZX88kIYZGvYO9U9VukE/pqzf/lxyhzl0svQeHz/BQHy/6gMwy+FNlhPEARi1MdvgpXufSbdpxtvTyOM+6tMJ+k1wi+AqzotuEdkxL44h2Rd7Mzbj2xINiutXa9B2Z9YqyN7b+esnCRzkDL4l5n/SzlIy5iWj9USBdljN306yXbiKhD4YLp7UaKAZsJRx6ask45sp78PzJzxEsUpbEpS+NGROLGR6QH3H5O8EPLrIBioFHgE16hPN0E3konAT/nVBnKzGF526FxO27Tx8P9FNdi1LVsGrG+aj9twZilJDEdk8sYI9AZ6uKCpy6vC2S/dRbOn4+vQ+gtdtgIyBgSnUoiGTgwa2oL8xHAuOn7iTG6DsegascQLB5D1MgmV+9NPjRk/uK9fYLwZB5rHUcuBOPpn/uzXoFk6TJCl+rtmKRieI2/uKZRImFZAv12SZjxF6ddmW217GtqKMpJfxsDXQ4LIPZuhd9ohbL2H0ganpllJwVy1UadPuLa8Zep0lyEHzWQglbyCIVzV1g5TDE86GAYrKZsY8wQ5c5FnTPVkmFh2SSDwO+q3P9q5w==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(396003)(136003)(376002)(346002)(39860400002)(230922051799003)(451199024)(64100799003)(82310400011)(186009)(1800799012)(40470700004)(36840700001)(46966006)(40460700003)(40480700001)(86362001)(26005)(41300700001)(2906002)(36756003)(44832011)(1076003)(16526019)(82740400003)(81166007)(356005)(36860700001)(316002)(47076005)(6916009)(8676002)(478600001)(336012)(70586007)(8936002)(5660300002)(70206006)(426003)(2616005)(4326008)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Feb 2024 02:19:32.6505 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n aa553522-8575-45ed-1f71-08dc278338ef", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SA2PEPF000015CC.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH0PR12MB5137", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When completion coalescing is turned on in the FW, there will be\nfewer CQE than Tx packets. Expose the stat through debug logging.\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_lif.h | 1 +\n drivers/net/ionic/ionic_rxtx.c | 3 +++\n drivers/net/ionic/ionic_rxtx_sg.c | 2 ++\n drivers/net/ionic/ionic_rxtx_simple.c | 2 ++\n 4 files changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex 36b3bcc5a9..cac7a4583b 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -32,6 +32,7 @@\n struct ionic_tx_stats {\n \tuint64_t packets;\n \tuint64_t bytes;\n+\tuint64_t comps;\n \tuint64_t drop;\n \tuint64_t stop;\n \tuint64_t no_csum;\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex b9e73b4871..d92b231f8f 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -117,6 +117,9 @@ ionic_dev_tx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id)\n \tstats = &txq->stats;\n \tIONIC_PRINT(DEBUG, \"TX queue %u pkts %ju tso %ju\",\n \t\ttxq->qcq.q.index, stats->packets, stats->tso);\n+\tIONIC_PRINT(DEBUG, \"TX queue %u comps %ju (%ju per)\",\n+\t\ttxq->qcq.q.index, stats->comps,\n+\t\tstats->comps ? stats->packets / stats->comps : 0);\n \n \treturn 0;\n }\ndiff --git a/drivers/net/ionic/ionic_rxtx_sg.c b/drivers/net/ionic/ionic_rxtx_sg.c\nindex ab8e56e91c..6c028a698c 100644\n--- a/drivers/net/ionic/ionic_rxtx_sg.c\n+++ b/drivers/net/ionic/ionic_rxtx_sg.c\n@@ -26,6 +26,7 @@ ionic_tx_flush_sg(struct ionic_tx_qcq *txq)\n {\n \tstruct ionic_cq *cq = &txq->qcq.cq;\n \tstruct ionic_queue *q = &txq->qcq.q;\n+\tstruct ionic_tx_stats *stats = &txq->stats;\n \tstruct rte_mbuf *txm;\n \tstruct ionic_txq_comp *cq_desc, *cq_desc_base = cq->base;\n \tvoid **info;\n@@ -72,6 +73,7 @@ ionic_tx_flush_sg(struct ionic_tx_qcq *txq)\n \t\t}\n \n \t\tcq_desc = &cq_desc_base[cq->tail_idx];\n+\t\tstats->comps++;\n \t}\n }\n \ndiff --git a/drivers/net/ionic/ionic_rxtx_simple.c b/drivers/net/ionic/ionic_rxtx_simple.c\nindex 5f81856256..5969287b66 100644\n--- a/drivers/net/ionic/ionic_rxtx_simple.c\n+++ b/drivers/net/ionic/ionic_rxtx_simple.c\n@@ -26,6 +26,7 @@ ionic_tx_flush(struct ionic_tx_qcq *txq)\n {\n \tstruct ionic_cq *cq = &txq->qcq.cq;\n \tstruct ionic_queue *q = &txq->qcq.q;\n+\tstruct ionic_tx_stats *stats = &txq->stats;\n \tstruct rte_mbuf *txm;\n \tstruct ionic_txq_comp *cq_desc, *cq_desc_base = cq->base;\n \tvoid **info;\n@@ -67,6 +68,7 @@ ionic_tx_flush(struct ionic_tx_qcq *txq)\n \t\t}\n \n \t\tcq_desc = &cq_desc_base[cq->tail_idx];\n+\t\tstats->comps++;\n \t}\n }\n \n", "prefixes": [ "v2", "01/13" ] }