Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136356/?format=api
http://patches.dpdk.org/api/patches/136356/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240203041230.285599-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240203041230.285599-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240203041230.285599-2-stephen@networkplumber.org", "date": "2024-02-03T04:11:34", "name": "[v7,01/19] common/sfc_efx: remove use of PMD logtype", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3fe77a4e9cb5f8a045acfe5ab86eafe29fd79dec", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240203041230.285599-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 30996, "url": "http://patches.dpdk.org/api/series/30996/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30996", "date": "2024-02-03T04:11:33", "name": "Replace uses of RTE_LOGTYPE_PMD", "version": 7, "mbox": "http://patches.dpdk.org/series/30996/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136356/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/136356/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 835CF43A57;\n\tSat, 3 Feb 2024 05:12:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BCD1642E3B;\n\tSat, 3 Feb 2024 05:12:46 +0100 (CET)", "from mail-pj1-f50.google.com (mail-pj1-f50.google.com\n [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id 6F15E4028C\n for <dev@dpdk.org>; Sat, 3 Feb 2024 05:12:44 +0100 (CET)", "by mail-pj1-f50.google.com with SMTP id\n 98e67ed59e1d1-295d22bd625so2058288a91.1\n for <dev@dpdk.org>; Fri, 02 Feb 2024 20:12:44 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.12.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 02 Feb 2024 20:12:43 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933563;\n x=1707538363; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=YyBqO/sb6UeQ4NeBuhZ1nXTlTFjLIN4jayiZCG0GWMs=;\n b=3HOib+8tzdCrRytFnpv0KFU/PRM7P44Xkb3Uj5kG2sjP9JYiCI/fZZU/WRRfc9cKmt\n RE3p/FIden9bG8vCCskNrk3vNaRALiWdRMeNb+nOa8Mm3Gqsw65emupvL8HSZ+a3ny6U\n avY4lYsQ/Ec8kjhhwCQp2lH68Md7wLTN27F7/5mIHqw4vImzwYWmjuiHDUuqxsHxD/OF\n uH1T2R4X5pu4OcybtdKJ3pX0KnE/10GNnb8hi8psSTWg/CiqdYcA6TBPBz11etOXpYGq\n zm/aWDKX9q3gMvuKAH1zGRPV94/QqO+vicyY64vkGkT2/eRy5U2njyvKE6hZqoyQxxyL\n q39g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1706933563; x=1707538363;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=YyBqO/sb6UeQ4NeBuhZ1nXTlTFjLIN4jayiZCG0GWMs=;\n b=mh12FDW5ToYkwy1RkXdEHYlLWAVR0/hJovSA/qT1xZAOyHKS9nj9ANeQzPGvpFVnRL\n ikKTJV3t+vOPFFTKDAJ4xrX5OmhZPf0rH/r2UXd1J3BtSj4DgpJEMX/5uTjspn0DlhSG\n g6YhOBmVtndiIFyUtoPMHuHwDSKYnIcMS91+Fq8adXhLGJ1FSGqmOEnhRYuXibSHgvjm\n OOI1lFQtSTGVfFQcpEX4AQOXOdMm0XKI5x8OtpVP19SAagz7LFnmErLUWkWILPHNh6L+\n dmZqGrcl8BlraN1km6lsLgvxxcOj/U2K/YHJvGm56r8U9biOkDehEMxglVqSKRyavzPx\n ByiA==", "X-Gm-Message-State": "AOJu0YwS735cFmsBTcrNQeFjgTF2nO0K4dTSgc6bGeNdwfS+G2aSfoYj\n /EVh7kGb6w+/XUkDZ5HfaMR0cHfN+M1rT7rQD0xPAnFmjUZSQLkEIBYfcd5B55zgXQdff3kvxKj\n 5Kok=", "X-Google-Smtp-Source": "\n AGHT+IFnLh3P/pkboEFd3WJXYkCvRGVTIP1M8iafusSg75RWkyJMy6xlUSzXnZN3Z2qnI+HPf5ILHg==", "X-Received": "by 2002:a17:903:22cd:b0:1d9:4d3f:cbf6 with SMTP id\n y13-20020a17090322cd00b001d94d3fcbf6mr4314353plg.48.1706933563645;\n Fri, 02 Feb 2024 20:12:43 -0800 (PST)", "X-Forwarded-Encrypted": "i=0;\n AJvYcCWIyoiazHDEGXyeWc7v8ni6tNOhKN8VkyKBmSZ6pkMl+ouo2U6MK4W5bJLkIUMz16y8aNjBJxWF7cs4p+tW5eQU/FvcI+5bf/bVvYGnCg==", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[PATCH v7 01/19] common/sfc_efx: remove use of PMD logtype", "Date": "Fri, 2 Feb 2024 20:11:34 -0800", "Message-ID": "<20240203041230.285599-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240203041230.285599-1-stephen@networkplumber.org>", "References": "<20231213014408.612051-1-stephen@networkplumber.org>\n <20240203041230.285599-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This code was implemented in a slightly different manner\nthan all the other logging code (for no good reason).\nMake it the same and handle errors in same way as\nother drivers.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/sfc_efx/sfc_efx.c | 11 ++---------\n drivers/common/sfc_efx/sfc_efx_log.h | 2 +-\n 2 files changed, 3 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/sfc_efx.c b/drivers/common/sfc_efx/sfc_efx.c\nindex 2dc5545760b8..5eeffb065b0d 100644\n--- a/drivers/common/sfc_efx/sfc_efx.c\n+++ b/drivers/common/sfc_efx/sfc_efx.c\n@@ -15,7 +15,7 @@\n #include \"sfc_efx_log.h\"\n #include \"sfc_efx.h\"\n \n-uint32_t sfc_efx_logtype;\n+int sfc_efx_logtype;\n \n static int\n sfc_efx_kvarg_dev_class_handler(__rte_unused const char *key,\n@@ -117,11 +117,4 @@ sfc_efx_family(struct rte_pci_device *pci_dev,\n \treturn rc;\n }\n \n-RTE_INIT(sfc_efx_register_logtype)\n-{\n-\tint ret;\n-\n-\tret = rte_log_register_type_and_pick_level(\"pmd.common.sfc_efx\",\n-\t\t\t\t\t\t RTE_LOG_NOTICE);\n-\tsfc_efx_logtype = (ret < 0) ? RTE_LOGTYPE_PMD : ret;\n-}\n+RTE_LOG_REGISTER_DEFAULT(sfc_efx_logtype, NOTICE);\ndiff --git a/drivers/common/sfc_efx/sfc_efx_log.h b/drivers/common/sfc_efx/sfc_efx_log.h\nindex 694455c1b14e..1519ebdc175f 100644\n--- a/drivers/common/sfc_efx/sfc_efx_log.h\n+++ b/drivers/common/sfc_efx/sfc_efx_log.h\n@@ -11,7 +11,7 @@\n #define _SFC_EFX_LOG_H_\n \n /** Generic driver log type */\n-extern uint32_t sfc_efx_logtype;\n+extern int sfc_efx_logtype;\n \n /** Log message, add a prefix and a line break */\n #define SFC_EFX_LOG(level, ...) \\\n", "prefixes": [ "v7", "01/19" ] }{ "id": 136356, "url": "