Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 136285,
    "url": "http://patches.dpdk.org/api/patches/136285/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240201154303.2388178-1-venkatx.sivaramakrishnan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20240201154303.2388178-1-venkatx.sivaramakrishnan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20240201154303.2388178-1-venkatx.sivaramakrishnan@intel.com",
    "date": "2024-02-01T15:43:02",
    "name": "[v7,1/2] drivers/net: fix buffer overflow for ptypes list",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "59322bcd043ef23eaee9f35ee2efb334d710fda3",
    "submitter": {
        "id": 3155,
        "url": "http://patches.dpdk.org/api/people/3155/?format=api",
        "name": "Sivaramakrishnan Venkat",
        "email": "venkatx.sivaramakrishnan@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240201154303.2388178-1-venkatx.sivaramakrishnan@intel.com/mbox/",
    "series": [
        {
            "id": 30969,
            "url": "http://patches.dpdk.org/api/series/30969/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30969",
            "date": "2024-02-01T15:43:02",
            "name": "[v7,1/2] drivers/net: fix buffer overflow for ptypes list",
            "version": 7,
            "mbox": "http://patches.dpdk.org/series/30969/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/136285/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/136285/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5FF3D43A3C;\n\tThu,  1 Feb 2024 16:43:12 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 228F342E13;\n\tThu,  1 Feb 2024 16:43:12 +0100 (CET)",
            "from mgamail.intel.com (mgamail.intel.com [198.175.65.11])\n by mails.dpdk.org (Postfix) with ESMTP id B8D4942D3F;\n Thu,  1 Feb 2024 16:43:10 +0100 (CET)",
            "from fmviesa005.fm.intel.com ([10.60.135.145])\n by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Feb 2024 07:43:10 -0800",
            "from silpixa00400902.ir.intel.com ([10.243.23.146])\n by fmviesa005.fm.intel.com with ESMTP; 01 Feb 2024 07:43:06 -0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1706802191; x=1738338191;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=gf4fQH6MF0SsO4YkRNvGgcECISw2HWbhczFaHyeB0yQ=;\n b=fwI1E9ogS+b7cdn0HDDYkkpIWwdPUKqu2x7wDjoha/RV0gZ7ARrqODnF\n xZ2ctv09nCli/+n+LRAv/GhOrExl5MQ9OYvihTPSyCrmXZLN2iLbJkj7q\n VFU2bsIOuTkCMrnaj31s0EPKLNq9a8HRKKJE1J4SJRSv8r3PwEhzYJtFZ\n YzZPaMBeipy3t/2Vr6MK/pyA5fy5afw7uSEnIjrAibaGcSuKVimv2NmL+\n jQnAxKR6KWiv69JnWgpxb0gBmc0B6qrSsXG63vwj2kxfMvLRrgSWC+wHA\n Gy4zSjlU08UskiqHJF1QhKIEgIKlTQECM24YCc2IMfikCtqRbIdjox2u6 A==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,10969\"; a=\"10551542\"",
            "E=Sophos;i=\"6.05,234,1701158400\"; d=\"scan'208\";a=\"10551542\"",
            "E=Sophos;i=\"6.05,234,1701158400\";\n   d=\"scan'208\";a=\"4418312\""
        ],
        "X-ExtLoop1": "1",
        "From": "Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>",
        "To": "Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>, Zyta Szpak <zr@semihalf.com>,\n Liron Himi <lironh@marvell.com>, Chaoyong He <chaoyong.he@corigine.com>,\n Gagandeep Singh <g.singh@nxp.com>, Jerin Jacob <jerinj@marvell.com>,\n Maciej Czekaj <mczekaj@marvell.com>",
        "Cc": "dev@dpdk.org, ferruh.yigit@amd.com, ciara.power@intel.com,\n Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>,\n pascal.mazon@6wind.com, shreyansh.jain@nxp.com, tdu@semihalf.com,\n qin.ke@corigine.com, jerin.jacob@caviumnetworks.com, stable@dpdk.org",
        "Subject": "[PATCH v7 1/2] drivers/net: fix buffer overflow for ptypes list",
        "Date": "Thu,  1 Feb 2024 15:43:02 +0000",
        "Message-Id": "<20240201154303.2388178-1-venkatx.sivaramakrishnan@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20231212143722.1803259-1-venkatx.sivaramakrishnan@intel.com>",
        "References": "<20231212143722.1803259-1-venkatx.sivaramakrishnan@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Address Sanitizer detects a buffer overflow caused by an incorrect\nptypes list. Missing \"RTE_PTYPE_UNKNOWN\" ptype causes buffer overflow.\nFix the ptypes list for drivers.\n\nFixes: 0849ac3b6122 (\"net/tap: add packet type management\")\nFixes: a7bdc3bd4244 (\"net/dpaa: support packet type parsing\")\nFixes: 4ccc8d770d3b (\"net/mvneta: add PMD skeleton\")\nFixes: f3f0d77db6b0 (\"net/mrvl: support packet type parsing\")\nFixes: 71e8bb65046e (\"net/nfp: update supported list of packet types\")\nFixes: 659b494d3d88 (\"net/pfe: add packet types and basic statistics\")\nFixes: 398a1be14168 (\"net/thunderx: remove generic passX references\")\n\nSigned-off-by: Sivaramakrishnan Venkat <venkatx.sivaramakrishnan@intel.com>\nReviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>\n---\nCc: pascal.mazon@6wind.com\nCc: shreyansh.jain@nxp.com\nCc: zr@semihalf.com\nCc: tdu@semihalf.com\nCc: qin.ke@corigine.com\nCc: g.singh@nxp.com\nCc: jerin.jacob@caviumnetworks.com\nCc: stable@dpdk.org\n\nv6: moved Cc email line after the \"--\" separator in the commit message.\nv5: modified commit message.\nv4: split into two patches, one for backporting and one for upstream rework\nv3: reworked the function to return number of elements and remove the need\n    for RTE_PTYPE_UNKNOWN in list.\nv2: extended fix for multiple drivers.\n---\n drivers/net/dpaa/dpaa_ethdev.c      | 3 ++-\n drivers/net/mvneta/mvneta_ethdev.c  | 3 ++-\n drivers/net/mvpp2/mrvl_ethdev.c     | 3 ++-\n drivers/net/nfp/nfp_net_common.c    | 1 +\n drivers/net/pfe/pfe_ethdev.c        | 3 ++-\n drivers/net/tap/rte_eth_tap.c       | 1 +\n drivers/net/thunderx/nicvf_ethdev.c | 2 ++\n 7 files changed, 12 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex ef4c06db6a..779bdc5860 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -363,7 +363,8 @@ dpaa_supported_ptypes_get(struct rte_eth_dev *dev)\n \t\tRTE_PTYPE_L4_TCP,\n \t\tRTE_PTYPE_L4_UDP,\n \t\tRTE_PTYPE_L4_SCTP,\n-\t\tRTE_PTYPE_TUNNEL_ESP\n+\t\tRTE_PTYPE_TUNNEL_ESP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \tPMD_INIT_FUNC_TRACE();\ndiff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c\nindex daa69e533a..212c300c14 100644\n--- a/drivers/net/mvneta/mvneta_ethdev.c\n+++ b/drivers/net/mvneta/mvneta_ethdev.c\n@@ -198,7 +198,8 @@ mvneta_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)\n \t\tRTE_PTYPE_L3_IPV4,\n \t\tRTE_PTYPE_L3_IPV6,\n \t\tRTE_PTYPE_L4_TCP,\n-\t\tRTE_PTYPE_L4_UDP\n+\t\tRTE_PTYPE_L4_UDP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \treturn ptypes;\ndiff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex c12364941d..4cc64c7cad 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -1777,7 +1777,8 @@ mrvl_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)\n \t\tRTE_PTYPE_L3_IPV6_EXT,\n \t\tRTE_PTYPE_L2_ETHER_ARP,\n \t\tRTE_PTYPE_L4_TCP,\n-\t\tRTE_PTYPE_L4_UDP\n+\t\tRTE_PTYPE_L4_UDP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \treturn ptypes;\ndiff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c\nindex e969b840d6..46d0e07850 100644\n--- a/drivers/net/nfp/nfp_net_common.c\n+++ b/drivers/net/nfp/nfp_net_common.c\n@@ -1299,6 +1299,7 @@ nfp_net_supported_ptypes_get(struct rte_eth_dev *dev)\n \t\tRTE_PTYPE_INNER_L4_NONFRAG,\n \t\tRTE_PTYPE_INNER_L4_ICMP,\n \t\tRTE_PTYPE_INNER_L4_SCTP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \tif (dev->rx_pkt_burst != nfp_net_recv_pkts)\ndiff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c\nindex 551f3cf193..0073dd7405 100644\n--- a/drivers/net/pfe/pfe_ethdev.c\n+++ b/drivers/net/pfe/pfe_ethdev.c\n@@ -520,7 +520,8 @@ pfe_supported_ptypes_get(struct rte_eth_dev *dev)\n \t\tRTE_PTYPE_L3_IPV6_EXT,\n \t\tRTE_PTYPE_L4_TCP,\n \t\tRTE_PTYPE_L4_UDP,\n-\t\tRTE_PTYPE_L4_SCTP\n+\t\tRTE_PTYPE_L4_SCTP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \tif (dev->rx_pkt_burst == pfe_recv_pkts ||\ndiff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex b41fa971cb..3fa03cdbee 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -1803,6 +1803,7 @@ tap_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)\n \t\tRTE_PTYPE_L4_UDP,\n \t\tRTE_PTYPE_L4_TCP,\n \t\tRTE_PTYPE_L4_SCTP,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \n \treturn ptypes;\ndiff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c\nindex a504d41dfe..5a0c3dc4a6 100644\n--- a/drivers/net/thunderx/nicvf_ethdev.c\n+++ b/drivers/net/thunderx/nicvf_ethdev.c\n@@ -392,12 +392,14 @@ nicvf_dev_supported_ptypes_get(struct rte_eth_dev *dev)\n \t\tRTE_PTYPE_L4_TCP,\n \t\tRTE_PTYPE_L4_UDP,\n \t\tRTE_PTYPE_L4_FRAG,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \tstatic const uint32_t ptypes_tunnel[] = {\n \t\tRTE_PTYPE_TUNNEL_GRE,\n \t\tRTE_PTYPE_TUNNEL_GENEVE,\n \t\tRTE_PTYPE_TUNNEL_VXLAN,\n \t\tRTE_PTYPE_TUNNEL_NVGRE,\n+\t\tRTE_PTYPE_UNKNOWN\n \t};\n \tstatic const uint32_t ptypes_end = RTE_PTYPE_UNKNOWN;\n \n",
    "prefixes": [
        "v7",
        "1/2"
    ]
}