Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/136210/?format=api
{ "id": 136210, "url": "http://patches.dpdk.org/api/patches/136210/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240130035820.29713-1-lihuisong@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240130035820.29713-1-lihuisong@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240130035820.29713-1-lihuisong@huawei.com", "date": "2024-01-30T03:58:19", "name": "[RFC] ethdev: introduce PTP device capability", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a9574a49130eb97ebc9b93f10d249d70f038a8d6", "submitter": { "id": 2085, "url": "http://patches.dpdk.org/api/people/2085/?format=api", "name": "lihuisong (C)", "email": "lihuisong@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240130035820.29713-1-lihuisong@huawei.com/mbox/", "series": [ { "id": 30936, "url": "http://patches.dpdk.org/api/series/30936/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30936", "date": "2024-01-30T03:58:19", "name": "[RFC] ethdev: introduce PTP device capability", "version": 1, "mbox": "http://patches.dpdk.org/series/30936/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/136210/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/136210/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A86D443A05;\n\tTue, 30 Jan 2024 04:59:08 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 80C954029A;\n\tTue, 30 Jan 2024 04:59:08 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 9D9D440275\n for <dev@dpdk.org>; Tue, 30 Jan 2024 04:59:07 +0100 (CET)", "from mail.maildlp.com (unknown [172.19.88.194])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4TPBG95xsmzsWdP;\n Tue, 30 Jan 2024 11:57:53 +0800 (CST)", "from kwepemm600004.china.huawei.com (unknown [7.193.23.242])\n by mail.maildlp.com (Postfix) with ESMTPS id 2DE281400FF;\n Tue, 30 Jan 2024 11:59:04 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.35; Tue, 30 Jan 2024 11:59:03 +0800" ], "From": "Huisong Li <lihuisong@huawei.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<ferruh.yigit@intel.com>", "Subject": "[RFC] ethdev: introduce PTP device capability", "Date": "Tue, 30 Jan 2024 11:58:19 +0800", "Message-ID": "<20240130035820.29713-1-lihuisong@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemm600004.china.huawei.com (7.193.23.242)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently, the PTP feature is a little messy and has some issue.\n1> There is different implementation for PTP. This feature of some\n hardware depends on the Rx HW timestamp offload, and use this\n offload to detect if enable PTP feature. Others can enable PTP\n feature with only ethdev ops.\n2> For some drivers, enabling PTP feature also depends on the macro\n RTE_LIBRTE_IEEE1588. Actually, whether device support, enable\n or disable this feature should not be determined at compilation\n time. This has been discussed in thread [1].\n3> The user haven't a good way to distinguish which port supports\n the PTP feature in the case that a couple of device belong to the\n same driver. And PTP related API in ethdev layer doesn't do check\n for PTP capability. This has been mentioned and discussed in\n thread [2].\n\nIn the thread [1], there is a conclusion that remove the compiling\nmacro RTE_LIBRTE_IEEE1588. And in the thread [2], there is a common\nopinion that the RTE_ETH_RX_OFFLOAD_TIMESTAMP cannot be used as the\nPTP capability.\n\nFor the above issuse, this patch introduces a PTP capability in\nrte_eth_dev_info.dev_capa to report PTP capability.\n\nWelcome to jumping into discussion.\n\n[1] https://patchwork.dpdk.org/project/dpdk/patch/20230203132810.14187-1-thomas@monjalon.net/\n[2] https://inbox.dpdk.org/dev/20230817084226.55327-1-lihuisong@huawei.com/\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\n lib/ethdev/rte_ethdev.h | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex efa4f12b2a..4c8bd691bd 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -1613,6 +1613,12 @@ struct rte_eth_conf {\n #define RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP RTE_BIT64(3)\n /** Device supports keeping shared flow objects across restart. */\n #define RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP RTE_BIT64(4)\n+/**\n+ * Device supports PTP feature.\n+ * For some hardware, this feature also need to set the offload\n+ * RTE_ETH_RX_OFFLOAD_TIMESTAMP, please check rte_eth_dev_info.rx_offload_capa.\n+ */\n+#define RTE_ETH_DEV_CAPA_PTP RTE_BIT64(5)\n /**@}*/\n \n /*\n", "prefixes": [ "RFC" ] }