Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135999/?format=api
http://patches.dpdk.org/api/patches/135999/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240119174346.108905-8-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240119174346.108905-8-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240119174346.108905-8-bruce.richardson@intel.com", "date": "2024-01-19T17:43:42", "name": "[v2,07/11] eventdev: fix documentation for counting single-link ports", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "79315e4d96b48ea1155455810d35a3db3205a80a", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240119174346.108905-8-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30860, "url": "http://patches.dpdk.org/api/series/30860/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30860", "date": "2024-01-19T17:43:35", "name": "improve eventdev API specification/documentation", "version": 2, "mbox": "http://patches.dpdk.org/series/30860/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135999/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135999/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1D30943901;\n\tFri, 19 Jan 2024 18:44:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9A26842DEC;\n\tFri, 19 Jan 2024 18:44:18 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n by mails.dpdk.org (Postfix) with ESMTP id 6AB1D42DEC;\n Fri, 19 Jan 2024 18:44:16 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Jan 2024 09:44:16 -0800", "from silpixa00400957.ir.intel.com (HELO\n silpixa00401385.ir.intel.com) ([10.237.214.26])\n by orsmga006.jf.intel.com with ESMTP; 19 Jan 2024 09:44:13 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1705686257; x=1737222257;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=DfoGN2SQUmfRnzneAdEIuu2MDo+I5e694eY3aUmQFFk=;\n b=RbhI+pRJZr+/wxzkwFBD+B3N9X5cz8J0cyw08ilOqV9oDe9ixWCXTSlv\n I6WmQpdBT75ZVRyAhEgN+Z3tZf2NYdqOD4rYee0ibtgtz3U1RXGcMx1jf\n hhJIZbCWkDiCym0fVwrzk9LnXWvjYwn5B/zvJbRSsbVBWX/SJGlnMQVX4\n NaZv8FTD6+Mkvb80RbdjSjXhhUngpJDjMuLPIy6yEpp2Eq9Yiq6vpmyHW\n 6kUhOJPiRY0zkOzYuJbQeu7MXi3hvw4LuUldt29LGfR6njCZxw7+A0OPw\n s5jXgqu0FwTWX3812CDs/bjaHbwdxYoqeYUV4XdomQPiAC2ogznWLIkb4 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10957\"; a=\"683730\"", "E=Sophos;i=\"6.05,204,1701158400\";\n d=\"scan'208\";a=\"683730\"", "E=McAfee;i=\"6600,9927,10957\"; a=\"761177794\"", "E=Sophos;i=\"6.05,204,1701158400\"; d=\"scan'208\";a=\"761177794\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "jerinj@marvell.com, mattias.ronnblom@ericsson.com,\n abdullah.sevincer@intel.com, sachin.saxena@oss.nxp.com,\n hemant.agrawal@nxp.com, pbhagavatula@marvell.com, pravin.pathak@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org", "Subject": "[PATCH v2 07/11] eventdev: fix documentation for counting single-link\n ports", "Date": "Fri, 19 Jan 2024 17:43:42 +0000", "Message-Id": "<20240119174346.108905-8-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20240119174346.108905-1-bruce.richardson@intel.com>", "References": "<20240118134557.73172-1-bruce.richardson@intel.com>\n <20240119174346.108905-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The documentation of how single-link port-queue pairs were counted in\nthe rte_event_dev_config structure did not match the actual\nimplementation and, if following the documentation, certain valid\nport/queue configurations would have been impossible to configure. Fix\nthis by changing the documentation to match the implementation - however\nconfusing that implementation ends up being.\n\nBugzilla ID: 1368\nFixes: 75d113136f38 (\"eventdev: express DLB/DLB2 PMD constraints\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/eventdev/rte_eventdev.h | 28 ++++++++++++++++++++++------\n 1 file changed, 22 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h\nindex 4139ccb982..3b8f5b8101 100644\n--- a/lib/eventdev/rte_eventdev.h\n+++ b/lib/eventdev/rte_eventdev.h\n@@ -490,7 +490,10 @@ struct rte_event_dev_info {\n \tuint32_t dequeue_timeout_ns;\n \t/**< Configured global dequeue timeout(ns) for this device */\n \tuint8_t max_event_queues;\n-\t/**< Maximum event queues supported by this device */\n+\t/**< Maximum event queues supported by this device.\n+\t * This excludes any queue-port pairs covered by the\n+\t * *max_single_link_event_port_queue_pairs* value in this structure.\n+\t */\n \tuint32_t max_event_queue_flows;\n \t/**< Maximum number of flows within an event queue supported by this device*/\n \tuint8_t max_event_queue_priority_levels;\n@@ -506,7 +509,10 @@ struct rte_event_dev_info {\n \t * @ref RTE_EVENT_DEV_PRIORITY_HIGHEST and @ref RTE_EVENT_DEV_PRIORITY_LOWEST.\n \t */\n \tuint8_t max_event_ports;\n-\t/**< Maximum number of event ports supported by this device */\n+\t/**< Maximum number of event ports supported by this device\n+\t * This excludes any queue-port pairs covered by the\n+\t * *max_single_link_event_port_queue_pairs* value in this structure.\n+\t */\n \tuint8_t max_event_port_dequeue_depth;\n \t/**< Maximum number of events that can be dequeued at a time from an event port\n \t * on this device.\n@@ -618,13 +624,23 @@ struct rte_event_dev_config {\n \t */\n \tuint8_t nb_event_queues;\n \t/**< Number of event queues to configure on this device.\n-\t * This value cannot exceed @ref rte_event_dev_info.max_event_queues\n-\t * returned by rte_event_dev_info_get()\n+\t * This value *includes* any single-link queue-port pairs to be used.\n+\t * This value cannot exceed @ref rte_event_dev_info.max_event_queues +\n+\t * @ref rte_event_dev_info.max_single_link_event_port_queue_pairs\n+\t * returned by rte_event_dev_info_get().\n+\t * The number of non-single-link queues i.e. this value less\n+\t * *nb_single_link_event_port_queues* in this struct, cannot exceed\n+\t * @ref rte_event_dev_info.max_event_queues\n \t */\n \tuint8_t nb_event_ports;\n \t/**< Number of event ports to configure on this device.\n-\t * This value cannot exceed @ref rte_event_dev_info.max_event_ports\n-\t * returned by rte_event_dev_info_get()\n+\t * This value *includes* any single-link queue-port pairs to be used.\n+\t * This value cannot exceed @ref rte_event_dev_info.max_event_ports +\n+\t * @ref rte_event_dev_info.max_single_link_event_port_queue_pairs\n+\t * returned by rte_event_dev_info_get().\n+\t * The number of non-single-link ports i.e. this value less\n+\t * *nb_single_link_event_port_queues* in this struct, cannot exceed\n+\t * @ref rte_event_dev_info.max_event_ports\n \t */\n \tuint32_t nb_event_queue_flows;\n \t/**< Max number of flows needed for a single event queue on this device.\n", "prefixes": [ "v2", "07/11" ] }{ "id": 135999, "url": "