Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135960/?format=api
{ "id": 135960, "url": "http://patches.dpdk.org/api/patches/135960/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240118134557.73172-8-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240118134557.73172-8-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240118134557.73172-8-bruce.richardson@intel.com", "date": "2024-01-18T13:45:57", "name": "[v1,7/7] eventdev: fix documentation for counting single-link ports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "79315e4d96b48ea1155455810d35a3db3205a80a", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240118134557.73172-8-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30838, "url": "http://patches.dpdk.org/api/series/30838/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30838", "date": "2024-01-18T13:45:50", "name": "improve eventdev API specification/documentation", "version": 1, "mbox": "http://patches.dpdk.org/series/30838/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135960/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135960/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C34D3438F3;\n\tThu, 18 Jan 2024 14:47:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6BDAA42DD6;\n\tThu, 18 Jan 2024 14:46:27 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by mails.dpdk.org (Postfix) with ESMTP id EEFC942DB6;\n Thu, 18 Jan 2024 14:46:24 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Jan 2024 05:46:25 -0800", "from silpixa00400957.ir.intel.com (HELO\n silpixa00401385.ir.intel.com) ([10.237.214.26])\n by orsmga003.jf.intel.com with ESMTP; 18 Jan 2024 05:46:21 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1705585585; x=1737121585;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=d9zfdXC5jS+0Zak46W9jh71OEYLEL5OgYuI7m3WAsJc=;\n b=JRo6zu+gfqA/XMoFjIICQ1N6ZyACrWsUhWCNm48TEOejdauIGpPKmwgi\n QGBgm4VmINrrcz5xUL655LOU/tuIF3hNfIGfAc6c+uTx2cHXlcDzIeMef\n 35seb2N8k+d1NedtEysIjkKfey7gKAsBhReolRnpSlx1kAQr9QfMwobiI\n GBACv/Cz4bYTLGLLq7bVDt04TnSlWuSTHZA+CgzW1rLWyRMjJAtHZOqDv\n qgDoxbzO55wKYPXIjr4xJ1K7w6B2v8oVlY/Ny3w2SxFN4KBQ39KI4yV0c\n eDZDVjkSqnTGS6tVa9FQ4I6+nXIrcH1FL+aTPZ3Zta5yCslNYftClc0EX A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10956\"; a=\"7542811\"", "E=Sophos;i=\"6.05,201,1701158400\";\n d=\"scan'208\";a=\"7542811\"", "E=McAfee;i=\"6600,9927,10956\"; a=\"734274164\"", "E=Sophos;i=\"6.05,201,1701158400\"; d=\"scan'208\";a=\"734274164\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org,\n Jerin Jacob <jerinj@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Timothy McDaniel <timothy.mcdaniel@intel.com>", "Subject": "[PATCH v1 7/7] eventdev: fix documentation for counting single-link\n ports", "Date": "Thu, 18 Jan 2024 13:45:57 +0000", "Message-Id": "<20240118134557.73172-8-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20240118134557.73172-1-bruce.richardson@intel.com>", "References": "<20240118134557.73172-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The documentation of how single-link port-queue pairs were counted in\nthe rte_event_dev_config structure did not match the actual\nimplementation and, if following the documentation, certain valid\nport/queue configurations would have been impossible to configure. Fix\nthis by changing the documentation to match the implementation - however\nconfusing that implementation ends up being.\n\nBugzilla ID: 1368\nFixes: 75d113136f38 (\"eventdev: express DLB/DLB2 PMD constraints\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/eventdev/rte_eventdev.h | 28 ++++++++++++++++++++++------\n 1 file changed, 22 insertions(+), 6 deletions(-)\n\n--\n2.40.1", "diff": "diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h\nindex 4139ccb982..3b8f5b8101 100644\n--- a/lib/eventdev/rte_eventdev.h\n+++ b/lib/eventdev/rte_eventdev.h\n@@ -490,7 +490,10 @@ struct rte_event_dev_info {\n \tuint32_t dequeue_timeout_ns;\n \t/**< Configured global dequeue timeout(ns) for this device */\n \tuint8_t max_event_queues;\n-\t/**< Maximum event queues supported by this device */\n+\t/**< Maximum event queues supported by this device.\n+\t * This excludes any queue-port pairs covered by the\n+\t * *max_single_link_event_port_queue_pairs* value in this structure.\n+\t */\n \tuint32_t max_event_queue_flows;\n \t/**< Maximum number of flows within an event queue supported by this device*/\n \tuint8_t max_event_queue_priority_levels;\n@@ -506,7 +509,10 @@ struct rte_event_dev_info {\n \t * @ref RTE_EVENT_DEV_PRIORITY_HIGHEST and @ref RTE_EVENT_DEV_PRIORITY_LOWEST.\n \t */\n \tuint8_t max_event_ports;\n-\t/**< Maximum number of event ports supported by this device */\n+\t/**< Maximum number of event ports supported by this device\n+\t * This excludes any queue-port pairs covered by the\n+\t * *max_single_link_event_port_queue_pairs* value in this structure.\n+\t */\n \tuint8_t max_event_port_dequeue_depth;\n \t/**< Maximum number of events that can be dequeued at a time from an event port\n \t * on this device.\n@@ -618,13 +624,23 @@ struct rte_event_dev_config {\n \t */\n \tuint8_t nb_event_queues;\n \t/**< Number of event queues to configure on this device.\n-\t * This value cannot exceed @ref rte_event_dev_info.max_event_queues\n-\t * returned by rte_event_dev_info_get()\n+\t * This value *includes* any single-link queue-port pairs to be used.\n+\t * This value cannot exceed @ref rte_event_dev_info.max_event_queues +\n+\t * @ref rte_event_dev_info.max_single_link_event_port_queue_pairs\n+\t * returned by rte_event_dev_info_get().\n+\t * The number of non-single-link queues i.e. this value less\n+\t * *nb_single_link_event_port_queues* in this struct, cannot exceed\n+\t * @ref rte_event_dev_info.max_event_queues\n \t */\n \tuint8_t nb_event_ports;\n \t/**< Number of event ports to configure on this device.\n-\t * This value cannot exceed @ref rte_event_dev_info.max_event_ports\n-\t * returned by rte_event_dev_info_get()\n+\t * This value *includes* any single-link queue-port pairs to be used.\n+\t * This value cannot exceed @ref rte_event_dev_info.max_event_ports +\n+\t * @ref rte_event_dev_info.max_single_link_event_port_queue_pairs\n+\t * returned by rte_event_dev_info_get().\n+\t * The number of non-single-link ports i.e. this value less\n+\t * *nb_single_link_event_port_queues* in this struct, cannot exceed\n+\t * @ref rte_event_dev_info.max_event_ports\n \t */\n \tuint32_t nb_event_queue_flows;\n \t/**< Max number of flows needed for a single event queue on this device.\n", "prefixes": [ "v1", "7/7" ] }