Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135936/?format=api
{ "id": 135936, "url": "http://patches.dpdk.org/api/patches/135936/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240117182541.211125-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240117182541.211125-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240117182541.211125-5-stephen@networkplumber.org", "date": "2024-01-17T18:19:58", "name": "[v4,4/6] net/i40e: avoid using const variable in assertion", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6beb7b8afbb1ad6556da7e2a352de1089d411419", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240117182541.211125-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 30824, "url": "http://patches.dpdk.org/api/series/30824/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30824", "date": "2024-01-17T18:19:54", "name": "use static assert to cathc build errors", "version": 4, "mbox": "http://patches.dpdk.org/series/30824/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135936/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/135936/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DF490438E4;\n\tWed, 17 Jan 2024 19:26:18 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 33BA840EE4;\n\tWed, 17 Jan 2024 19:25:59 +0100 (CET)", "from mail-pl1-f171.google.com (mail-pl1-f171.google.com\n [209.85.214.171])\n by mails.dpdk.org (Postfix) with ESMTP id 3C20C40E8A\n for <dev@dpdk.org>; Wed, 17 Jan 2024 19:25:55 +0100 (CET)", "by mail-pl1-f171.google.com with SMTP id\n d9443c01a7336-1d5ece717aeso14283315ad.1\n for <dev@dpdk.org>; Wed, 17 Jan 2024 10:25:55 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n qj15-20020a17090b28cf00b0028ce507cd7dsm14334124pjb.55.2024.01.17.10.25.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 17 Jan 2024 10:25:54 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1705515954;\n x=1706120754; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=qcapsTAS2FrBqtvBRyu1/qQWJzr7RLLy4mS98JGu2bE=;\n b=ogQ0oPpnjLJSCaj43afXL6oNaBnS3R99jcnEhMJei/sLq/29FyC/P+rQ4sX8Z8y388\n 1Lt09b1KjITXGl/wAESv+X6k4I+F/poqzELf8KpzK2LdT1PZeiK6ZTXk34QLWnc0ECrh\n sj+B4iUs4CdFaRtf3VsOcvSWDf4itnH/DRrIc1E0JxL4yZX5EUZUN0UEye8sVRBiDm8O\n 7tecTS7vEDTuZ79C7ib9fddynI2Alrl2We3BkZLfBNU8SDkNz6vehthp+AzSMD2ANnNZ\n 90toJ8JWMiT4RmM4GYWn8HNRNhxqVIRWzNdNSrLhnPPVKtaVaQg9cAlF5CHXJt5A7mKh\n Z1dg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1705515954; x=1706120754;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=qcapsTAS2FrBqtvBRyu1/qQWJzr7RLLy4mS98JGu2bE=;\n b=YYhbZx551Tmu1QxeeuzBmikHIHewQX6m8bpc0rAfvXSO7hR/baitHHkp3VNsOvaV1n\n krA5GoGPlk0nER/wm208ZzMzWlxXkPuJjXITuhWR303fMqWId9+ftpEvdgrawkqBscfK\n sIQNnWlrZSY71pMmUGe3kcQ2nt4wiLja/IxWNKYS0UeDpzD1KIzr9m5cpBTmcKyK7K9w\n 0JF0Clj7k6rc6/AH8f9PJaVfBbg/E51nXyYrJfGQbt1Ex4AIGJCcX4DzDOFlWQMvepuc\n RcM9pr9NSeqTI90Ym3d18ftaVZ2u55/7lA5exTnV4CbYoT1k7UyXFyvmCUnc1tiY0B8C\n uLQg==", "X-Gm-Message-State": "AOJu0YyGZhfN+6WsGn4uG5B7qb64QdE/tSlaBgxficVA/O9Sp5mTa479\n zTSZKYdvtKIvvJ2ITuVSdrbQVT/D5SxR6F0nsucepZb8knUjGw==", "X-Google-Smtp-Source": "\n AGHT+IEV7BNDwQEAqqWAujDI98vNhOckBaPN2OPYV3PeRZzcWtnowmu8q8wxuhtdCF8U4Ge9aAgzRg==", "X-Received": "by 2002:a17:90b:3e87:b0:28c:7ca2:ee49 with SMTP id\n rj7-20020a17090b3e8700b0028c7ca2ee49mr5012604pjb.54.1705515954485;\n Wed, 17 Jan 2024 10:25:54 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Yuying Zhang <Yuying.Zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "Subject": "[PATCH v4 4/6] net/i40e: avoid using const variable in assertion", "Date": "Wed, 17 Jan 2024 10:19:58 -0800", "Message-ID": "<20240117182541.211125-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240117182541.211125-1-stephen@networkplumber.org>", "References": "<20231111172153.57461-1-stephen@networkplumber.org>\n <20240117182541.211125-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Clang does not allow const variable in a static_assert\nexpression.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/i40e/i40e_ethdev.h | 1 +\n drivers/net/i40e/i40e_rxtx_vec_sse.c | 10 ++++------\n 2 files changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h\nindex 1bbe7ad37600..445e1c0b381f 100644\n--- a/drivers/net/i40e/i40e_ethdev.h\n+++ b/drivers/net/i40e/i40e_ethdev.h\n@@ -278,6 +278,7 @@ enum i40e_flxpld_layer_idx {\n #define I40E_DEFAULT_DCB_APP_PRIO 3\n \n #define I40E_FDIR_PRG_PKT_CNT 128\n+#define I40E_FDIR_ID_BIT_SHIFT\t 13\n \n /*\n * Struct to store flow created.\ndiff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c b/drivers/net/i40e/i40e_rxtx_vec_sse.c\nindex 9200a23ff662..2d4480a7651b 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_sse.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c\n@@ -143,10 +143,9 @@ descs_to_fdir_32b(volatile union i40e_rx_desc *rxdp, struct rte_mbuf **rx_pkt)\n \t/* convert fdir_id_mask into a single bit, then shift as required for\n \t * correct location in the mbuf->olflags\n \t */\n-\tconst uint32_t FDIR_ID_BIT_SHIFT = 13;\n-\tRTE_BUILD_BUG_ON(RTE_MBUF_F_RX_FDIR_ID != (1 << FDIR_ID_BIT_SHIFT));\n+\tRTE_BUILD_BUG_ON(RTE_MBUF_F_RX_FDIR_ID != (1 << I40E_FDIR_ID_BIT_SHIFT));\n \tv_fd_id_mask = _mm_srli_epi32(v_fd_id_mask, 31);\n-\tv_fd_id_mask = _mm_slli_epi32(v_fd_id_mask, FDIR_ID_BIT_SHIFT);\n+\tv_fd_id_mask = _mm_slli_epi32(v_fd_id_mask, I40E_FDIR_ID_BIT_SHIFT);\n \n \t/* The returned value must be combined into each mbuf. This is already\n \t * being done for RSS and VLAN mbuf olflags, so return bits to OR in.\n@@ -205,10 +204,9 @@ descs_to_fdir_16b(__m128i fltstat, __m128i descs[4], struct rte_mbuf **rx_pkt)\n \tdescs[0] = _mm_blendv_epi8(descs[0], _mm_setzero_si128(), v_desc0_mask);\n \n \t/* Shift to 1 or 0 bit per u32 lane, then to RTE_MBUF_F_RX_FDIR_ID offset */\n-\tconst uint32_t FDIR_ID_BIT_SHIFT = 13;\n-\tRTE_BUILD_BUG_ON(RTE_MBUF_F_RX_FDIR_ID != (1 << FDIR_ID_BIT_SHIFT));\n+\tRTE_BUILD_BUG_ON(RTE_MBUF_F_RX_FDIR_ID != (1 << I40E_FDIR_ID_BIT_SHIFT));\n \t__m128i v_mask_one_bit = _mm_srli_epi32(v_fdir_id_mask, 31);\n-\treturn _mm_slli_epi32(v_mask_one_bit, FDIR_ID_BIT_SHIFT);\n+\treturn _mm_slli_epi32(v_mask_one_bit, I40E_FDIR_ID_BIT_SHIFT);\n }\n #endif\n \n", "prefixes": [ "v4", "4/6" ] }