Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135809/?format=api
{ "id": 135809, "url": "http://patches.dpdk.org/api/patches/135809/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240109142343.163814-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240109142343.163814-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240109142343.163814-1-bruce.richardson@intel.com", "date": "2024-01-09T14:23:43", "name": "net/vmxnet3: fix use of interrupts on FreeBSD", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1f0bb0878518b863ee5ba1a7bc4284ae6ebd5c13", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240109142343.163814-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 30768, "url": "http://patches.dpdk.org/api/series/30768/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30768", "date": "2024-01-09T14:23:43", "name": "net/vmxnet3: fix use of interrupts on FreeBSD", "version": 1, "mbox": "http://patches.dpdk.org/series/30768/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135809/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/135809/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64F8643873;\n\tTue, 9 Jan 2024 15:24:28 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 03BF44021F;\n\tTue, 9 Jan 2024 15:24:28 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id D925D4013F\n for <dev@dpdk.org>; Tue, 9 Jan 2024 15:24:25 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jan 2024 06:24:24 -0800", "from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.148])\n by orsmga004.jf.intel.com with ESMTP; 09 Jan 2024 06:24:23 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1704810266; x=1736346266;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=j0SMlVSsnuNgwa5HctSUinkJPH0DVeAVUa41Yih7dXA=;\n b=Kg4d1PAK9vYTC1jLzCOc/Mlw3wsv028JNbFn8nYMXSlLYuOAA8a2qrJp\n O89cjeyq3MPIEe9Myirmr3KLSQsSKeE6fOhgKyL62hkcGpgmYfYsGY381\n lueWypo185cly6uKwpeYIGLbOIP88TKc88qtuTmGY5yLHiXjITD5+0A++\n WgRftLwMEDl6ePEI2T0wC12XiSaYP8bIQ3NPSg6fR60JQk3Gbl+H4fybM\n unDd81DEoRGwo566/B1ii4FI15e727hwA7L3gxUaI54CtLQ1v3RgVr/Q0\n 88nGf3xTGzG8QOSrjbjfMh/JwO2pr7UGX0hvYXN+OLp0/llVp8Ltje27T w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10947\"; a=\"401997611\"", "E=Sophos;i=\"6.04,183,1695711600\"; d=\"scan'208\";a=\"401997611\"", "E=McAfee;i=\"6600,9927,10947\"; a=\"905170752\"", "E=Sophos;i=\"6.04,183,1695711600\"; d=\"scan'208\";a=\"905170752\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Lewis Donzis <lew@perftech.com>, Jochen Behrens <jbehrens@vmware.com>,\n Yong Wang <wang.yong19@zte.com.cn>", "Subject": "[PATCH] net/vmxnet3: fix use of interrupts on FreeBSD", "Date": "Tue, 9 Jan 2024 14:23:43 +0000", "Message-Id": "<20240109142343.163814-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<12922153.12944.1704552603431.JavaMail.zimbra@donzis.com>", "References": "<12922153.12944.1704552603431.JavaMail.zimbra@donzis.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "DPDK does not support interrupts on FreeBSD, so the vmxnet3 driver\nreturns error when enabling interrupts as it initializes. We can fix\nthis by #ifdef'ing out the interrupt calls when building for FreeBSD,\nallowing the driver to initialize correctly.\n\nFixes: 046f11619567 (\"net/vmxnet3: support MSI-X interrupt\")\n\nReported-by: Lewis Donzis <lew@perftech.com>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex e49191718a..7032f0e324 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -257,6 +257,7 @@ vmxnet3_disable_all_intrs(struct vmxnet3_hw *hw)\n \t\tvmxnet3_disable_intr(hw, i);\n }\n \n+#ifndef RTE_EXEC_ENV_FREEBSD\n /*\n * Enable all intrs used by the device\n */\n@@ -280,6 +281,7 @@ vmxnet3_enable_all_intrs(struct vmxnet3_hw *hw)\n \t\t\tvmxnet3_enable_intr(hw, i);\n \t}\n }\n+#endif\n \n /*\n * Gets tx data ring descriptor size.\n@@ -1129,6 +1131,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)\n \t/* Setting proper Rx Mode and issue Rx Mode Update command */\n \tvmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);\n \n+#ifndef RTE_EXEC_ENV_FREEBSD\n \t/* Setup interrupt callback */\n \trte_intr_callback_register(dev->intr_handle,\n \t\t\t\t vmxnet3_interrupt_handler, dev);\n@@ -1140,6 +1143,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)\n \n \t/* enable all intrs */\n \tvmxnet3_enable_all_intrs(hw);\n+#endif\n \n \tvmxnet3_process_events(dev);\n \n", "prefixes": [] }