Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135705/?format=api
{ "id": 135705, "url": "http://patches.dpdk.org/api/patches/135705/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240103111035.361905-1-kuka@cesnet.cz/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240103111035.361905-1-kuka@cesnet.cz>", "list_archive_url": "https://inbox.dpdk.org/dev/20240103111035.361905-1-kuka@cesnet.cz", "date": "2024-01-03T11:10:35", "name": "net/bonding: fix query-count flags not set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "101d54ebde837d42d4c5fc6bae6af3dc8c533636", "submitter": { "id": 2786, "url": "http://patches.dpdk.org/api/people/2786/?format=api", "name": "Mário Kuka", "email": "kuka@cesnet.cz" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240103111035.361905-1-kuka@cesnet.cz/mbox/", "series": [ { "id": 30711, "url": "http://patches.dpdk.org/api/series/30711/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30711", "date": "2024-01-03T11:10:35", "name": "net/bonding: fix query-count flags not set", "version": 1, "mbox": "http://patches.dpdk.org/series/30711/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/135705/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/135705/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E29A1437DF;\n\tWed, 3 Jan 2024 12:10:45 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 767B5402E9;\n\tWed, 3 Jan 2024 12:10:45 +0100 (CET)", "from office2.cesnet.cz (office2.cesnet.cz [78.128.248.237])\n by mails.dpdk.org (Postfix) with ESMTP id D0907402BE\n for <dev@dpdk.org>; Wed, 3 Jan 2024 12:10:43 +0100 (CET)", "from ovs.liberouter.org (rt-tmc-kou.liberouter.org\n [195.113.172.126])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by office2.cesnet.cz (Postfix) with ESMTPSA id C32DF118007D;\n Wed, 3 Jan 2024 12:10:37 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz;\n s=office2-2020; t=1704280242;\n bh=i0U2AEPAAWAtAdgJjb9nyQti/m4+VvdvOC7RzXFGppM=;\n h=From:To:Cc:Subject:Date;\n b=fnPdEYjvzxZXrQ2OJ+SdgdUTiNwH2d/V9Q4JM4zD9p9DxASspoJyimse4MJY2wQji\n N/D5pBkm6jblwZlpcKi89Q/xikKjTfJxrGYBBK8I570R3V8o3W9wZ8potnFEKopvTz\n oWulw+LO9Or0/U2RTk4dW4uCx+tY0y6eZfabW9gXMPiJV8mKiiuMJHyWyA4wyf6lVt\n LyyeojdONR9AE33FqG8f26KmhqZhakZ7eSQNSCxXxaDFDJxGsZd5pRxySbzkFJh2ai\n PrgNzvz4DvFRTaNxxG1/LdxjDTDWGLJHSzWaoi0Csaw+iEsjwIL59N44GOZXcsTK9v\n rjZYC6q6JS8Pw==", "From": "=?utf-8?q?M=C3=A1rio_Kuka?= <kuka@cesnet.cz>", "To": "Chas Williams <chas3@att.com>, \"Min Hu (Connor)\" <humin29@huawei.com>,\n Declan Doherty <declan.doherty@intel.com>, Matan Azrad <matan@nvidia.com>", "Cc": "dev@dpdk.org, =?utf-8?q?M=C3=A1rio_Kuka?= <kuka@cesnet.cz>,\n matan@mellanox.com", "Subject": "[PATCH] net/bonding: fix query-count flags not set", "Date": "Wed, 3 Jan 2024 12:10:35 +0100", "Message-Id": "<20240103111035.361905-1-kuka@cesnet.cz>", "X-Mailer": "git-send-email 2.39.3", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_flow_query_count structure returned from the bonding driver\nalways indicates that hits and bytes are invalid (bytes_set and\nhits_set flags are zero) because bond_flow_query_count() from the\nnet/bonding driver does not set the bytes_set and hits_set flags.\n\nFixes: 49dad9028e2a (\"net/bonding: support flow API\")\nCc: matan@mellanox.com\n\nSigned-off-by: Mário Kuka <kuka@cesnet.cz>\n---\n drivers/net/bonding/rte_eth_bond_flow.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_flow.c b/drivers/net/bonding/rte_eth_bond_flow.c\nindex 71a91675f7..5d0be5caf5 100644\n--- a/drivers/net/bonding/rte_eth_bond_flow.c\n+++ b/drivers/net/bonding/rte_eth_bond_flow.c\n@@ -180,6 +180,8 @@ bond_flow_query_count(struct rte_eth_dev *dev, struct rte_flow *flow,\n \n \tcount->bytes = 0;\n \tcount->hits = 0;\n+\tcount->bytes_set = 0;\n+\tcount->hits_set = 0;\n \trte_memcpy(&member_count, count, sizeof(member_count));\n \tfor (i = 0; i < internals->member_count; i++) {\n \t\tret = rte_flow_query(internals->members[i].port_id,\n@@ -192,8 +194,12 @@ bond_flow_query_count(struct rte_eth_dev *dev, struct rte_flow *flow,\n \t\t}\n \t\tcount->bytes += member_count.bytes;\n \t\tcount->hits += member_count.hits;\n+\t\tcount->bytes_set |= member_count.bytes_set;\n+\t\tcount->hits_set |= member_count.hits_set;\n \t\tmember_count.bytes = 0;\n \t\tmember_count.hits = 0;\n+\t\tmember_count.bytes_set = 0;\n+\t\tmember_count.hits_set = 0;\n \t}\n \treturn 0;\n }\n", "prefixes": [] }